[Lldb-commits] [lldb] [lldb] Fix error reporting in SBTarget::ReadMemory (PR #109764)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The function should use the by-ref SBError argument instead of creating a new one. This code has been here since ~forever, and was probably copied from methods which return an SBError result (where one needs t

[Lldb-commits] [lldb] [lldb] Fix error reporting in SBTarget::ReadMemory (PR #109764)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/109764 The function should use the by-ref SBError argument instead of creating a new one. This code has been here since ~forever, and was probably copied from methods which return an SBError result (where one needs to

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer { if (!sc.function) return {}; +// Check if we have a regex match +bool matches_regex = false; for (RegularExpression &r : m_hidden_regex) - if (r.Execute(sc.function->GetN

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

vogelsgesang wrote: @jimingham I agree with everything you wrote. I think you misunderstood the context based on the way GitHub provided you some misleadning context in the email notification, though https://github.com/llvm/llvm-project/pull/108870 _

[Lldb-commits] [lldb] [lldb][NFC] Add a missing setter method for UnwindPlans (PR #109751)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The UnwindPlan class has getter and setter methods for specifying an abstract register location, but it doesn't have a setter for a DWARF Expression register location. This hasn't been needed for any o

[Lldb-commits] [lldb] [lldb][NFC] Add a missing setter method for UnwindPlans (PR #109751)

https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/109751 The UnwindPlan class has getter and setter methods for specifying an abstract register location, but it doesn't have a setter for a DWARF Expression register location. This hasn't been needed for any of t

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain( return true; } +bool DebugNamesDWARFIndex::WithinParentChain( +llvm::ArrayRef query_parent_names, +llvm::ArrayRef parent_chain) const { + if (parent_chain.size() < query_parent_names.size()) +retur

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

jeffreytan81 wrote: This PR has been updated to only contain the type lookup using .debug_names parent chain. Later PRs will add namespace changes and `SameAsATName` algorithm change. https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to define custom completers to the parsed_cmd template. (PR #109062)

https://github.com/medismailben approved this pull request. LGTM! Thanks for addressing my comments :) https://github.com/llvm/llvm-project/pull/109062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] Add the ability to define custom completers to the parsed_cmd template. (PR #109062)

@@ -43,7 +43,65 @@ def __call__(self, debugger, args_list, exe_ctx, result): will return True if the user set this option, and False if it was left at its default value. -There are example commands in the lldb testsuite at: +Custom Completions: + +You can also implement custo

[Lldb-commits] [lldb] Add the ability to define custom completers to the parsed_cmd template. (PR #109062)

@@ -43,7 +43,65 @@ def __call__(self, debugger, args_list, exe_ctx, result): will return True if the user set this option, and False if it was left at its default value. -There are example commands in the lldb testsuite at: +Custom Completions: + +You can also implement custo

[Lldb-commits] [lldb] Add the ability to define custom completers to the parsed_cmd template. (PR #109062)

@@ -43,7 +43,65 @@ def __call__(self, debugger, args_list, exe_ctx, result): will return True if the user set this option, and False if it was left at its default value. -There are example commands in the lldb testsuite at: +Custom Completions: + +You can also implement custo

[Lldb-commits] [lldb] Add the ability to define custom completers to the parsed_cmd template. (PR #109062)

@@ -587,8 +587,150 @@ say SBCommandReturnObject and SBStream both support this file-like behavior by providing write() and flush() calls at the Python layer. +The commands that are added using this Class definition are what lldb calls +"raw" commands. The command interpreter

[Lldb-commits] [lldb] Add the ability to define custom completers to the parsed_cmd template. (PR #109062)

@@ -587,8 +587,150 @@ say SBCommandReturnObject and SBStream both support this file-like behavior by providing write() and flush() calls at the Python layer. +The commands that are added using this Class definition are what lldb calls +"raw" commands. The command interpreter

[Lldb-commits] [lldb] Add the ability to define custom completers to the parsed_cmd template. (PR #109062)

@@ -587,8 +587,150 @@ say SBCommandReturnObject and SBStream both support this file-like behavior by providing write() and flush() calls at the Python layer. +The commands that are added using this Class definition are what lldb calls jimingham wrote: done h

[Lldb-commits] [lldb] Add the ability to define custom completers to the parsed_cmd template. (PR #109062)

https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/109062 >From a0b5801ab231670215657ec720fa0c89bc262c04 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 29 Aug 2024 18:22:13 -0700 Subject: [PATCH 1/3] Add the ability to define custom completers for option value

[Lldb-commits] [lldb] Add the ability to define custom completers to the parsed_cmd template. (PR #109062)

@@ -1637,6 +1637,129 @@ class CommandObjectScriptingObjectParsed : public CommandObjectParsed { size_t GetNumOptions() { return m_num_options; } +void PrepareOptionsForCompletion(CompletionRequest &request, + OptionElementVector &o

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

https://github.com/DmT021 updated https://github.com/llvm/llvm-project/pull/102835 >From 424b3b74d54b10067155f0ceaeec80c78d2e6aab Mon Sep 17 00:00:00 2001 From: Dmitrii Galimzianov Date: Tue, 24 Sep 2024 00:33:43 +0200 Subject: [PATCH] Remove redundant symbol lookups in IRExecutionUnit::FindIn

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

https://github.com/jimingham approved this pull request. LGTM. I went through and made a couple non-essential comment suggestions. But this looks ready to go in to me. https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > @clayborg @jimingham Can I please have some love? I don't want to keep > telling users "you should be using GDB" and I've done a significant amount of > work here. Ack, sorry I'm bad at the formalities. I was under the impression that most of the actual reviewing had been

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3271,6 +3273,11 @@ Status Process::PrivateResume() { if (!GetModID().IsLastResumeForUserExpression()) ResetExtendedCrashInfoDict(); + if (m_last_run_direction != direction) { jimingham wrote: In the "resolved" discussion we talked about the fact th

[Lldb-commits] [lldb] 1fae131 - [lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)

Author: Adrian Prantl Date: 2024-09-23T14:33:41-07:00 New Revision: 1fae1314f1ff58f3601640c0a2c48cee3a322e5d URL: https://github.com/llvm/llvm-project/commit/1fae1314f1ff58f3601640c0a2c48cee3a322e5d DIFF: https://github.com/llvm/llvm-project/commit/1fae1314f1ff58f3601640c0a2c48cee3a322e5d.diff

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -510,8 +510,9 @@ def start(self): self._thread.start() def stop(self): -self._thread.join() -self._thread = None +if self._thread is not None: jimingham wrote: It's not obvious when you'd get a stop with no thread. Why

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -142,6 +142,9 @@ class StopInfo : public std::enable_shared_from_this { static lldb::StopInfoSP CreateStopReasonProcessorTrace(Thread &thread, const char *description); + static lldb::StopInfoSP jimingham wrote: Ah, okay, you do for eStopReasonHistor

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -142,6 +142,9 @@ class StopInfo : public std::enable_shared_from_this { static lldb::StopInfoSP CreateStopReasonProcessorTrace(Thread &thread, const char *description); + static lldb::StopInfoSP jimingham wrote: Do you somewhere make it obvious what

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3169,6 +3176,7 @@ void PruneThreadPlans(); // m_currently_handling_do_on_removals are true, // Resume will only request a resume, using this // flag to check. + lldb::RunDirection m_last_run_d

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

jimingham wrote: > On Sep 23, 2024, at 11:46 AM, Adrian Vogelsgesang ***@***.***> wrote: > > > @vogelsgesang commented on this pull request. > > In libcxx/docs/UserDocumentation.rst > : > > > + > + (lldb) thread back

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/7] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

vogelsgesang wrote: > [...] it may returned cached data from disk for running processes (which > means it will be faster, but potentially return incorrect data). I think the 2nd point shouldn't be an issue because `SBTarget::ReadMemory` sets `force_live_memory` to true when calling `Target::Re

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109485 >From f461249eed7bf26f87b156d071ad2a12ecd231ab Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Fri, 20 Sep 2024 21:05:54 + Subject: [PATCH 1/3] [lldb-dap] Simplify `readMemory` The `readMemory

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109485 >From 48718649469aae62b2945e7de22cf7280316b757 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Fri, 20 Sep 2024 21:05:54 + Subject: [PATCH 1/2] [lldb-dap] Simplify `readMemory` The `readMemory

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType( m_fallback.GetFullyQualifiedType(context, callback); } +bool DebugNamesDWARFIndex::SameAsEntryATName( +llvm::StringRef query_name, const DebugNames::Entry &entry) const { + auto maybe_dieoffset = en

[Lldb-commits] [lldb] 6e6d5ea - [lldb] Don't invalid register context after setting thread pc's (#109499)

Author: Jason Molenda Date: 2024-09-23T12:13:48-07:00 New Revision: 6e6d5eae765939cc4074bdd606658e78c4a2a559 URL: https://github.com/llvm/llvm-project/commit/6e6d5eae765939cc4074bdd606658e78c4a2a559 DIFF: https://github.com/llvm/llvm-project/commit/6e6d5eae765939cc4074bdd606658e78c4a2a559.diff

[Lldb-commits] [lldb] [lldb] Don't invalid register context after setting thread pc's (PR #109499)

https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/109499 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't invalid register context after setting thread pc's (PR #109499)

https://github.com/jimingham approved this pull request. LGTM. Given InvalidateIfNeeded (which by name seems harmless) can have these undesirably effects (presumably only when you pass true for force) it might be nice to warn developers about this by adding an instructive comment to Invalid

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/6] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

@@ -346,6 +346,31 @@ Third-party Integrations Libc++ provides integration with a few third-party tools. +Debugging libc++ internals in LLDB +-- + +LLDB hides the implementation details of libc++ by default. + +E.g., when setting a breakpoint in

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

vogelsgesang wrote: @Michael137 thanks for the review! I updated the pull request accordingly https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/6] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer { if (!sc.function) return {}; +// Check if we have a regex match +bool matches_regex = false; for (RegularExpression &r : m_hidden_regex) - if (r.Execute(sc.function->GetN

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/104238 >From 792cb17f05ded47b152408ac7f4d1de6c986013f Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 6 Sep 2024 16:12:50 +0400 Subject: [PATCH 1/4] [lldb] Removed gdbserver ports map from lldb-server Liste

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

vogelsgesang wrote: CC @labath since you aparrently already put some thoughts into this 2 years ago, when opening #56144 https://github.com/llvm/llvm-project/pull/109594 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

vogelsgesang wrote: I just realized that this was previously mentioned in #56144. The comments on that item make me wonder if this commit here actually even uses the right approach... Should I instead extend the recognizer framework to also match on the non-topmost frame? https://github.com/l

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

Jlalond wrote: @labath I really like the idea to add the TLS saving to the dynamic loader, I'll add that, As for the dynamic loader, I don't like how I've modified it. When a minidump is loaded, the link map isn't properly relocated, so TLS data is searched for relative to module lowest in m

[Lldb-commits] [lldb] [lldb] Don't invalid register context after setting thread pc's (PR #109499)

jasonmolenda wrote: > What's the exact situation that triggered these extra packets. Could it be > simulated from a gdb-remote client test (i.e., by mocking server responses)? We've always done it when we step over our dynamic loader notification breakpoint (when new solibs are loaded and lldb

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

https://github.com/walter-erquinigo approved this pull request. beautiful. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 97b0d20 - Revert "[lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)"

Author: Adrian Prantl Date: 2024-09-23T10:50:51-07:00 New Revision: 97b0d2076f53f669f27dc6d0539a3d01f28381e7 URL: https://github.com/llvm/llvm-project/commit/97b0d2076f53f669f27dc6d0539a3d01f28381e7 DIFF: https://github.com/llvm/llvm-project/commit/97b0d2076f53f669f27dc6d0539a3d01f28381e7.diff

[Lldb-commits] [lldb] [lldb][AArch64] Create Neon subregs when XML only includes SVE (PR #108365)

https://github.com/jasonmolenda approved this pull request. I read through the patch, this looks good to me. https://github.com/llvm/llvm-project/pull/108365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb][NFC] New names for the two RegisterLocation classes (PR #109611)

https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/109611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3336d73 - [lldb][NFC] New names for the two RegisterLocation classes (#109611)

Author: Jason Molenda Date: 2024-09-23T10:29:21-07:00 New Revision: 3336d73126ae7ebaadf7c3a4d85e373eaae8cda6 URL: https://github.com/llvm/llvm-project/commit/3336d73126ae7ebaadf7c3a4d85e373eaae8cda6 DIFF: https://github.com/llvm/llvm-project/commit/3336d73126ae7ebaadf7c3a4d85e373eaae8cda6.diff

[Lldb-commits] [lldb] 40d8888 - [lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)

Author: Adrian Prantl Date: 2024-09-23T09:35:27-07:00 New Revision: 40df13fb54b0fe840deef23054de6544c184 URL: https://github.com/llvm/llvm-project/commit/40df13fb54b0fe840deef23054de6544c184 DIFF: https://github.com/llvm/llvm-project/commit/40df13fb54b0fe840deef23054de6544c184.diff

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain( return true; } +bool DebugNamesDWARFIndex::WithinParentChain( +llvm::ArrayRef query_parent_names, +llvm::ArrayRef parent_chain) const { + if (parent_chain.size() < query_parent_names.size()) +retur

[Lldb-commits] [lldb] [lldb][NFC] New names for the two RegisterLocation classes (PR #109611)

https://github.com/felipepiovezan approved this pull request. As someone who was just recently learning about these parts of the codebase, this renaming will definitely make things easier! Thanks for creating this patch! https://github.com/llvm/llvm-project/pull/109611

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -150,12 +153,17 @@ static void client_handle(GDBRemoteCommunicationServerPlatform &platform, printf("Disconnected.\n"); } -static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap; -static std::mutex gdbserver_portmap_mutex; - static void spawn_process_rea

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

abhina-sree wrote: > OpenFlags |= sys::fs::OF_Text; Thanks, I've made your suggested change and I opened a new PR here https://github.com/llvm/llvm-project/pull/109664. A short explanation for why distinguishing text and binary files on z/OS is important is because the native encoding is not

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

@@ -0,0 +1,94 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer { if (!sc.function) return {}; +// Check if we have a regex match +bool matches_regex = false; for (RegularExpression &r : m_hidden_regex) - if (r.Execute(sc.function->GetN

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer { if (!sc.function) return {}; +// Check if we have a regex match +bool matches_regex = false; for (RegularExpression &r : m_hidden_regex) Michael137 wrote: Ad

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

@@ -346,6 +346,31 @@ Third-party Integrations Libc++ provides integration with a few third-party tools. +Debugging libc++ internals in LLDB +-- + +LLDB hides the implementation details of libc++ by default. + +E.g., when setting a breakpoint in

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer { if (!sc.function) return {}; +// Check if we have a regex match +bool matches_regex = false; for (RegularExpression &r : m_hidden_regex) - if (r.Execute(sc.function->GetN

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer { if (!sc.function) return {}; +// Check if we have a regex match +bool matches_regex = false; for (RegularExpression &r : m_hidden_regex) - if (r.Execute(sc.function->GetN

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

slydiman wrote: > But do both of those callers need the "optional launch" functionality? AIUI, > it's only the Handle_qLaunchGDBServer that does, and the code in > lldb-platform.cpp should launch a server unconditionally. We can launch gdbserver with tcp protocol only after accepting the conne

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

https://github.com/Michael137 approved this pull request. > I did not add a testcase because it would require a specific glibc. To test this you could probably build a `libc.so` as part of building the test. Then have a dummy `__pthread_kill_implementation` in it. But given we haven't done thi

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

nikic wrote: @dtcxzyw Thanks for pointing that out! I think truncation here is the semantically wrong thing to do. I added a check that we fit the bit width instead in https://github.com/llvm/llvm-project/commit/6f194a6dea4b4067336431e699ea3588417d4b96. https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -160,66 +95,56 @@ GDBRemoteCommunicationServerPlatform::~GDBRemoteCommunicationServerPlatform() = default; Status GDBRemoteCommunicationServerPlatform::LaunchGDBServer( -const lldb_private::Args &args, std::string hostname, lldb::pid_t &pid, -std::optional &por

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -195,18 +195,31 @@ void ConnectToRemote(MainLoop &mainloop, bool reverse_connect, llvm::StringRef host_and_port, const char *const progname, const char *const subcommand, const char *const named_pipe_path, pipe_t

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

@@ -393,125 +362,222 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); + Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; + if (fd != SharedSocket::kInvalidFD) {

[Lldb-commits] [clang] [lldb] [AMDGPU] Specify width and align for all AMDGPU builtin types. NFC. (PR #109656)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Jay Foad (jayfoad) Changes This will be used in ASTContext::getTypeInfo which needs this information for all builtin types, not just pointers. --- Patch is 20.84 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/l

[Lldb-commits] [clang] [lldb] [AMDGPU] Specify width and align for all AMDGPU builtin types. NFC. (PR #109656)

llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-lldb Author: Jay Foad (jayfoad) Changes This will be used in ASTContext::getTypeInfo which needs this information for all builtin types, not just pointers. --- Patch is 20.84 KiB, trunc

[Lldb-commits] [clang] [lldb] [AMDGPU] Specify width and align for all AMDGPU builtin types. NFC. (PR #109656)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Jay Foad (jayfoad) Changes This will be used in ASTContext::getTypeInfo which needs this information for all builtin types, not just pointers. --- Patch is 20.84 KiB, truncated to 20.00 KiB below, full version: https://github.co

[Lldb-commits] [clang] [lldb] [AMDGPU] Specify width and align for all AMDGPU builtin types. NFC. (PR #109656)

https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/109656 This will be used in ASTContext::getTypeInfo which needs this information for all builtin types, not just pointers. >From 0ef4ea17a711a1ee95080bc1635ae9aa824df596 Mon Sep 17 00:00:00 2001 From: Jay Foad Date:

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

@@ -0,0 +1,94 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/109427 >From cc4032e58217a01ff414b8d03866a1631f492df8 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 20 Sep 2024 14:00:44 +0100 Subject: [PATCH 1/3] [lldb][docs] Resurrect the information on adding a ne

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

@@ -0,0 +1,94 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

@@ -0,0 +1,94 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

@@ -0,0 +1,94 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

DavidSpickett wrote: > I think this page leaves a lot to be desired but it's a good start. Given that language support runs from: * Pretend it's C++ and hope (Rust) to - * Have an entire llvm fork (Swift). The documentation is never going to be great, this is true. Next time a language is adde

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/109427 >From cc4032e58217a01ff414b8d03866a1631f492df8 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 20 Sep 2024 14:00:44 +0100 Subject: [PATCH 1/2] [lldb][docs] Resurrect the information on adding a ne

[Lldb-commits] [lldb] 85220a0 - [lldb][FreeBSD] Fix a typo in NativeProcessFreeBSD::MonitorSIGTRAP() (#109643)

Author: Kelvin Lee Date: 2024-09-23T11:44:58+01:00 New Revision: 85220a0c651e565ab576c5be17c1ec5c9eb2a350 URL: https://github.com/llvm/llvm-project/commit/85220a0c651e565ab576c5be17c1ec5c9eb2a350 DIFF: https://github.com/llvm/llvm-project/commit/85220a0c651e565ab576c5be17c1ec5c9eb2a350.diff LO

[Lldb-commits] [lldb] [lldb][FreeBSD] Fix a typo in NativeProcessFreeBSD::MonitorSIGTRAP() (PR #109643)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/109643 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Fix a typo in NativeProcessFreeBSD::MonitorSIGTRAP() (PR #109643)

https://github.com/DavidSpickett approved this pull request. Caused by https://github.com/llvm/llvm-project/pull/108504. Thanks for the fix. https://github.com/llvm/llvm-project/pull/109643 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

<    9   10   11   12   13   14   15   16   17   18   >