D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner marked an inline comment as done. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner, #amarok, heikobecker, wbauer Cc: amarok-devel, vmatare, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill, jackyalcine,

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner updated this revision to Diff 78497. asturmlechner added a comment. re-add accidentally removed required includes to FindMySQLe.cmake REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28284?vs=78487&id=78497 BRANCH mysqle-split-for-phab REVISI

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

wbauer added a comment. In D28284#634644 , @wbauer wrote: > On openSUSE, it doesn't enable MySQLe anymore: > >-- Found MySQL: -L/usr/lib64 -lmariadb > /usr/bin/mysql_config: unrecognized option '--libmysqld-libs' > -- Performing

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

wbauer added a comment. On openSUSE, it doesn't enable MySQLe anymore: -- Found MySQL: -L/usr/lib64 -lmariadb /usr/bin/mysql_config: unrecognized option '--libmysqld-libs' -- Performing Test HAVE_MYSQL_OPT_EMBEDDED_CONNECTION -- Performing Test HAVE_MYSQL_OPT_EMBEDDED_CONN

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner edited the summary of this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner, #amarok, heikobecker, wbauer Cc: amarok-devel, vmatare, jfowkes, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill,

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner updated this revision to Diff 78487. asturmlechner added a comment. updated for the case when mysqle is shipped with mariadb REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28284?vs=78465&id=78487 BRANCH mysqle-split-for-phab REVISION DETAIL

D28165: Fix compatibility with modern MySQL

wbauer added a comment. In D28165#634060 , @asturmlechner wrote: > In D28165#633145 , @wbauer wrote: > > > The content of my /usr/include/mysql/mysql_version.h (which is just a symlink to mariadb_ve

D28165: Fix compatibility with modern MySQL

vmatare added a comment. > I assume you don't have commit access and you'll need somebody to push this patch for you, right? Yes, please go ahead if you think this has been tested well enough. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28165 To: vmatare, as

D28165: Fix compatibility with modern MySQL

wbauer added a comment. In D28165#634404 , @asturmlechner wrote: > Waiting for @wbauer to confirm it works as well Yes, the latest version builds fine here (the previous did as well), and the embedded collection still works as well.

D24817: Restore scripting functionalities and Qt bindings.

Herald added a project: Amarok. Herald removed a subscriber: Amarok. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24817 To: nicolamori, amarok-devel, heikobecker Cc: asturmlechner, malteveerman, heikobecker, amarok-devel, jfowkes, pgomes, nicolamori, jyasi, mfraser, r

D27949: Conclude porting of Last.fm to Amarok KF5

asturmlechner added a comment. scrobble it does 👍 REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D27949 To: pgomes, amarok-devel, #amarok Cc: heikobecker, asturmlechner, amarok-devel, #amarok, jfowkes, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, erid

D27949: Conclude porting of Last.fm to Amarok KF5

heikobecker added inline comments. INLINE COMMENTS > LastFmServiceConfig.h:37 > +#endif > + > /** Any reason not to use a generated export header for that? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D27949 To: pgomes, amarok-devel, #amarok Cc: heikobecker, asturml

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner created this revision. asturmlechner added reviewers: Amarok, heikobecker, wbauer. Herald added a project: Amarok. Herald added a subscriber: amarok-devel. asturmlechner requested review of this revision. REVISION SUMMARY - Previously, MariaDB lib was only found w/ distro provided

D28165: Fix compatibility with modern MySQL

heikobecker accepted this revision. heikobecker added a comment. Builds fine here with mariadb and WITH_MYSQL_EMBEDDED=TRUE. I assume you don't have commit access and you'll need somebody to push this patch for you, right? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.k

D28165: Fix compatibility with modern MySQL

asturmlechner added a comment. Waiting for @wbauer to confirm it works as well - btw, does openSUSE still provide mysqle to test -DWITH_MYSQL_EMBEDDED=on? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28165 To: vmatare, asturmlechner Cc: jfowkes, asturmlechner, wba

D28165: Fix compatibility with modern MySQL

asturmlechner accepted this revision. asturmlechner added a comment. This revision is now accepted and ready to land. In D28165#634067 , @vmatare wrote: > Please test again, and thanks a lot for the review so far. Successfully tested with: