RE: [PATCH] drm/amd/powerplay: fix message of SetHardMinByFreq failed when feature is disabled

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Wang, Kevin(Yang) > Sent: Tuesday, August 13, 2019 10:34 AM > To: dl.srdc_lnx_nv10 > Cc: Wang, Kevin(Yang) ; Huang, Ray > ; Feng, Kenneth ; amd- > g...@lists.freedesktop.org > Subject: [PATCH] drm/amd/powerplay:

RE: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus

OK, I see. That will be fine. Regards, Evan > -Original Message- > From: Gui, Jack > Sent: Monday, August 12, 2019 5:51 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH 2/2] drm/amd/powerplay: add > arcturus_is_dpm_running function for arcturus > > Hi Evan, > >

[PATCH] drm/amd/powerplay: fix message of SetHardMinByFreq failed when feature is disabled

the direct send message to smc to set hard clokc will failed when smc clock dpm feature is disabled. so use function of smu_set_hard_freq_range to replace it. the function will check feature enablement. eg: when uclk (mclk) dpm feature is disabled on navi10 [  300.675901] amdgpu: [powerplay] faile

RE: [PATCH] SWDEV-197284 - drm/amdgpu: Only use the peek function in productor side is not correct

Ok, please ignore this patch. Best wishes Emily Deng >-Original Message- >From: Christian König >Sent: Tuesday, August 13, 2019 1:00 AM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH] SWDEV-197284 - drm/amdgpu: Only use the peek >function in productor side is not

Re: [PATCH] nouveau/hmm: map pages after migration

On 8/10/19 4:13 AM, Christoph Hellwig wrote: On something vaguely related to this patch: You use the NVIF_VMM_PFNMAP_V0_V* defines from nvif/if000c.h, which are a little odd as we only ever set these bits, but they also don't seem to appear to be in values that are directly fed to the hardware.

Re: [PATCH] drm/amdgpu: Add more page fault info printing for GFX10

Hi Yong, that is an intentional differentiation. The values behind the ":" are hardware values from the page faults interrupt vector. All values printed without the ":" are additional things we get from the kernel task information based on the pasid. Please keep that, Christian. Am 12.08.

Re: [PATCH] drm/amdgpu: Add more page fault info printing for GFX10

Hi Christian, I feel with ":" it is better, because without it I found it is not easy to interpret the printing. Moreover, it continues the format of the former part. It looks like this: [  190.686668] amdgpu :03:00.0: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:8 pasid:32771, for pr

Re: [PATCH] drm/amdgpu: Add more page fault info printing for GFX10

Am 12.08.19 um 21:05 schrieb Zhao, Yong: The printing we did for GFX9 was not propogated to GFX10 somehow, so fix it now. Change-Id: Ic0b8381134340b83cd69c3fe186ac7a8a97b1bca Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 33 ++ drivers/gpu/drm/

[PATCH] drm/amdgpu: Add more page fault info printing for GFX10

The printing we did for GFX9 was not propogated to GFX10 somehow, so fix it now. Change-Id: Ic0b8381134340b83cd69c3fe186ac7a8a97b1bca Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 33 ++ drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +++- 2 files cha

Re: [PATCH] SWDEV-197284 - drm/amdgpu: Only use the peek function in productor side is not correct

Am 12.08.19 um 09:42 schrieb Emily Deng: For spsc queue, use peek function would cause error in productor side. As for the last element, when the push job is occurring during pop job, the peek function will not be updated in time, and it will return NULL. So use queue count for double confirmin

Re: [PATCH][drm-next] drm/amd/powerplay: remove redundant duplicated return check

Applied. thanks! Alex On Mon, Aug 5, 2019 at 6:29 AM Colin King wrote: > > From: Colin Ian King > > The check on ret is duplicated in two places, it is redundant code. > Remove it. > > Addresses-Coverity: ("Logically dead code") > Fixes: b94afb61cdae ("drm/amd/powerplay: honor hw limit on fetc

Re: [PATCH] drm/amd/display: Fix a typo - dce_aduio_mask --> dce_audio_mask

Applied. thanks! Alex On Sat, Aug 10, 2019 at 9:55 AM Christophe JAILLET wrote: > > This should be 'dce_audio_mask', not 'dce_aduio_mask'. > > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/amd/display/dc/dce/dce_audio.c | 2 +- > drivers/gpu/drm/amd/display/dc/dce/dce_aud

Re: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus

if any DPM feature is enabled, then DPM is running, return true. if all DPM feature is disabled, the DPM is not running, return false. so the macro of "SMC_DPM_FEATURE" should be include all dpm feature, whether is enabled or supported. i think the @Gui, Jack's patch is r

RE: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus

Hi Evan, All supported feature can be set there, Anyone of these features is running, we can judge dpm is running. BR, Jack Gui -Original Message- From: Quan, Evan Sent: Monday, August 12, 2019 5:39 PM To: Gui, Jack ; amd-gfx@lists.freedesktop.org Cc: Gui, Jack Subject: RE: [PATCH

RE: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus

Please set FEATURE_DPM_PREFETCHER_MASK | FEATURE_DPM_GFXCLK_MASK only. For now, only these two are enabled on arcturus. With that fixed, the patch is reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Chengming Gui > Sent: Monday, August 12, 2019 4:22 PM > To: am

RE: [PATCH 1/2] drm/amd/powerplay: remove redundancy debug log about smu unsupported features

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Chengming Gui > Sent: Monday, August 12, 2019 4:22 PM > To: amd-gfx@lists.freedesktop.org > Cc: Gui, Jack > Subject: [PATCH 1/2] drm/amd/powerplay: remove redundancy debug log > about smu unsupported features >

Re: [PATCH 1/2] drm/amd/powerplay: remove redundancy debug log about smu unsupported features

Reviewed-by: Kevin Wang On 8/12/19 4:22 PM, Chengming Gui wrote: > remove redundancy debug log about smu unsupported features > > Signed-off-by: Chengming Gui > --- > drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/power

Re: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus

Reviewed-by: Kevin Wang On 8/12/19 4:22 PM, Chengming Gui wrote: > add arcturus_is_dpm_running function > > Signed-off-by: Chengming Gui > --- > drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pow

[PATCH 1/2] drm/amd/powerplay: remove redundancy debug log about smu unsupported features

remove redundancy debug log about smu unsupported features Signed-off-by: Chengming Gui --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c index e6fcbdf..

[PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus

add arcturus_is_dpm_running function Signed-off-by: Chengming Gui --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c index 03ce871

[PATCH] SWDEV-197284 - drm/amdgpu: Only use the peek function in productor side is not correct

For spsc queue, use peek function would cause error in productor side. As for the last element, when the push job is occurring during pop job, the peek function will not be updated in time, and it will return NULL. So use queue count for double confirming the job queue is empty. Signed-off-by: E