RE: [PATCH 3/4] drm/amdgpu: cleanup unnecessary virt sriov check in amdgpu attribute

2020-05-18 Thread Zhang, Hawking
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Wang, Kevin(Yang) Sent: Thursday, May 7, 2020 17:57 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Liu, Monk ; Feng, Kenneth ; Wang,

Re: [PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs

2020-05-18 Thread Marek Olšák
Hi Sasha, I disagree with this. Bumping the driver version will have implications on other new features, because it's like an ABI barrier exposing new functionality. Marek On Thu, May 7, 2020 at 10:28 AM Sasha Levin wrote: > From: Marek Olšák > > [ Upstream commit

[PATCH] drm/amdkfd: Fix boolreturn.cocci warnings

2020-05-18 Thread Aishwarya Ramakrishnan
Return statements in functions returning bool should use true/false instead of 1/0. drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c:40:9-10: WARNING: return of 0/1 in function 'event_interrupt_isr_v9' with return type bool Generated by: scripts/coccinelle/misc/boolreturn.cocci Signed-off-by:

Re: [PATCH 3/3] drm/amdgpu: add apu flags

2020-05-18 Thread Alex Deucher
On Mon, May 18, 2020 at 3:31 AM Christian König wrote: > > Am 15.05.20 um 20:31 schrieb Alex Deucher: > > Add some APU flags to simplify handling of different APU > > variants. It's easier to understand the special cases > > if we use names flags rather than checking device ids and > > silicon

Re: XFX RX 5600 XT Raw II graphics card slow

2020-05-18 Thread Alex Deucher
On Sun, May 17, 2020 at 5:25 PM Javad Karabi wrote: > > hmm, actually upon digging deeper, it looks like the latest > linux-firmware doesnt have navi10_mes.bin. > if i understand correctly, the rx 5600 xt is navi10, right? > navi10_mes.bin is one of the firmware files that update-initramfs is >

[PATCH] drm/amdgpu: add condition to set MP1 state on gpu reset

2020-05-18 Thread Likun Gao
From: Likun Gao Only ras supportted need to set MP1 state to prepare for unload before reloading SMU FW. Signed-off-by: Likun Gao Change-Id: I9e49b3f13aa613393381fe15b6b060665026078a --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH] drm/amdgpu fix incorrect sysfs remove behavior for xgmi

2020-05-18 Thread Jack Zhang
Under xgmi setup,some sysfs fail to create for the second time of kmd driver loading. It's due to sysfs nodes are not removed appropriately in the last unlod time. Changes of this patch: 1. remove sysfs for dev_attr_xgmi_error 2. remove sysfs_link adev->dev->kobj with target name. And it only

Re: [PATCH 3/3] drm/amdgpu: add apu flags

2020-05-18 Thread Christian König
Am 15.05.20 um 20:31 schrieb Alex Deucher: Add some APU flags to simplify handling of different APU variants. It's easier to understand the special cases if we use names flags rather than checking device ids and silicon revisions. Wouldn't it be easier and cleaner to add CHIP_RAVEN2 and

Re: [PATCH] drm/amdgpu fix incorrect sysfs remove behavior for xgmi

2020-05-18 Thread Christian König
Am 18.05.20 um 06:44 schrieb Jack Zhang: Under xgmi setup,some sysfs fail to create for the second time of kmd driver loading. It's due to sysfs nodes are not removed appropriately in the last unlod time. Changes of this patch: 1. remove sysfs for dev_attr_xgmi_error 2. remove sysfs_link