On 8/10/2021 6:12 PM, Das, Nirmoy wrote:
On 8/10/2021 11:38 AM, Sahu, Satyajit wrote:
On 8/10/2021 2:01 PM, Das, Nirmoy wrote:
On 8/10/2021 9:09 AM, Satyajit Sahu wrote:
VCN and VCE support multiple queues with different priority.
Use differnt encoder queue based on the priority set by UM
On Tue, Aug 10, 2021 at 11:09 PM Alex Deucher wrote:
>
> On Tue, Aug 10, 2021 at 12:57 AM Koba Ko wrote:
> >
> > On Tue, Aug 10, 2021 at 12:45 PM Mario Limonciello
> > wrote:
> > >
> > >
> > >
> > > On Mon, Aug 9, 2021 at 9:37 AM Alex Deucher wrote:
> > >>
> > >> On Mon, Aug 9, 2021 at 9:59 AM
[AMD Official Use Only]
Just few comments inline. With that acknowledged Reviewed-by: Harish
Kasiviswanathan
-Original Message-
From: amd-gfx On Behalf Of Mukul Joshi
Sent: Monday, August 9, 2021 4:41 PM
To: amd-gfx@lists.freedesktop.org
Cc: Kuehling, Felix ; Cornwall, Jay
; Joshi, Mu
On 8/10/21 12:48 PM, Tom Lendacky wrote:
On 8/10/21 1:45 PM, Kuppuswamy, Sathyanarayanan wrote:
On 7/27/21 3:26 PM, Tom Lendacky wrote:
diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
index de01903c3735..cafed6456d45 100644
--- a/arch/x86/kernel/head64.c
+++ b/arch/x86/ker
On 8/10/21 1:45 PM, Kuppuswamy, Sathyanarayanan wrote:
>
>
> On 7/27/21 3:26 PM, Tom Lendacky wrote:
>> diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
>> index de01903c3735..cafed6456d45 100644
>> --- a/arch/x86/kernel/head64.c
>> +++ b/arch/x86/kernel/head64.c
>> @@ -19,7 +19,7
Series is:
Reviewed-by: Alex Deucher
On Tue, Aug 10, 2021 at 3:15 PM Ryan Taylor wrote:
>
> Attempt od settings restore and disable restore flag on restore fan mode
> failure.
>
> v2: Update fan mode to auto and fan speed to zero (Lijo)
>
> Reviewed-by: Lijo Lazar
> Signed-off-by: Ryan Taylor
Adds missing edge case to smu_restore_dpm_user_profile.
v2: Don't restore fan mode auto (Lijo)
Reviewed-by: Lijo Lazar
Signed-off-by: Ryan Taylor
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/am
Attempt od settings restore and disable restore flag on restore fan mode
failure.
v2: Update fan mode to auto and fan speed to zero (Lijo)
Reviewed-by: Lijo Lazar
Signed-off-by: Ryan Taylor
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
On 7/27/21 3:26 PM, Tom Lendacky wrote:
diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
index de01903c3735..cafed6456d45 100644
--- a/arch/x86/kernel/head64.c
+++ b/arch/x86/kernel/head64.c
@@ -19,7 +19,7 @@
#include
#include
#include
-#include
+#include
#include
From: Randy Dunlap
commit 5706cb3c910cc8283f344bc37a889a8d523a2c6d upstream.
'pm_suspend_target_state' is only available when CONFIG_PM_SLEEP
is set/enabled. OTOH, when both SUSPEND and HIBERNATION are not set,
PM_SLEEP is not set, so this variable cannot be used.
../drivers/gpu/drm/amd/amdgpu/
Reviewed-by: Andrey Grodzovsky
Andrey
On 2021-08-09 11:22 p.m., Jingwen Chen wrote:
From: Jack Zhang
Why: Previously hw fence is alloced separately with job.
It caused historical lifetime issues and corner cases.
The ideal situation is to take fence to manage both job
and fence's lifetime, a
Am 2021-08-10 um 12:43 a.m. schrieb Yifan Zhang:
> KFDSVMRangeTest.SetGetAttributesTest randomly fails in stress test.
>
> Note: Google Test filter = KFDSVMRangeTest.*
> [==] Running 18 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 18 tests from KFDSV
On Tue, Aug 10, 2021 at 12:57 AM Koba Ko wrote:
>
> On Tue, Aug 10, 2021 at 12:45 PM Mario Limonciello wrote:
> >
> >
> >
> > On Mon, Aug 9, 2021 at 9:37 AM Alex Deucher wrote:
> >>
> >> On Mon, Aug 9, 2021 at 9:59 AM Koba Ko wrote:
> >> >
> >> > Previously, AMD had an issue about noise with A
From: Bing Guo
[ Upstream commit 06050a0f01dbac2ca33145ef19a72041206ea983 ]
Why:
In DCN2x, HW doesn't automatically divide MASTER_UPDATE_LOCK_DB_X
by the number of pipes ODM Combined.
How:
Set MASTER_UPDATE_LOCK_DB_X to the value that is adjusted by the
number of pipes ODM Combined.
Reviewed-b
From: Qingqing Zhuo
[ Upstream commit c4152b297d56d3696ad0a9003169bc5b98ad7b72 ]
[Why]
HPD disable and enable sequences are not mutually exclusive
on Linux. For HPDs that spans over 1s (i.e. HPD low = 1s),
part of the disable sequence (specifically, a request to SMU
to lower refclk) could come r
From: Bing Guo
[ Upstream commit 06050a0f01dbac2ca33145ef19a72041206ea983 ]
Why:
In DCN2x, HW doesn't automatically divide MASTER_UPDATE_LOCK_DB_X
by the number of pipes ODM Combined.
How:
Set MASTER_UPDATE_LOCK_DB_X to the value that is adjusted by the
number of pipes ODM Combined.
Reviewed-b
From: Yifan Zhang
[ Upstream commit 1c0539a6fc8a4a4b77278e35d763073890de96b9 ]
If GC has entered CGPG, ringing doorbell > first page doesn't wakeup GC.
Enlarge CP_MEC_DOORBELL_RANGE_UPPER to workaround this issue.
Signed-off-by: Yifan Zhang
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deuche
From: Qingqing Zhuo
[ Upstream commit c4152b297d56d3696ad0a9003169bc5b98ad7b72 ]
[Why]
HPD disable and enable sequences are not mutually exclusive
on Linux. For HPDs that spans over 1s (i.e. HPD low = 1s),
part of the disable sequence (specifically, a request to SMU
to lower refclk) could come r
From: Bing Guo
[ Upstream commit 06050a0f01dbac2ca33145ef19a72041206ea983 ]
Why:
In DCN2x, HW doesn't automatically divide MASTER_UPDATE_LOCK_DB_X
by the number of pipes ODM Combined.
How:
Set MASTER_UPDATE_LOCK_DB_X to the value that is adjusted by the
number of pipes ODM Combined.
Reviewed-b
From: Yifan Zhang
[ Upstream commit 1c0539a6fc8a4a4b77278e35d763073890de96b9 ]
If GC has entered CGPG, ringing doorbell > first page doesn't wakeup GC.
Enlarge CP_MEC_DOORBELL_RANGE_UPPER to workaround this issue.
Signed-off-by: Yifan Zhang
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deuche
On Mon, Aug 9, 2021 at 9:24 PM zhaoxiao wrote:
>
> The variable backlight is being initialized with a value that
> is never read, it is being re-assigned immediately afterwards.
I don't think this comment really matches the code. I think you can drop it.
Alex
> Clean up the code by removing th
Thanks for your feedback. We will prepare a V2 patch according to your advice.
Best wishes,
Tuo Li
On 2021/8/10 21:38, Chen, Guchun wrote:
[Public]
Thanks for your patch.
I suggest moving the check of function pointer dc->clk_mgr->funcs->get_clock
earlier, and return early if it's NULL, as
[Public]
Thanks for your patch.
I suggest moving the check of function pointer dc->clk_mgr->funcs->get_clock
earlier, and return early if it's NULL, as if it's NULL, it's meaningless to
continue the clock setting.
if (!dc->clk_mgr || !dc->clk_mgr->funcs->get_clock)
return DC_FAIL_
Hello,
Our static analysis tool finds some possible null-pointer dereferences
in the amdgpu driver in Linux 5.14.0-rc3:
In dce_v10_0.c:
The variable encoder->crtc is checked in:
1591: if (encoder->crtc)
This indicates that encoder->crtc can be NULL.
Then the function dce_v10_0_audio_set_dt
The variable dc->clk_mgr is checked in:
if (dc->clk_mgr && dc->clk_mgr->funcs->get_clock)
This indicates dc->clk_mgr can be NULL.
However, it is dereferenced in:
if (!dc->clk_mgr->funcs->get_clock)
To fix this possible null-pointer dereference, check dc->clk_mgr before
dereferencing it.
Repo
On 8/10/2021 11:38 AM, Sahu, Satyajit wrote:
On 8/10/2021 2:01 PM, Das, Nirmoy wrote:
On 8/10/2021 9:09 AM, Satyajit Sahu wrote:
VCN and VCE support multiple queues with different priority.
Use differnt encoder queue based on the priority set by UMD.
Signed-off-by: Satyajit Sahu
---
dri
Please ignore the comment. Checked again - num_vcn_inst denotes the
maximum VCN instances and not the actual number of instances.
Thanks,
Lijo
On 8/10/2021 5:34 PM, Lazar, Lijo wrote:
On 8/10/2021 8:33 AM, Alex Deucher wrote:
There may be multiple instances and only one is harvested.
v2: f
On 8/10/2021 8:33 AM, Alex Deucher wrote:
There may be multiple instances and only one is harvested.
v2: fix typo in commit message
Fixes: 83a0b8639185 ("drm/amdgpu: add judgement when add ip blocks (v2)")
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1673
Reviewed-by: James Zhu
Sign
On 8/10/2021 2:01 PM, Das, Nirmoy wrote:
On 8/10/2021 9:09 AM, Satyajit Sahu wrote:
VCN and VCE support multiple queues with different priority.
Use differnt encoder queue based on the priority set by UMD.
Signed-off-by: Satyajit Sahu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 35 +++
On 8/10/2021 9:09 AM, Satyajit Sahu wrote:
VCN and VCE support multiple queues with different priority.
Use differnt encoder queue based on the priority set by UMD.
Signed-off-by: Satyajit Sahu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 35 +--
drivers/gpu/drm/amd/
Hi Andrey,
The latest patch [PATCH v4] drm/amd/amdgpu embed hw_fence into
amdgpu_job has been sent to amd-gfx. can you help review this patch?
Best Regards,
Jingwen
On Tue Aug 10, 2021 at 10:51:17AM +0800, Jingwen Chen wrote:
> On Mon Aug 09, 2021 at 12:24:37PM -0400, Andrey Grodzovsky wrote:
> >
VCN and VCE support multiple queues with different priority.
Use differnt encoder queue based on the priority set by UMD.
Signed-off-by: Satyajit Sahu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 35 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 2 +-
drivers/gpu/drm/am
32 matches
Mail list logo
