On Wed, Feb 23, 2022 at 3:47 PM Paul Menzel wrote:
>
> Dear Qiang,
>
>
> Am 22.02.22 um 03:46 schrieb Qiang Yu:
> > Workstation application ANSA/META v21.1.4 get this error dmesg when
> > running CI test suite provided by ANSA/META:
> > [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO
Dear Qiang,
Am 22.02.22 um 03:46 schrieb Qiang Yu:
Workstation application ANSA/META v21.1.4 get this error dmesg when
running CI test suite provided by ANSA/META:
[drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16)
This is caused by:
1. create a 256MB buffer in invisible VR
Well that's bad. This should not be pushed to amd-staging-drm-next at all.
This patch is touching multiple drivers and therefore needs to go
upstream through drm-misc-next.
Alex can you drop that one before you send out a pull request? I'm going
to cherry-pick it over to drm-misc-next.
Than
Am 23.02.22 um 08:13 schrieb Somalapuram Amaranath:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 82 +
2
[AMD Official Use Only]
Hi Christian,
I noticed that and it has been fixed with the latest patch.
And I pushed it to amd-staging-drm-next already.
Best regards,
Jiawei
-Original Message-
From: Koenig, Christian
Sent: Wednesday, February 23, 2022 3:12 PM
To: kernel test robot ; Gu, Jia
Dump the list of register values to trace event on GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 +
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16
2 files changed, 33 insertions(+)
diff --git a/drivers/gpu/
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 82 +
2 files changed, 86 insertions(+)
diff --git a/drivers/gpu/dr
Hi Jiawei,
can you take a look at this? The kernel build robots screaming that this
breaks the V3D build. Probably just a typo or missing include.
I would rather like to push this sooner than later.
Thanks,
Christian.
Am 21.02.22 um 16:51 schrieb kernel test robot:
Hi Jiawei,
Thank you fo
From: Xiaogang Chen
Signed-off-by: Xiaogang Chen
---
drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c | 3 +++
drivers/gpu/drm/amd/include/asic_reg/hdp/hdp_4_0_sh_mask.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c
b/drivers/gpu/drm/amd
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Lijo Lazar
Sent: Wednesday, February 23, 2022 1:27 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Liang, Prike
; kernel test robot ; Zhang, Hawking
Subject: [PATCH] drm/amd/pm: Fix m
Fix below warning
warning: no previous prototype for '__smu_get_enabled_features'
[-Wmissing-prototypes]
Fixes: 716622108a9f("drm/amd/pm: validate SMU feature enable message for
getting feature enabled mask")
Reported-by: kernel test robot
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/
On Wed, Feb 23, 2022 at 10:42:34AM +0800, Liang, Prike wrote:
> This will enable the following gfx clock gating.
> - Fine clock gating
> - Medium Grain clock gating
> - 3D Coarse clock gating
> - Coarse Grain clock gating
> - RLC/CP light sleep clock gating
>
> Signed-off-by: Prike Liang
Series
Set mode2 reset support for MP1 13.0.8.
Signed-off-by: Prike Liang
---
drivers/gpu/drm/amd/amdgpu/nv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
index 5f375f3430e1..f414b7ca0ab7 100644
--- a/drivers/gpu/drm/amd/amdgpu/nv
This will enable the following gfx clock gating.
- Fine clock gating
- Medium Grain clock gating
- 3D Coarse clock gating
- Coarse Grain clock gating
- RLC/CP light sleep clock gating
Signed-off-by: Prike Liang
---
drivers/gpu/drm/amd/amdgpu/nv.c | 10 +-
1 file changed, 9 insertions(+),
Acked-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, February 23, 2022 12:08 AM
To: amd-gfx@lists.freedesktop.org; bhelg...@google.com;
linux-...@vger.kernel.org
Cc: Deucher, Alexander
Subject: [PATCH] PCI: Apply quirk_amd_h
[AMD Official Use Only]
No that's fine. Just checking.
Alex
From: Chen, Guchun
Sent: Tuesday, February 22, 2022 9:29 PM
To: Alex Deucher
Cc: amd-gfx list ; Deucher, Alexander
; Zhang, Hawking ; Koenig,
Christian ; Pan, Xinhui
Subject: RE: [PATCH] drm/amdgpu
From: Evan Quan
[ Upstream commit 0136f5844b006e2286f873457c3fcba8c45a3735 ]
Correct the UMD pstate profiling clocks for Dimgrey Cavefish and Beige
Goby.
Signed-off-by: Evan Quan
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deucher
Signed-off-by: Sasha Levin
---
.../amd/pm/swsmu/smu11/sie
Hi Alex,
This patch has covered the check of VCN as well. So you want me to modify the
comments to add VCN as well?
Regards,
Guchun
-Original Message-
From: Alex Deucher
Sent: Wednesday, February 23, 2022 1:00 AM
To: Chen, Guchun
Cc: amd-gfx list ; Deucher, Alexander
; Zhang, Hawkin
From: Evan Quan
[ Upstream commit 0136f5844b006e2286f873457c3fcba8c45a3735 ]
Correct the UMD pstate profiling clocks for Dimgrey Cavefish and Beige
Goby.
Signed-off-by: Evan Quan
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deucher
Signed-off-by: Sasha Levin
---
.../amd/pm/swsmu/smu11/sie
This reverts commit b1f0ab445ec609f9b58e0969c5d052b52d9a54e7.
This patch is not valid. The driver needs to actually read the
entries in the ring buffer. Add a comment to make this clear.
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1916
Cc: Maíra Canal
Signed-off-by: Alex Deucher
---
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, February 23, 2022 4:57 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu: fix typo in amdgpu_discovery.c
disocvery -> discovery
S
From: Sung Joon Kim
[why]
DML validation fails when we connect two or
more displays with HDR. Need to increase
DRAM BW to make the validation passing.
Following the value from DCN31.
[how]
Change the max DRAM BW DML field to 60%.
Reviewed-by: Charlene Liu
Acked-by: Qingqing Zhuo
Signed-off-by
From: "Ma, Duncan"
[Why]
Detbuffer size is dynamically set for dcn31x. At certain moment,
compbuf+(def size * num pipes) > config return buffer size causing
flickering. This is easily reproducible when MPO is
enabled with two displays.
[How]
At prepare BW, use the min comp buffer size. When it i
From: Dmytro Laktyushkin
[Why & How]
Due to how pmfw fills out the table when dcfclk states are disabled,
using dcfclk based clk table would cause a no read situation.
Revert the change to prevent underflow until a better solution is coded.
Reviewed-by: Charlene Liu
Acked-by: Qingqing Zhuo
Sig
From: Dmytro Laktyushkin
[WHy & How]
Unbounded requesting is unsupported on pipe split modes
and this change prevents us running into such a situation
with wide modes.
Reviewed-by: Charlene Liu
Acked-by: Qingqing Zhuo
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Harry Wentland
---
drivers
disocvery -> discovery
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 2e0ff1ace6fc..e4fcbb
Am 2022-02-22 um 13:55 schrieb Harish Kasiviswanathan:
Print alloc node, peer node and memory domain when peer map fails. This
is more useful
v2: use dev_err instead of pr_err
use bdf for identify peer gpu
Signed-off-by: Harish Kasiviswanathan
Reviewed-by: Felix Kuehling
---
drive
On Thu, Feb 17, 2022 at 2:06 PM Alex Deucher wrote:
>
> On Thu, Feb 17, 2022 at 2:04 PM Nick Desaulniers
> wrote:
> >
> >
> > Alex,
> > Has AMD been able to set up clang builds, yet?
>
> No. I think some individual teams do, but it's never been integrated
> into our larger CI systems as of yet a
On Tue, Feb 22, 2022 at 1:56 PM Harish Kasiviswanathan
wrote:
>
> Print alloc node, peer node and memory domain when peer map fails. This
> is more useful
>
> v2: use dev_err instead of pr_err
> use bdf for identify peer gpu
>
> Signed-off-by: Harish Kasiviswanathan
Reviewed-by: Alex Deucher
On 08/02/22 3:10 pm, Matthew Auld wrote:
> On 03/02/2022 13:32, Arunpravin wrote:
>> add a test to check the maximum allocation limit
>>
>> Signed-off-by: Arunpravin
>> ---
>> .../gpu/drm/selftests/drm_buddy_selftests.h | 1 +
>> drivers/gpu/drm/selftests/test-drm_buddy.c| 60
Print alloc node, peer node and memory domain when peer map fails. This
is more useful
v2: use dev_err instead of pr_err
use bdf for identify peer gpu
Signed-off-by: Harish Kasiviswanathan
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 11 +--
1 file changed, 9 insertions(+), 2 dele
On 08/02/22 4:05 pm, Matthew Auld wrote:
> On 03/02/2022 13:32, Arunpravin wrote:
>> - move i915 buddy selftests into drm selftests folder
>> - add Makefile and Kconfig support
>> - add sanitycheck testcase
>>
>> Prerequisites
>> - These series of selftests patches are created on top of
>>dr
Am 2022-02-21 um 17:30 schrieb Alex Deucher:
To protect against wraparounds.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 31 ++-
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c
create a pot-sized mm, then allocate one of each possible
order within. This should leave the mm with exactly one
page left. Free the largest block, then whittle down again.
Eventually we will have a fully 50% fragmented mm.
v2(Matthew Auld):
- removed unnecessary test succeeded print
- replac
- add a test to ascertain that the critical functionalities
of the program is working fine
- add a timeout helper function
v2:
- removed unnecessary test succeeded print
- replace list_del()/list_add_tail() with list_move_tail()
Signed-off-by: Arunpravin
Reviewed-by: Matthew Auld
Acked-by
create a pot-sized mm, then allocate one of each possible
order within. This should leave the mm with exactly one
page left.
v2:
- removed unnecessary test succeeded print
- replace list_del()/list_add_tail() with list_move_tail()
Signed-off-by: Arunpravin
Reviewed-by: Matthew Auld
Acked-by
create a mm with one block of each order available, and
try to allocate them all.
v2(Matthew Auld):
- removed unnecessary test succeeded print
- replace list_del()/list_add_tail() with list_move_tail()
Signed-off-by: Arunpravin
Reviewed-by: Matthew Auld
Acked-by: Christian König
---
.../g
add a test to check the maximum allocation limit
v2(Matthew Auld):
- added err = -EINVAL in block NULL check
- removed unnecessary test succeeded print
Signed-off-by: Arunpravin
Reviewed-by: Matthew Auld
Acked-by: Christian König
---
.../gpu/drm/selftests/drm_buddy_selftests.h | 1 +
d
- add a test to check the range allocation
- export get_buddy() function in drm_buddy.c
- export drm_prandom_u32_max_state() in lib/drm_random.c
- include helper functions
- include prime number header file
v2:
- add drm_get_buddy() function description (Matthew Auld)
- removed unnecessary tes
- move i915 buddy selftests into drm selftests folder
- add Makefile and Kconfig support
- add sanitycheck testcase
Prerequisites
- These series of selftests patches are created on top of
drm buddy series
- Enable kselftests for DRM as a module in .config
Signed-off-by: Arunpravin
Acked-by: Ch
Reviewed-by: Andrey Grodzovsky
Andrey
On 2022-02-22 09:37, Somalapuram Amaranath wrote:
Dump the list of register values to trace event on GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 +
drivers/gpu/drm/amd/amdgpu/amdg
On Tue, Feb 22, 2022 at 10:07 AM Guchun Chen wrote:
>
> Due to faulty VBIOS out there, harvest bit setting is not
> consistently correct especially for display IP. So far,
> it's hard to work out a solution on all the legacy Navi1x
> ASICs in a short time, so to avoid regression, limit harvest
> b
On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote:
>
> Turn previously global functions into static functions to avoid
> -Wmissing-prototype warnings, such as:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50:20:
> warning: no previous prototype for function 'to_dal_ir
Applied. Thanks!
On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote:
>
> Include the header with the prototype to silence the following clang
> warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_init.c:127:6:
> warning: no previous prototype for function 'dcn201_hw_sequencer_cons
Applied. Thanks!
On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote:
>
> Remove the variable clamshell_closed from the function
> dcn10_align_pixel_clocks.
>
> This was pointed by clang with the following warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2063:7:
> w
Applied. Thanks!
Alex
On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote:
>
> Remove the unused struct irq_source_info_funcs
> dmub_outbox_irq_info_funcs from the file, which was declared but never
> hooked up.
>
> This was pointed by clang with the following warning:
>
> drivers/gpu/drm/amd/amd
Applied. Thanks!
Alex
On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote:
>
> Remove the vupdate_int_entry definition and utilization to avoid the
> following warning by Clang:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:410:2:
> warning: initializer overrides prio
Applied. Thanks!
Alex
On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote:
>
> Remove dcn316_smu_set_voltage_via_phyclk function, which is not used in the
> codebase.
>
> This was pointed by clang with the following warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_smu.c
Applied. Thanks!
Alex
On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote:
>
> Remove unused temp variable from the dmub_rb_flush_pending function by
> using arithmetic to remove the loop.
>
> The -Wunused-but-set-variable warning was pointed out by Clang with the
> following warning:
>
> drivers
Applied. Thanks!
Alex
On Tue, Feb 22, 2022 at 8:17 AM Maíra Canal wrote:
>
> Remove get_umc_v8_7_channel_index function, which is not used
> in the codebase.
>
> This was pointed by clang with the following warning:
>
> drivers/gpu/drm/amd/amdgpu/umc_v8_7.c:50:24: warning: unused function
> 'ge
On Tue, Feb 22, 2022 at 8:17 AM Maíra Canal wrote:
>
> The variable tmp is not used in the dce_v6_0_hpd_fini and
> dce_v8_0_hpd_fini functions. Therefor, the variable is removed in order to
> avoid the following Clang warnings:
>
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:331:6: warning: variable 'tm
Applied. Thanks!
On Tue, Feb 22, 2022 at 8:17 AM Maíra Canal wrote:
>
> Turn previously global function into a static function to avoid the
> following Clang warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2459:5: warning: no previous prototype
> for function 'amdgpu_ras_block_late_init_def
Am 22.02.22 um 17:08 schrieb Alex Deucher:
There are enough vbios escapes without the proper workaround
that some users still hit this. MS never productized ATS on
windows so OEM platforms that were windows only didn't always
validate ATS.
The advantages of ATS are not worth it compared to the
There are enough vbios escapes without the proper workaround
that some users still hit this. MS never productized ATS on
windows so OEM platforms that were windows only didn't always
validate ATS.
The advantages of ATS are not worth it compared to the potential
instabilities on harvested boards.
Am 2022-02-21 um 17:45 schrieb Alex Deucher:
On Fri, Feb 18, 2022 at 11:25 PM Paul Menzel wrote:
Dear Alex,
Thank you for the patch.
Am 18.02.22 um 21:42 schrieb Alex Deucher:
The driver has a fallback, to make the message informational
s/to/so/?
fixed up locally.
rather than a warning.
On 2/22/2022 9:08 PM, Christian König wrote:
Am 22.02.22 um 16:34 schrieb Somalapuram Amaranath:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amd
Am 22.02.22 um 16:34 schrieb Somalapuram Amaranath:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 83 +
2 fil
Dump the list of register values to trace event on GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 +
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16
2 files changed, 33 insertions(+)
diff --git a/drivers/gpu/
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 83 +
2 files changed, 87 insertions(+)
diff --git a/drivers/gpu/dr
[AMD Official Use Only]
Acked-by: Alex Deucher
From: Chen, Guchun
Sent: Tuesday, February 22, 2022 10:07 AM
To: amd-gfx@lists.freedesktop.org ; Deucher,
Alexander ; Zhang, Hawking ;
Koenig, Christian ; Pan, Xinhui
Cc: Chen, Guchun
Subject: [PATCH] drm/amdgpu:
Due to faulty VBIOS out there, harvest bit setting is not
consistently correct especially for display IP. So far,
it's hard to work out a solution on all the legacy Navi1x
ASICs in a short time, so to avoid regression, limit harvest
bit read on several ASICs. Will revisit later once VBIOS has
corre
[Public]
I think is safer only to set it for IP_VERSION(4, 4, 0): which is Aldebaran.
From: amd-gfx On Behalf Of Deucher,
Alexander
Sent: Tuesday, February 22, 2022 8:55 AM
To: Chen, Xiaogang ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: config HDP_MISC_CNTL.READ_BUFFER_WATE
[AMD Official Use Only]
Hi Alex,
I'm OK w/ this series. Acked.
BRs,
Yifan
-Original Message-
From: Alex Deucher
Sent: Tuesday, February 22, 2022 10:17 PM
To: Wentland, Harry
Cc: Zhang, Yifan ; amd-gfx list
; Li, Sun peng (Leo) ;
Deucher, Alexander ; Liang, Prike
; Yin, Tianci (Ric
[AMD Official Use Only]
This series is
Acked-by: Yifan Zhang
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Tuesday, February 22, 2022 3:54 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 1/2] drm/amdgpu/display: split dmcu and gpuvm handl
Am 22.02.22 um 15:37 schrieb Somalapuram Amaranath:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 81 +
2
Dump the list of register values to trace event on GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 +
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16
2 files changed, 33 insertions(+)
diff --git a/drivers/gpu/
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 81 +
2 files changed, 85 insertions(+)
diff --git a/drivers/gpu/dr
How about this series instead?
https://patchwork.freedesktop.org/series/100519/
Alex
On Tue, Feb 22, 2022 at 8:53 AM Harry Wentland wrote:
>
> On 2022-02-22 01:03, Yifan Zhang wrote:
> > From: "Tianci.Yin"
> >
> > this patch adds GTT domain support for dcn 3.1.5 and 3.1.6
> >
> > Signed-off-by:
Turn previously global functions into static functions to avoid
-Wmissing-prototype warnings, such as:
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50:20:
warning: no previous prototype for function 'to_dal_irq_source_dcn30'
[-Wmissing-prototypes]
enum dc_irq_source to_da
The variable tmp is not used in the dce_v6_0_hpd_fini and
dce_v8_0_hpd_fini functions. Therefor, the variable is removed in order to
avoid the following Clang warnings:
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:331:6: warning: variable 'tmp' set but
not used [-Wunused-but-set-variable]
u32 tmp;
Remove the vupdate_int_entry definition and utilization to avoid the
following warning by Clang:
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:410:2:
warning: initializer overrides prior initialization of this subobject
[-Winitializer-overrides]
vupdate_no_lock_int_ent
Remove get_umc_v8_7_channel_index function, which is not used
in the codebase.
This was pointed by clang with the following warning:
drivers/gpu/drm/amd/amdgpu/umc_v8_7.c:50:24: warning: unused function
'get_umc_v8_7_channel_index' [-Wunused-function]
static inline uint32_t get_umc_v8_7_channel_i
Turn previously global function into a static function to avoid the
following Clang warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2459:5: warning: no previous prototype
for function 'amdgpu_ras_block_late_init_default' [-Wmissing-prototypes]
int amdgpu_ras_block_late_init_default(struct amdgpu_
This patchset intends to deal with a couple of warnings in the AMD graphic
drivers. All warnings were generated with Clang and W=1 flag.
Maíra Canal (10):
drm/amdgpu: Change amdgpu_ras_block_late_init_default function scope
drm/amdgpu: Remove tmp unused variable
drm/amdgpu: Remove unused get
Remove the variable clamshell_closed from the function
dcn10_align_pixel_clocks.
This was pointed by clang with the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2063:7:
warning: variable 'clamshell_closed' set but not used
[-Wunused-but-set-variable]
Remove unused temp variable from the dmub_rb_flush_pending function by
using arithmetic to remove the loop.
The -Wunused-but-set-variable warning was pointed out by Clang with the
following warning:
drivers/gpu/drm/amd/amdgpu/../display/dmub/inc/dmub_cmd.h:2921:12: warning:
variable 'temp' set bu
Remove dcn316_smu_set_voltage_via_phyclk function, which is not used in the
codebase.
This was pointed by clang with the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_smu.c:171:5:
warning: no previous prototype for function
'dcn316_smu_set_voltage_via_phyclk' [
Include the header with the prototype to silence the following clang
warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_init.c:127:6:
warning: no previous prototype for function 'dcn201_hw_sequencer_construct'
[-Wmissing-prototypes]
void dcn201_hw_sequencer_construct(struct dc *dc
Remove the unused struct irq_source_info_funcs
dmub_outbox_irq_info_funcs from the file, which was declared but never
hooked up.
This was pointed by clang with the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn201/irq_service_dcn201.c:141:43:
warning: unused variable 'dmub_ou
[Public]
Please be sure to test this on other asics which use the HDP 4.0 code. I don't
think this field exists for all of them.
Alex
From: amd-gfx on behalf of
Xiaogang.Chen
Sent: Monday, February 21, 2022 6:05 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chen
On 2022-02-22 01:03, Yifan Zhang wrote:
> From: "Tianci.Yin"
>
> this patch adds GTT domain support for dcn 3.1.5 and 3.1.6
>
> Signed-off-by: Tianci.Yin
> Signed-off-by: Yifan Zhang
Acked-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 ++
> 1 file change
Am 21.02.22 um 17:45 schrieb Arunpravin:
Move shared vram inline functions and structs
into a header file
Signed-off-by: Arunpravin
Patches #1-#3 haven been pushed to drm-misc-next.
For this one it might be better to squash that into commit #5 as well
since this is otherwise unused.
Might
Am 21.02.22 um 17:45 schrieb Arunpravin:
- Remove drm_mm references and replace with drm buddy functionalities
- Add res cursor support for drm buddy
v2(Matthew Auld):
- replace spinlock with mutex as we call kmem_cache_zalloc
(..., GFP_KERNEL) in drm_buddy_alloc() function
- lock dr
Am 21.02.22 um 23:30 schrieb Alex Deucher:
Simplifies the code quite a bit.
Signed-off-by: Alex Deucher
Reviewed-by: Christian König for the series.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 78 ---
1 file changed, 17 insertions(+), 61 deletions(-)
diff --git
Am 22.02.22 um 10:07 schrieb Michel Dänzer:
On 2022-02-21 22:35, Alex Deucher wrote:
On Mon, Feb 21, 2022 at 12:44 PM Michel Dänzer
wrote:
On 2022-02-18 23:26, Alex Deucher wrote:
This was always duplicate functionality with the benchmark tests.
Not really. The purpose of amdgpu_do_test_m
Dear yipechai,
Am 22.02.22 um 09:39 schrieb Zhou1, Tao:
[AMD Official Use Only]
With my inline concerns addressed, the patch is:
Reviewed-by: Tao Zhou
-Original Message-
From: Chai, Thomas
Can you please configure the full name too for the From: header field,
and Signed-off-by
Add device pointer so scheduler's printing can use
DRM_DEV_ERROR() instead, which makes life easier under multiple GPU
scenario.
v2: amend all calls of drm_sched_init()
v3: fill dev pointer for all drm_sched_init() calls
Signed-off-by: Jiawei Gu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c |
Am 22.02.22 um 10:35 schrieb Somalapuram Amaranath:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 92 +
2 fil
Dump the list of register values to trace event on GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16
2 files changed, 32 insertions(+)
diff --git a/drivers/gpu/d
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 92 +
2 files changed, 96 insertions(+)
diff --git a/drivers/gpu/dr
On 2022-02-21 22:35, Alex Deucher wrote:
> On Mon, Feb 21, 2022 at 12:44 PM Michel Dänzer
> wrote:
>>
>> On 2022-02-18 23:26, Alex Deucher wrote:
>>> This was always duplicate functionality with the benchmark tests.
>>
>> Not really. The purpose of amdgpu_do_test_moves is testing that copies
>> b
[AMD Official Use Only]
Reviewed-by: Huang Rui
-Original Message-
From: Zhang, Yifan
Sent: Tuesday, February 22, 2022 4:26 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Huang, Ray
; Zhang, Yifan
Subject: [PATCH] drm/amdgpu: add mode2 reset support for smu 13.0.5
This
When CONFIG_PPC64 is set and CONFIG_ALTIVEC is not the following build
failures occur:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c: In function
'dc_fpu_begin':
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:61:17: error:
>> implicit declaration of function 'enable_ke
[AMD Official Use Only]
With my inline concerns addressed, the patch is:
Reviewed-by: Tao Zhou
> -Original Message-
> From: Chai, Thomas
> Sent: Tuesday, February 22, 2022 3:07 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Chai, Thomas ; Zhang, Hawking
> ; Zhou1, Tao ; Clements,
> John
This patch adds mode2 reset support for smu 13.0.5.
Signed-off-by: Yifan Zhang
---
drivers/gpu/drm/amd/amdgpu/nv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
index 74e0550d00bd..80caf73bc2ce 100644
--- a/drivers/gpu/drm/a
95 matches
Mail list logo
