Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/ --- (Updated July 22, 2014, 3:22 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/#review12774 --- Ship it! /trunk/main/bridge_channel.c

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/ --- (Updated July 18, 2014, 4:51 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

> On July 16, 2014, 8:23 p.m., rmudgett wrote: > > /trunk/main/bridge_channel.c, lines 875-876 > > > > > > I think you want strlen(app_args) + 1 instead of sizeof(app_args) which > > returns the size of a pointer.

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/#review12701 --- /trunk/main/bridge_channel.c

[asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22608 https://i