[ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-27 Thread Oleksij Rempel
Collect statistics about recived duplicate and STBC packets. This information should help see if STBC is actually working. Tested on ar9285; Signed-off-by: Oleksij Rempel --- drivers/net/wireless/ath/ath9k/debug.c | 20 +++- drivers/net/wireless/ath/ath9k/debug.h | 4 driv

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Felix Fietkau
On 2013-04-27 5:25 PM, Oleksij Rempel wrote: > Collect statistics about recived duplicate and STBC packets. > This information should help see if STBC is actually working. > > Tested on ar9285; > > Signed-off-by: Oleksij Rempel I thought about this patch some more, and I'm wondering what's the p

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Oleksij Rempel
Am 28.04.2013 14:51, schrieb Felix Fietkau: > On 2013-04-27 5:25 PM, Oleksij Rempel wrote: >> Collect statistics about recived duplicate and STBC packets. >> This information should help see if STBC is actually working. >> >> Tested on ar9285; >> >> Signed-off-by: Oleksij Rempel > I thought about

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Ben Greear
On 04/28/2013 05:51 AM, Felix Fietkau wrote: > On 2013-04-27 5:25 PM, Oleksij Rempel wrote: >> Collect statistics about recived duplicate and STBC packets. >> This information should help see if STBC is actually working. >> >> Tested on ar9285; >> >> Signed-off-by: Oleksij Rempel > I thought about

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Oleksij Rempel
Am 28.04.2013 16:13, schrieb Oleksij Rempel: > Am 28.04.2013 14:51, schrieb Felix Fietkau: >> On 2013-04-27 5:25 PM, Oleksij Rempel wrote: >>> Collect statistics about recived duplicate and STBC packets. >>> This information should help see if STBC is actually working. >>> >>> Tested on ar9285; >>>

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Felix Fietkau
On 2013-04-28 4:54 PM, Ben Greear wrote: > On 04/28/2013 05:51 AM, Felix Fietkau wrote: >> On 2013-04-27 5:25 PM, Oleksij Rempel wrote: >>> Collect statistics about recived duplicate and STBC packets. >>> This information should help see if STBC is actually working. >>> >>> Tested on ar9285; >>> >>

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Ben Greear
On 04/28/2013 08:08 AM, Felix Fietkau wrote: > On 2013-04-28 4:54 PM, Ben Greear wrote: >> On 04/28/2013 05:51 AM, Felix Fietkau wrote: >>> On 2013-04-27 5:25 PM, Oleksij Rempel wrote: Collect statistics about recived duplicate and STBC packets. This information should help see if STBC is

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Felix Fietkau
On 2013-04-28 5:15 PM, Ben Greear wrote: > On 04/28/2013 08:08 AM, Felix Fietkau wrote: >> On 2013-04-28 4:54 PM, Ben Greear wrote: >>> On 04/28/2013 05:51 AM, Felix Fietkau wrote: On 2013-04-27 5:25 PM, Oleksij Rempel wrote: > Collect statistics about recived duplicate and STBC packets. >

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Oleksij Rempel
Am 28.04.2013 17:03, schrieb Oleksij Rempel: > Am 28.04.2013 16:13, schrieb Oleksij Rempel: >> Am 28.04.2013 14:51, schrieb Felix Fietkau: >>> On 2013-04-27 5:25 PM, Oleksij Rempel wrote: Collect statistics about recived duplicate and STBC packets. This information should help see if STBC

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Felix Fietkau
On 2013-04-28 9:19 PM, Oleksij Rempel wrote: > Am 28.04.2013 17:03, schrieb Oleksij Rempel: >> Am 28.04.2013 16:13, schrieb Oleksij Rempel: >>> Am 28.04.2013 14:51, schrieb Felix Fietkau: On 2013-04-27 5:25 PM, Oleksij Rempel wrote: > Collect statistics about recived duplicate and STBC pac

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-28 Thread Wojciech Dubowik
On 04/28/2013 05:03 PM, Oleksij Rempel wrote: > Am 28.04.2013 16:13, schrieb Oleksij Rempel: >> Am 28.04.2013 14:51, schrieb Felix Fietkau: >>> On 2013-04-27 5:25 PM, Oleksij Rempel wrote: Collect statistics about recived duplicate and STBC packets. This information should help see if STB

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-04-29 Thread Oleksij Rempel
Am 29.04.2013 08:45, schrieb Wojciech Dubowik: > On 04/28/2013 05:03 PM, Oleksij Rempel wrote: >> Am 28.04.2013 16:13, schrieb Oleksij Rempel: >>> Am 28.04.2013 14:51, schrieb Felix Fietkau: On 2013-04-27 5:25 PM, Oleksij Rempel wrote: > Collect statistics about recived duplicate and STBC

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-05-07 Thread Sujith Manoharan
Felix Fietkau wrote: > The problem I have with the current stats is they're just an arbitrary > collection of random stuff that is probably useless for 99% of all > users. In many cases the way the stats are collected also makes the data > completely meaningless (e.g. because the source/destination

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-05-08 Thread Ben Greear
On 05/07/2013 10:32 PM, Sujith Manoharan wrote: > Felix Fietkau wrote: >> The problem I have with the current stats is they're just an arbitrary >> collection of random stuff that is probably useless for 99% of all >> users. In many cases the way the stats are collected also makes the data >> compl

Re: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets

2013-05-08 Thread Adrian Chadd
On 8 May 2013 09:07, Ben Greear wrote: > I think it's good to keep global counters too..otherwise it is going to be > a lot of work to gather per NIC stats, and since you would have to read for > each > station, your stats might not be quite as atomic as they used to be. > > But, I'm fine with ad