Re: RIPng advertisement hop count 1 (should be 255 per RFC)

2013-06-24 Thread Ondrej Zajicek
On Thu, Jun 20, 2013 at 12:32:18PM -0700, Simon Dickhoven wrote: > Alright. After a lot of digging I got a working RIPng hopcount check. > See attached patch file. Thanks for the patch and the thorough description. ... > 2.1.1) In order to actually receive this additional information I had to

Re: RIPng advertisement hop count 1 (should be 255 per RFC)

2013-06-20 Thread Simon Dickhoven
Alright. After a lot of digging I got a working RIPng hopcount check. See attached patch file. Here's what I did: 1) In order to reduce any deleterious effects of my subsequent modifications I first introduced a new socket flag in lib/socket.h. #define SKF_HLIM_RX 8 /* Report Hop

Re: RIPng advertisement hop count 1 (should be 255 per RFC)

2013-06-18 Thread Simon Dickhoven
Correction: The RFC does state explicitly that advertisements must be sent with an HLIM of 255, as well as that receiving routers must check that the HLIM is 255. So I guess my little patch makes BIRD half-compliant in that respect then :). - Simon On Jun 18, 2013, at 17:38, "Simon Dickhoven"

Re: RIPng advertisement hop count 1 (should be 255 per RFC)

2013-06-18 Thread Simon Dickhoven
Hi, again If you were paying attention (unlike myself) you may have noticed that the below fix doesn't actually make BIRD RFC-compliant. Rather, it makes BIRD interoperate with other RFC-compliant RIPng routers. After all, the RFC doesn't state that route advertisements must be sent with an

Re: RIPng advertisement hop count 1 (should be 255 per RFC)

2013-06-18 Thread Ondrej Zajicek
On Fri, Jun 14, 2013 at 05:41:10PM -0700, Simon Dickhoven wrote: > OK. I looked at proto/rip/rip.c a bit more and figured that I might as > well give it a shot and hack around a little bit. I ended up making this > tiny mod: Hello Thanks for the bugreport and patch. As i understand RFC 2080,

Re: RIPng advertisement hop count 1 (should be 255 per RFC)

2013-06-14 Thread Simon Dickhoven
OK. I looked at proto/rip/rip.c a bit more and figured that I might as well give it a shot and hack around a little bit. I ended up making this tiny mod: --- a/proto/rip/rip.c +++ b/proto/rip/rip.c @@ -706,7 +706,11 @@ rif->sock->dport = P_CF->port; if (new) { +#ifndef IPV6 ri