[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111#comment-17111
]
gclark commented on BIT-1215:
-
Why a static array with local code to resize instead of using someth
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110#comment-17110
]
Justin Azoff commented on BIT-1215:
---
Ah, that was simple. I thought getline was a GNU thing,
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109#comment-17109
]
Daniel Thayer commented on BIT-1215:
I've removed the hard-coded line length limit (now we'
On Thu, Jul 10, 2014 at 17:27 -0500, you wrote:
> I think start with 1M and realloc 2x as needed is the way to go after
> all.
Yes. Maybe a bit less than 2x, exponential grows quickly. :)
> I think the only thing to do would be to add an absolute max line
> length of 64M or something to handl
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108#comment-17108
]
Robin Sommer commented on BIT-1215:
---
Yes. Maybe a bit less than 2x, exponential grows qu
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106#comment-17106
]
Adam Slagell commented on BIT-1215:
---
We are going to make it configurable and default to like
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107#comment-17107
]
Justin Azoff commented on BIT-1215:
---
I think start with 1M and realloc 2x as needed is the wa
We are going to make it configurable and default to like a 1000KB line.
Otherwise, you add a check to see if you need to reallocate memory for every
line processed, which seems inefficient for edge cases. Letting the user
override the default is a good compromise though.
> On Jul 10, 2014, at
I haven't looked at the code yet but if there's hard line length
limit in there, that's a problem. bro-cut shouldn't care how long
lines are.
___
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105#comment-17105
]
Robin Sommer commented on BIT-1215:
---
I haven't looked at the code yet but if there's hard lin
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104#comment-17104
]
Justin Azoff commented on BIT-1215:
---
so, the MAX_LINE_LEN needs a closer look.
I did a quick
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Thayer updated BIT-1215:
---
Status: Merge Request (was: Open)
> bro-cut should be rewritten in C for speed and to not depend on
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102#comment-17102
]
Daniel Thayer commented on BIT-1215:
Branch topic/dnthayer/ticket1215 in bro and bro-aux re
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Thayer updated BIT-1215:
---
Component/s: Bro
> bro-cut should be rewritten in C for speed and to not depend on gawk
> ---
Daniel Thayer created BIT-1215:
--
Summary: bro-cut should be rewritten in C for speed and to not
depend on gawk
Key: BIT-1215
URL: https://bro-tracker.atlassian.net/browse/BIT-1215
Project: Bro Issue Trac
15 matches
Mail list logo
