bug#6131: [PATCH]: fiemap support for efficient sparse file copy

2010-06-09 Thread jeff.liu
Jim Meyering wrote: > jeff.liu wrote: > >> Jim Meyering wrote: >>> Jim Meyering wrote: Subject: [PATCH 01/10] cp: Add FIEMAP support for efficient sparse file copy >>> FYI, using those patches, I ran a test for the first time in a few days: >>> >>> check -C tests TESTS=cp/sparse-fie

bug#6383: [PATCH] cat: improve documentation

2010-06-09 Thread Chas. Owens
That would work as well. I suggested removing the "all" because it was the simplest solution and would move the text closer to what BSD uses, but this spells out the behavior explicitly. On Wed, Jun 9, 2010 at 13:17, Eric Blake wrote: > * src/cat.c (usage): Clarify that -b overrides -n. > * doc/

bug#6366: join can't join on numeric fields

2010-06-09 Thread Paul Eggert
On 06/08/2010 11:56 PM, Jim Meyering wrote: > There may be a fly in the ointment. > > When comparing floating point numbers how would join measure equality? The point is that "join" should be compatible with "sort". Any option that "sort" has to compare fields, is an option that "join" should al

bug#6383: [PATCH] cat: improve documentation

2010-06-09 Thread Eric Blake
* src/cat.c (usage): Clarify that -b overrides -n. * doc/coreutils.texi (cat invocation): Likewise. * THANKS: Update. Suggested by Chas. Owens, in bug 6383. --- > The -n option is documented as "number all output lines", but when -b > is present it only numbers non-blank lines. The documentation

bug#6383: cat has misleading documentation

2010-06-09 Thread Chas. Owens
The -n option is documented as "number all output lines", but when -b is present it only numbers non-blank lines. The documentation should read "number output lines". -- Chas. Owens wonkden.net The most important skill a programmer can have is the ability to read.

bug#6131: [PATCH]: fiemap support for efficient sparse file copy

2010-06-09 Thread Jim Meyering
jeff.liu wrote: > Jim Meyering wrote: >> Jim Meyering wrote: >>> Subject: [PATCH 01/10] cp: Add FIEMAP support for efficient sparse file copy >> >> FYI, using those patches, I ran a test for the first time in a few days: >> >> check -C tests TESTS=cp/sparse-fiemap VERBOSE=yes >> >> It failed l

bug#6131: [PATCH]: fiemap support for efficient sparse file copy

2010-06-09 Thread jeff.liu
Jim Meyering wrote: > Jim Meyering wrote: >> Subject: [PATCH 01/10] cp: Add FIEMAP support for efficient sparse file copy > > FYI, using those patches, I ran a test for the first time in a few days: > > check -C tests TESTS=cp/sparse-fiemap VERBOSE=yes > > It failed like this on an ext4 part

bug#6131: [PATCH]: fiemap support for efficient sparse file copy

2010-06-09 Thread jeff.liu
Jim Meyering wrote: > Paul Eggert wrote: >> Jeff Liu and Jim Meyering wrote: >>> diff --git a/src/fiemap.h b/src/fiemap.h >>> new file mode 100644 >>> index 000..d33293b >>> --- /dev/null >>> +++ b/src/fiemap.h > > Hi Paul, > > Thanks for the review. > >> Why is this file necessary? fiemap.

bug#6366: join can't join on numeric fields

2010-06-09 Thread Alex Shinn
On Wed, Jun 9, 2010 at 3:56 PM, Jim Meyering wrote: > > When comparing floating point numbers how would join measure equality? > Should it consider 1.001e2 to be equal to 100.0 ? > What if the maximum precision available does not > allow us to distinguish those two values? Indeed, tha

bug#6381: [PATCH] Add digit grouping option for file sizes in "ls"

2010-06-09 Thread Jim Meyering
Sam Bobroff wrote: > Please excuse me if I'm not going about this the right way but I would > like to offer a tiny patch for "ls" that adds an option to turn on digit > grouping for file sizes in the long output format. > > (The support for displaying digit grouping is already present, all that > i

bug#6131: [PATCH]: fiemap support for efficient sparse file copy

2010-06-09 Thread jeff.liu
Jim Meyering wrote: > Paul Eggert wrote: >> Jeff Liu and Jim Meyering wrote: >>> diff --git a/src/fiemap.h b/src/fiemap.h >>> new file mode 100644 >>> index 000..d33293b >>> --- /dev/null >>> +++ b/src/fiemap.h > > Hi Paul, > > Thanks for the review. > >> Why is this file necessary? fiemap.

bug#6381: [PATCH] Add digit grouping option for file sizes in "ls"

2010-06-09 Thread Sam Bobroff
Hello, Please excuse me if I'm not going about this the right way but I would like to offer a tiny patch for "ls" that adds an option to turn on digit grouping for file sizes in the long output format. (The support for displaying digit grouping is already present, all that is required is an optio

bug#6131: [PATCH]: fiemap support for efficient sparse file copy

2010-06-09 Thread Jim Meyering
Paul Eggert wrote: > Jeff Liu and Jim Meyering wrote: >> diff --git a/src/fiemap.h b/src/fiemap.h >> new file mode 100644 >> index 000..d33293b >> --- /dev/null >> +++ b/src/fiemap.h Hi Paul, Thanks for the review. > Why is this file necessary? fiemap.h is included only if it exists, > righ

bug#6366: join can't join on numeric fields

2010-06-09 Thread Jim Meyering
Alex Shinn wrote: > 2010/6/8 Pádraig Brady : >> On 07/06/10 06:19, Alex Shinn wrote: >>> >>> Ideally join should be able to handle files sorted in any order >>> that sort provides, but as a bare minimum it should at least >>> be able to join files sorted on numeric fields. >> >> Well if there were