Gary V. Vaughan wrote:
> Okay to push?
>
> * top/maint.mk (tight-scope.mk): Make sure to prefix file
> reference with $(srcdir) so that the file is found correctly even
> when running `make syntax-check' in a VPATH build.
...
> tight-scope.mk: $(ME)
> @rm -f $@ $@-t
> - @perl -ne '/^# TS
Gary V. Vaughan wrote:
> Hi Jim,
>
> On 15 Nov 2011, at 19:02, Jim Meyering wrote:
>> Gary V. Vaughan wrote:
>>> On 15 Nov 2011, at 18:14, Jim Meyering wrote:
>>>> Gary V. Vaughan wrote:
>>>>> I think 'Copyright-paper-required: No' is
Gary V. Vaughan wrote:
> Hi Jim,
>
> On 15 Nov 2011, at 18:14, Jim Meyering wrote:
>> Gary V. Vaughan wrote:
>>> I think 'Copyright-paper-required: No' is still the best compromise here for
...
>> This is setting FSF policy,
>
> Well, the polic
Gary V. Vaughan wrote:
> I think 'Copyright-paper-required: No' is still the best compromise here for
> the reasons stated earlier in the thread.
>
> Okay to push?
>
> The FSF require that all non-trivial patches to its projects be
> accompanied by appropriate paperwork, or that any patches that ar
ently the
> parts of init.sh that are parsed by the initial shell (I tried /bin/sh
> and /bin/ksh) extend beyond the point of execution; possibly it includes
> the entire init.sh file.
>
> I could have written
>
>diff_out_="$( ( diff -u "$0" "$0" < /dev/n
Bruno Haible wrote:
> The Solaris 'diff' program understands option '-u', the AIX and HP-UX 'diff'
> programs don't. So here's a proposed patch. It removes the spurious output
> on all 3 platforms.
>
> 2011-11-12 Bruno Haible
>
> Silence successful tests that use 'compare' on AIX, HP-UX, S
Eric Blake wrote:
> On 11/12/2011 11:53 AM, Simon Josefsson wrote:
>> For inetutils (which uses git tags looking like 'inetutils-1_8') we
>> noticed that git-version-gen hardcodes an expression when searching for
>> particular tags:
>>
>> && v=`git describe --abbrev=4 --match='v*' HEAD 2>/dev/n
Jim Meyering wrote:
> That fix was not enough, and even had a typo.
> With these further changes, I've now confirmed that those two
> tests are indeed skipped on Solaris 10, which also lacks those
> definitions.
>
...
>>From e500079a186434daeba99a1ea115690715fd56eb Mon S
Dagobert Michelsen wrote:
> Hi Jim,
>
> Am 11.11.2011 um 14:42 schrieb Jim Meyering:
>> Thanks for investigating.
>> I've pushed the following fix to gnulib;
>> I'll update grep to use it before the release.
>
> Excellent! Please let me know if you have
64afe06058a88dd81020fa3d548a07c82c8e33e Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sat, 12 Nov 2011 13:32:30 +0100
Subject: [PATCH] build: update gnulib for fstatat cross-compile improvement
---
gnulib |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gnulib b/gnulib
Bruno Haible wrote:
> While testing a 'grep' prerelease on MSVC 9, I got this error:
>
> obstack.c
> obstack.c(406) : error C2381: 'print_and_abort': redefinition;
> __declspec(noreturn) differs from
> obstack.c(90): see declaration of 'print_and_abort'
> make[4]: *** [obstack.obj] Error
Dagobert Michelsen wrote:
> Hi Jim,
>
> Am 10.11.2011 um 18:09 schrieb Jim Meyering:
>> Dagobert Michelsen wrote:
>>> I still get failing tests similar to the ones I reported in
>>> https://savannah.gnu.org/bugs/?29380
>>> There doesn't seem t
Bruno Haible wrote:
> Hi Jim, all,
>
>> >> I suggest using @tie{} between os (or program or ...) names and
>> >> versions. That way the line breaks come out ok in both the source and
>> >> the output.
>> >
>> > Indeed, the result looks better (at least in HTML). I tested
>> ...
>> I find that the
lists both the ftp.gnu.org
and ftpmirror.gnu.org addresses automatically, rather than displaying
the less-useful http://www.gnu.org/order/ftp.html link.
>From d5af3423d6dc7bc0356c9ff393db6e97305b07bd Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 9 Nov 2011 22:32:54 +0100
Subject: [PA
Paul Eggert wrote:
> On 11/09/11 11:47, Jim Meyering wrote:
>> I'm sure Karl will
>> do something about this pretty quickly:
>>
>> http://thread.gmane.org/gmane.comp.tex.texinfo.bugs/544
>
> That URL is missing a digit; it should be:
>
> http://a
FYI, texi2dvi was failing with no diagnostic for me,
when using the latest texinfo.tex. I'm sure Karl will
do something about this pretty quickly:
http://thread.gmane.org/gmane.comp.tex.texinfo.bugs/544
Bruno Haible wrote:
>> * modules/fstatat: New file, extracted from modules/openat.
>
> Oops, there was a small mistake here: fstatat() does not call fstat().
>
>
> 2011-11-08 Bruno Haible
>
> fstatat: Remove unused dependency.
> * modules/fstatat (Depends-on): Remove fstat.
>
Bruno Haible wrote:
> mkfifoat() and mknodat() are declared in , not .
> Therefore this fix:
>
>
> 2011-11-08 Bruno Haible
>
> mkfifoat: Fix module description.
> * modules/mkfifoat (configure.ac): Invoke gl_SYS_STAT_MODULE_INDICATOR,
> not gl_UNISTD_MODULE_INDICATOR.
>
> --- m
Bruno Haible wrote:
> lib/renameat.c uses , therefore the module needs this dependency:
>
>
> 2011-11-08 Bruno Haible
>
> renameat: Fix dependencies.
> * modules/renameat (Depends-on): Add stdbool.
>
> --- modules/renameat.orig Wed Nov 9 01:53:58 2011
> +++ modules/renameat Tue
Bruno Haible wrote:
> The autoconf macro in faccessat.m4 does not need to AC_REQUIRE macros
> that are pulled in through the module dependencies anyway.
>
>
> 2011-11-08 Bruno Haible
>
> faccessat: Simplify autoconf macro.
> * m4/faccessat.m4 (gl_FUNC_FACCESSAT): Don't require gl_FUN
Bruno Haible wrote:
> Now that 'openat' is cleaned up, it is easy to make the 'faccessat' module
> follow the codins style / idioms from May 2011.
>
>
> 2011-11-08 Bruno Haible
>
> faccessat: Move AC_LIBOBJ invocation to module description.
> * m4/faccessat.m4 (gl_PREREQ_FACCESSAT):
Bruno Haible wrote:
> Jim Meyering wrote:
>> >> 2011-11-05 Bruno Haible
>> >>
>> >> openat: Conditionalize dependencies.
>> ...
>> This change looks fine.
>
> OK, I've applied it. Now, as the last patch of the series, I'm a
Bruno Haible wrote:
> Hi Karl, all,
>
>> > +MacOS X 10.5, FreeBSD 6.0, NetBSD 5.0, OpenBSD 3.8, Minix 3.1.8, AIX
>>
>> Could you please break the line after a comma?
>>
>> I suggest using @tie{} between os (or program or ...) names and
>> versions. That way the line breaks come out ok in
Simon Josefsson wrote:
> I upgraded gnulib in GnuTLS and noticed this problem in a clean
> checkout:
>
> jas@latte:~/src/gnutls master$ make syntax-check
> No version control files detected; skipping syntax check
> jas@latte:~/src/gnutls master$
>
> The reason was that _build-aux was not set when t
Bruno Haible wrote:
> Jim, ping?
>
>> Hi Jim,
>>
>> Now that the module structure of the *at functions is cleaned up - one
>> function provided per module (except for mkfifoat and mknodat which can
>> stay in a single module because they are nearly the same thing) -, let
>> me try to improve what's
FYI, here's a small improvement to the release process:
>From 103bb35a244bc08ec657bac05a0a1d429d651f45 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 8 Nov 2011 10:44:54 +0100
Subject: [PATCH] maint.mk: extract GPG key ID without using a temporary file
* top/maint.mk (gp
FYI,
Here's a probably-incomplete list of regexps for dirent.h.
But completeness is not that important: the cost of incompleteness
is merely the lack of warning about an unnecessary inclusion.
>From bc1c14f003edbadde570d0322433b6b961205340 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date
Haible
>
> New modules 'at-internal', 'openat-h', split off from module 'openat'.
...
> == modules/openat-h
> ===
> Description:
> Declarations of functions related to accessing files relative to a directory.
>
> Files:
Bruno Haible wrote:
> Paul Eggert wrote:
>> openat_needs_fchdir -- which is a function that
>> openat.c must implement.
>
> If that was the only use of 'bool' in openat.c, I would not have done the
> change. But it's also used in line 193.
>
>> In general in my experience it's OK for foo.c to assum
Bruno Haible wrote:
> The module 'openat' is still a mix of two different functionalities:
> - It provides the POSIX function openat(),
> - It compiles the openat_proc_name() function on which the implementations
> of fdopendir(), faccessat(), fchmodat(), fchownat(), fstatat(), mkdirat(),
>
Bruno Haible wrote:
> This patch is tested on a dozen of platforms as well, like the other ones.
>
> Here's a proposed fixup for some small omissions in the module descriptions.
> - fchmodat, fchownat, linkat, renameat use lib/at-func.c or lib/at-func2.c
> which requires openat_save_fail from
FYI,
>From 6a72f73905064a64091d16fd0787b96a012b4794 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Fri, 4 Nov 2011 13:33:54 +0100
Subject: [PATCH] at-func*.c: fix comments
* lib/at-func2.c: Correct/improve first-line comment.
* lib/at-func.c: Correct grammar in first-line comm
Bruno Haible wrote:
> This proposed patch splits off module mkdirat from module openat.
>
> 2011-11-04 Bruno Haible
>
> New module 'mkdirat', split off from module 'openat'.
> * m4/mkdirat.m4: New file. extracted from m4/openat.m4.
> * m4/openat.m4 (gl_FUNC_OPENAT): Don't requi
Bruno Haible wrote:
> The next split-off is 'fstatat'. Here's the proposed patch. Tested on several
> platforms.
>
> 2011-11-03 Bruno Haible
>
> New module 'fstatat', split off from module 'openat'.
> * lib/openat.h (statat, lstatat): Enable only if GNULIB_FSTATAT is
> defined.
foat-tests (Depends-on): Likewise.
> * modules/readlinkat-tests (Depends-on): Likewise.
...
> === modules/unlinkat
> ===
...
> Maintainer:
> Jim Meyering, Eric Blake
...
> --- modules/openat.orig Wed Nov 2 22:25:13 2011
> +++ modules/openatWed Nov 2 11:35:46 2011
Thanks yet again. Please push.
With all of this work, you should add your name to those Maintainer: lists.
FYI,
>From af0285db3e8dee3f40ba573e845362335ac0cff2 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 2 Nov 2011 09:15:34 +0100
Subject: [PATCH] putenv: indent #definition of "environ" to placate cppi
* lib/putenv.c (environ): Make indentation reflect cpp nesting.
---
Change
Jim Meyering wrote:
> Jim Meyering wrote:
>
>> I've been thinking about this for years, ever since the unpleasantness
>> of that first git commit that I mistakenly attributed to myself.
>>
>> With this new --amend=FILE option, you'll be able to maintain
&g
Bruno Haible wrote:
> The next split-off from module 'openat' is 'fchmodat'. Here's the proposed
> patch. Tested on a number of platforms.
>
>
> 2011-11-01 Bruno Haible
>
> New module 'fchmodat', split off from module 'openat'.
> * lib/openat.h (chmodat, lchmodat): Enable only if GNU
Jim Meyering wrote:
> I've been thinking about this for years, ever since the unpleasantness
> of that first git commit that I mistakenly attributed to myself.
>
> With this new --amend=FILE option, you'll be able to maintain
> a list of pairs where SHA is a 40-byt
Jim Meyering wrote:
> Eric Blake wrote:
>> On 11/01/2011 11:15 AM, Jim Meyering wrote:
>>> I've been thinking about this for years, ever since the unpleasantness
>>> of that first git commit that I mistakenly attributed to myself.
>>>
>>> Wi
Eric Blake wrote:
> On 11/01/2011 11:15 AM, Jim Meyering wrote:
>> I've been thinking about this for years, ever since the unpleasantness
>> of that first git commit that I mistakenly attributed to myself.
>>
>> With this new --amend=FILE option, you'll be
Jim Meyering wrote:
> I've been thinking about this for years, ever since the unpleasantness
> of that first git commit that I mistakenly attributed to myself.
>
> With this new --amend=FILE option, you'll be able to maintain
> a list of pairs where SHA is a 40-byt
isabling of colors consistently for all tile types
+ ls: handle disabling of colors consistently for all file types
* src/ls.c (print_color_indicator): Use consistent syntax for
all file and directory subtypes, and fall back to the color
of the base type if there is no enabled c
Dmitry V. Levin wrote:
> On Mon, Oct 31, 2011 at 05:11:28PM +0100, Jim Meyering wrote:
>> Dmitry V. Levin wrote:
>> > git-log mishandles date strings before 1970-01-01 UTC, and there is
>> > no use to specify --since=1970-01-01 by default anyway.
>> > * build
Gary V. Vaughan wrote:
>> The notation requirement made more sense back each ChangeLog entry
>> was not tied to the associated patch.
>
> Before modern VCS you mean?
Right.
> That's before my time then... even CVS still ties
> the ChangeLog to the patch does it not?
No. With CVS, it was not unc
Gary V. Vaughan wrote:
> Here is another patch to solve a similar issue with ChangeLog `tiny change'
> annotations, by interpreting a 'Copyright-paperwork-required: No' line in
> the git log message to mean that the ChangeLog output requires the `tiny
> change' annotation.
>
> Because the annotatio
Gary V. Vaughan wrote:
> More generally useful gnulib-local goodness from my Libtool `next' branch:
>
> I'm sure this is far from idiomatic Perl, but I'd very much like for this
> patch or something similar to be pushed so that FSF projects have a means
> to correctly track multiple patch authors w
Bruno Haible wrote:
> Jim Meyering wrote:
>> I'll test via coreutils once it's pushed.
>
> OK, I've pushed it, with this additional change squashed in:
...
Thanks.
That works fine, so I've updated coreutils:
>From 65527e1c1a69a9ec8201435a6361964bcf31a
Bruno Haible wrote:
> Hi Jim, Eric,
>
> Here is a proposed patch to split fchownat() off from the module 'openat'.
>
> The immediate motivation is that on MSVC, there is no and no
> , therefore code that fiddles with owners and groups leads to
> many more compilation problems than code that just d
Dmitry V. Levin wrote:
> git-log mishandles date strings before 1970-01-01 UTC, and there is
> no use to specify --since=1970-01-01 by default anyway.
> * build-aux/gitlog-to-changelog: By default, when no --since option
> was given, do not specify explicit --since option to git-log.
...
> - my $s
Dmitry V. Levin wrote:
...
> Subject: [PATCH] gitlog-to-changelog: new option --append-dot
>
> * build-aux/gitlog-to-changelog: New option --append-dot, makes the
> first non-blank line of each commit message terminated with a dot.
> ---
> ChangeLog |6 ++
> build-aux/g
FYI, I've just pushed the following fix.
I share blame, as the reviewer.
I did not test Friday's change until today.
>From a765077b04a89bffa2a6095c7988fb9a70857d7f Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sun, 30 Oct 2011 21:24:06 +0100
Subject: [PATCH] GNUmakefile: r
removes leading and
+ trailing blank lines before the code that issues a warning about an
+ empty commit message.
+
2011-10-30 Jim Meyering
test-parse-datetime.c: avoid new DST-related false positive test failure
diff --git a/build-aux/gitlog-to-changelog b/build-aux/gitlog-
Jim Meyering wrote:
> With last night's time switch here (from CEST to CST),
> I noticed that coreutils' "make check" would fail like this:
>
> test-parse-datetime.c:142: assertion failed
>
> Fixed with this:
>
> Subject: [PATCH] test-parse-date
With last night's time switch here (from CEST to CST),
I noticed that coreutils' "make check" would fail like this:
test-parse-datetime.c:142: assertion failed
Fixed with this:
>From 56ddf0fdeb52ce76718e0594db4f567401e90a2c Mon Sep 17 00:00:00 2001
From: Jim Meyering
Gary V. Vaughan wrote:
> Hi Jim,
...
>>> -# Override this in cfg.mk if you use a non-standard build-aux directory.
>>> -build_aux ?= $(srcdir)/build-aux
>>> +ifneq ($(build_aux),)
>>> + $(error '*** set $$(_build-aux) relative to $$(srcdir) instead of
>>> $$(build_aux)')
>>
>> That line is longer t
Gary V. Vaughan wrote:
> Hi Jim,
>
> On 25 Oct 2011, at 15:18, Gary V. Vaughan wrote:
>> On 25 Oct 2011, at 15:05, Jim Meyering wrote:
>>> Actually, I think we can both get what we want.
>>> I suggest to adjust your patch so that make is guaranteed to fail
>>
; which will not be matched by the above, the same goes for ptrdiff_t,
> size_t and wchar_t (as variable type specifiers).
Thanks for the report.
This should fix it:
>From f7dbcea690572e75a85aea1263a222b11414bdd5 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 25 Oct 2011 15:49:1
Jim Meyering wrote:
> Bruno Haible wrote:
>
>> Hi Jim,
>>
>>> The gnulib update induced a new (coreutils-specific) syntax-check failure:
>>>
>>> src/system.h:# define ENODATA (-1)
>>> make[3]: *** [sc_prohibit_always-defined_macros]
Bruno Haible wrote:
> Hi Jim,
>
>> The gnulib update induced a new (coreutils-specific) syntax-check failure:
>>
>> src/system.h:# define ENODATA (-1)
>> make[3]: *** [sc_prohibit_always-defined_macros] Error 1
>>
>> because gnulib now defines that symbol, so I have also removed
>> that de
Eric Blake wrote:
> Any objections to making the gnulib apply the gcc
> warn_unused_result attribute to waitpid(), even though glibc does not
> (yet) do likewise? After all, if you fail to check for failures on
> this syscall (particularly EINTR failures, where you should normally
> repeat the wa
[please configure your mail client to stop including both plain
and html versions of each message]
Gary V. Vaughan wrote:
> To what advantage over factoring out the duplication entirely at the
> source of the problem with the patch I submitted?
Not breaking some project's existing set-up when
th
Gary V. Vaughan wrote:
> I was wondering why 'make stable' would always use a stale version unless
> I manually updated my .version file first. It turns out that if you use
> a non-standard build-aux location, you have to tell GNUmakefile by setting
> _build-aux to get the .version dist-hook machi
Jim Meyering wrote:
>> Here is the patch that I expect to push tomorrow:
...
> I've fixed/improved the ChangeLog/commit-log:
>
> Subject: [PATCH] fts: close parent dir FD before returning from
> post-traversal fts_read
>
> The problem: the fts-using "mkdir
Jim Meyering wrote:
...
> Here is the patch that I expect to push tomorrow:
>
> Subject: [PATCH] fts: close parent dir FD before returning from
> post-traversal fts_read
>
> The problem: the fts-using "rm -rf A/B/" would attempt to unlink A,
> while a file descript
= 0
unlinkat(AT_FDCWD, "a", AT_REMOVEDIR) = 0
close(0)= 0
close(1) = 0
close(2)= 0
Here is the patch that I expect to push tomorrow:
>From a11c49cd72a91c05a272e36ff5d3cd92675c
Stefano Lattarini wrote:
> Hi everybody. Just my two cents about this matter ...
>
> On Saturday 22 October 2011, Bruno Haible wrote:
>> Gary V. Vaughan wrote:
>> > >> Running the (potentially) outdated configure, to build a (potentially)
>> > >> outdated Makefile, which may very well rerun acloc
Gary V. Vaughan wrote:
...
> Okay to push?
Yes, but with the following changes applied:
use this instead, per today's discussion:
make -k maintainer-clean || { ./configure && make maintainer-clean; }
and change "incase" to "in case" in the commit log and ChangeLog:
> readme-release: several
Bruno Haible wrote:
> Gary V. Vaughan wrote:
>> >> Running the (potentially) outdated configure, to build a (potentially)
>> >> outdated Makefile, which may very well rerun aclocal, automake, autoconf
>> >> etc just to call the maintainer-clean rule, and then blow it all away
>> >> in the next step
Gary V. Vaughan wrote:
> Hi Jim,
>
> On 22 Oct 2011, at 03:06, Jim Meyering wrote:
>> Gary V. Vaughan wrote:
>>> As it stands (without this patch), README-release recommends:
>>>
>>> git checkout master
>>> git pull
>>> ./configure
>
Gary V. Vaughan wrote:
...
>>> -* Run ./configure && make maintainer-clean
>>
>> Why do you want to remove the "make maintainer-clean"?
>> I saw no justification, so maybe it's an accident.
>
> Hmm... half and half. Here's the relevant bit of ChangeLog:
>
> + Don't try to run ./configure right
Gary V. Vaughan wrote:
> I made these changes in gnulib-local/top/README-release while making
> a start at leveraging the gnulib release machinery into GNU Libtool,
> but they seem generally applicable too.
Thanks for the suggestions.
However, it's not quite ready.
> Okay to push?
I'm glad you a
Gary V. Vaughan wrote:
...
> On the other hand, if by "incremental" you really mean chunking my rewrite
> into
> patches that add a function here and there, and disable bits of the old script
> when they are no longer called, then I could be persuaded to do that. How
> big should the chunks be to
Gary V. Vaughan wrote:
> On 19 Oct 2011, at 20:13, Jim Meyering wrote:
>> Gary V. Vaughan wrote:
>>>> Jim, please consider pulling it into coreutils master as a better fix than
>>>> twidding Makefiles after the fact in bootstrap.conf.
>>>>
>>
I ran gnulib's top-level "make check", and cppi spotted this:
>From ca3be51f7beb529726b066d1da34acd338828b24 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 19 Oct 2011 15:28:46 +0200
Subject: [PATCH] posix_openpt: remove spurious #endif
* lib/posix_openpt.c (pos
Gary V. Vaughan wrote:
>> Jim, please consider pulling it into coreutils master as a better fix than
>> twidding Makefiles after the fact in bootstrap.conf.
>>
>>> This -Iintl option will disappear with gettext version 0.19 - because
>>> then "gettextize --intl" will not work any more; it's already
Gary V. Vaughan wrote:
> Hi Pádraig, Jim,
>
> Is there anything else I can do to help you incorporate this, and the
> matching bootstrap.conf I wrote for you into coreutils now that the
> release is out?
Hi Gary,
Thanks for persevering. I have just tried it.
It looks like your coreutils working
n Oct 1.
Here's a fix:
>From 775119f83d459107178933d4baa8886e91b19a9c Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 10 Oct 2011 08:49:37 +0200
Subject: [PATCH] test-renameat: don't leave behind a temporary file
* tests/test-renameat.c (main): Don't forget to remove a tem
Jim Meyering wrote:
> Bruno Haible wrote:
>> On MacOS X 10.5, the following gnulib tests fail to link:
> ...
>> This is apparently due to the recent implementation change of getcwd().
>> This patch should fix it:
>>
>> 2011-10-08 Bruno Haible
>>
Bruno Haible wrote:
> On MacOS X 10.5, the following gnulib tests fail to link:
...
> This is apparently due to the recent implementation change of getcwd().
> This patch should fix it:
>
> 2011-10-08 Bruno Haible
>
> Tests: Avoid link failures w.r.t. libintl.
> * modules/faccessat-t
Bruno Haible wrote:
> Jim Meyering wrote:
>> I propose to push Kamil's fix (mainly to have a record of it,
>> in case we need it later), but then to immediately revert it
>> along with the file-has-acl.c change that started this.
>> That seems to be the right thin
/
- ret = acl_extended_file_nofollow (name);
-# else
/* On Linux, acl_extended_file is an optimized function: It only
makes two calls to getxattr(), one for ACL_TYPE_ACCESS, one for
ACL_TYPE_DEFAULT. */
- ret = acl_extended_file (name);
-# endif
Gary V. Vaughan wrote:
> Hi Jim,
>
> On 4 Oct 2011, at 17:09, Jim Meyering wrote:
>> Gary V. Vaughan wrote:
>>> Sorry I didn't notice your reply sooner.
>>>
>>> On 22 Sep 2011, at 23:38, Jim Meyering wrote:
>>>> Gary V. Vaughan wrote:
&g
Gary V. Vaughan wrote:
> Sorry I didn't notice your reply sooner.
>
> On 22 Sep 2011, at 23:38, Jim Meyering wrote:
>> Gary V. Vaughan wrote:
>>>>> * g...@github.com:gvvaughan/GNU-coreutils.git in gary/bootstrap
>>>>> https://github.com/gvvaughan/G
Kamil Dudka wrote:
> On Mon October 3 2011 15:02:20 Bruno Haible wrote:
>> The function name should explain the semantics of the function. The fact
>> that it's a wrapper around acl_extended_file is something one can see by
>> reading the code.
>>
>> Maybe call it acl_extended_file_optimized?
>
> S
introduced with 2011-07-22 commit 95f7c57f,
+ "file-has-acl: use acl_extended_file_nofollow if available".
+ See http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/28538
+
2011-10-01 Jim Meyering
maint.mk: adjust a release-related rule not to require use of gzip
Kamil Dudka wrote:
> On Mon October 3 2011 13:09:21 Jim Meyering wrote:
>> Kamil Dudka wrote:
>> > On Mon October 3 2011 12:45:01 Jim Meyering wrote:
>> >> Can you describe how to make "ls -L" misbehave without this patch?
>> >
>> > i
Kamil Dudka wrote:
> On Mon October 3 2011 12:45:01 Jim Meyering wrote:
>> Can you describe how to make "ls -L" misbehave without this patch?
>
> if you have a symlink to a file with ACL, 'ls -Ll' does not print the '+'
> at end of the column
Kamil Dudka wrote:
> The commit 95f7c57 introduced an unintended change in behavior of ls -L.
> I am attaching a patch that restores the old behavior. Thanks in advance
> for considering the patch!
>
> Kamil
>
> From 75836c03cb21d616591b11164b626556d9f26152 Mon Sep 17 00:00:00 2001
> From: Kamil D
In preparing to stop building gzip-compressed tarballs in a few
projects I maintain, this change comes in handy:
>From 244794a7887f13d9cdb91fed96932cc479905b96 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sat, 1 Oct 2011 17:33:42 +0200
Subject: [PATCH] maint.mk: adjust a release-rela
FYI,
>From 24fae8f857a1ab285dc936e697f1e10138e9 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sat, 1 Oct 2011 15:06:43 +0200
Subject: [PATCH] test-linkat: don't leave behind a temporary file
* tests/test-linkat.c (main): Don't forget to remove a temporary file.
Otherwi
Bruno Haible wrote:
> Jim Meyering wrote:
>> I've taken the liberty of adding the above file.
>
> Oops, I forgot a "git add" command. Thanks for the fix.
If you always write ChangeLog entries before committing, using
"vc-dwim --commit" to perform the com
nclude
>
> void
> _Qp_itoq (long double *result, int a)
> {
> /* Convert from 'int' to 'double', then from 'double' to 'long double'. */
> *result = (double) a;
> }
Hi Bruno,
Thanks for all of this work.
I've taken the liber
Bruno Haible wrote:
> Jim Meyering wrote:
>> > -#if MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING
>> > +#if HAVE_MSVC_INVALID_PARAMETER_HANDLER \
>> > +&& MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING
>> >gl_msvc_inval_ensure_
om the
> code.
>
> 2011-09-28 Bruno Haible
>
> fgetc, fputc, fread, fwrite tests: Fix link error.
> * tests/test-fgetc.c (main): Don't invoke gl_msvc_inval_ensure_handler
> on non-MSVC platforms.
> * tests/test-fputc.c (main): Likewise.
> *
Bruno Haible wrote:
>> FAIL: test-fgetc.exe
>> FAIL: test-fputc.exe
>> FAIL: test-fread.exe
>> FAIL: test-fwrite.exe
>>
>> All these fail on a stream whose file descriptor has been closed. Most
>> libraries won't do such a thing. Therefore I don't find it worth to fix
>> this. Just document it.
>
>
Reuben Thomas wrote:
> I've just been playing with gengetopt. There's a lot to like: it gives
> me (potentially multi-language) options handling for one line per
> option (plus any extra text I want) in a simple .ggo file, and half a
> dozen lines of code (four of which really should be redundant a
ror=shadow]
test-futimens.h:29:7: error: shadowed declaration is here [-Werror=shadow]
cc1: all warnings being treated as errors
I fixed it like this:
>From 90520caf3cfe735b83237a11034b7aa0c3bb05b9 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sat, 24 Sep 2011 21:02:15 +0200
Subject
Bruno Haible wrote:
> Hi Jim,
>
>> > About this change of fts.c from 2011-08-18.
>> > The declaration of max_entries in line 1339 comes after a statement. Not
>> > valid C99.
>>
>> s/C99/C89/
>
> Oops, yes. Not valid C89.
>
>> C89 is now more than 12 years old
>
> You meant s/C89/C99/ ?
No, I mean
Bruno Haible wrote:
> Hi Jim,
>
> About this change of fts.c from 2011-08-18.
> The declaration of max_entries in line 1339 comes after a statement. Not
> valid C99.
s/C99/C89/
> gnulib's conventions are still to not require a C99 compiler.
Hi Bruno,
I see so much more value in using C99's decl
901 - 1000 of 3879 matches
Mail list logo
