Paul Eggert wrote:
>Other than that, it looks good. As I understand it, you want the
>following change from a day ago. This is pretty simple.
>
>
Yes. I've installed this. I've not attached a patch since you
effectively sent it out in your last email.
2005-09-15 Derek Price <[EMAIL PROTE
Derek Price <[EMAIL PROTECTED]> writes:
> I've attached hte following for review since I took the liberty of
> replacing two #if __GNUC__ >= constructs in regex_internal.h with
> __GNUC_PREREQ calls.
Let's avoid that, since we want to minimize the differences from glibc.
Other than that, it looks
Paul Eggert wrote:
> You can use the __GNUC_PREREQ macro of md5.h.
Well, I find that
#if __GNUC__ < 3 || (__GNUC__ == 3 && __GNUC_MINOR < 1)
is just as understandable as
#if !__GNUC_PREREQ (3, 1)
and that therefore such a features.h is not needed. Probably a matter of
taste...
Bruno
__
Paul Eggert wrote:
>We don't need all thse definitions of __GNUC_PREREQ, since
>regex_internal.h is included before the other .c files are; see
>regex.c. Could you please simplify the patch accordingly? Only
>
>
I've attached hte following for review since I took the liberty of
replacing two
Derek Price <[EMAIL PROTECTED]> writes:
> 2005-09-15 Derek Price <[EMAIL PROTECTED]>
>
>* regex_internal.h: Blank `pure' for GNUC < 3.
>* regex_internal.c: Ditto, using this...
>(__GNUC_PREREQ): ...new macro.
>* regcomp.c, regexec.c: Blank `always_inline' for GN
Derek Price <[EMAIL PROTECTED]> writes:
> is there a simple reference I could use to find what version of GCC an
> attribute first appeared in? Something easier than fumbling through the
> CVS history, that is. :)
Not that I know of, sorry. I've had the same problem myself.
I have looked at t
Paul Eggert wrote:
>I'd fix it if I were you. You can use the __GNUC_PREREQ macro of
>md5.h.
>
>
I know I've already installed this fix but, for future reference, is
there a simple reference I could use to find what version of GCC an
attribute first appeared in? Something easier than fumbling
Paul Eggert wrote:
>I'd fix it if I were you. You can use the __GNUC_PREREQ macro of
>md5.h.
>
I've installed the attached patch. It compiles cleanly on the offending
alpha-linux system. I pretty-much cut & pasted the __GNUC_PREREQ macro
out of md5.h, as you suggested, and used it, except in r
e like.
A downside of this approach is a possible version mismatch between a
native glibc features.h and the gnulib features.h. But I expect we
could solve that problem if it actually arose.
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib
