bug#12883: [2.0.6] CSE bug

2012-11-21 Thread Ludovic Courtès
I just committed the fix and test case. Thanks! Ludo’.

bug#12883: [2.0.6] CSE bug

2012-11-21 Thread Stefan Israelsson Tampe
> I think this sentence is ungrammatical, or at least I’m lost. eh, sorry, but consider the db as h,db-len e1 <- m = 0 e2 e3 e4 e5 e6 <- h* e7 then db-len is 7 and db-len* is 2 and db-len - deb-len* = 5 which is the number of steps to go from e2 to e6, e.g. we will scan through the list from m

bug#12883: [2.0.6] CSE bug

2012-11-20 Thread Ludovic Courtès
Hi Stefan! Thanks for your message! Stefan Israelsson Tampe skribis: > The intention of unroll is to scan db to check that a commutative > property for an item going into the function holds for all elements in > db up to h==h* is found. I think this sentence is ungrammatical, or at least I’m l

bug#12883: [2.0.6] CSE bug

2012-11-19 Thread Stefan Israelsson Tampe
I will send an updated patch later, but to explain I'm not the author of this so I need you to follow my analyze or we will wait for the author to check this! The intention of unroll is to scan db to check that a commutative property for an item going into the function holds for all elements in d

bug#12883: [2.0.6] CSE bug

2012-11-18 Thread Ludovic Courtès
Hi Stefan, Stefan Israelsson Tampe skribis: > --- a/module/language/tree-il/cse.scm > +++ b/module/language/tree-il/cse.scm > @@ -324,10 +324,11 @@ > (and (< n env-len) > (match (vlist-ref env n) >((#(exp* name sym db-len*) . h*) > -

bug#12883: [2.0.6] CSE bug

2012-11-15 Thread Stefan Israelsson Tampe
This is better! On Thu, Nov 15, 2012 at 5:24 PM, Ludovic Courtès wrote: > Hi Stefan! > > Stefan Israelsson Tampe skribis: > > > --- a/module/language/tree-il/cse.scm > > +++ b/module/language/tree-il/cse.scm > > @@ -324,10 +324,11 @@ > > (and (< n env-len) > >

bug#12883: [2.0.6] CSE bug

2012-11-15 Thread Ludovic Courtès
Hi Stefan! Stefan Israelsson Tampe skribis: > --- a/module/language/tree-il/cse.scm > +++ b/module/language/tree-il/cse.scm > @@ -324,10 +324,11 @@ > (and (< n env-len) > (match (vlist-ref env n) >((#(exp* name sym db-len*) . h*) > -

bug#12883: [2.0.6] CSE bug

2012-11-15 Thread Stefan Israelsson Tampe
I did git diff cse.scm > cse.diff and send it with this mail (I removed the logging code though) On Wed, Nov 14, 2012 at 11:10 PM, Ludovic Courtès wrote: > Hi Stefan, > > Can you send the proposed change as a unidiff patch? > > TIA, > Ludo’. > cse.diff Description: Binary data

bug#12883: [2.0.6] CSE bug

2012-11-14 Thread Ludovic Courtès
Hi Stefan, Can you send the proposed change as a unidiff patch? TIA, Ludo’.

bug#12883: [2.0.6] CSE bug

2012-11-14 Thread Stefan Israelsson Tampe
Hey, the unroll code looks really weird in find-dominating-lexical, I know it's difficult to just come in and propose a change, but hey it can only help :-) With this code, (define (find-dominating-lexical exp effects env db) (define (entry-matches? v1 v2) (match (if (vector? v1) v1 v2)

bug#12883: [2.0.6] CSE bug

2012-11-14 Thread Ludovic Courtès
Hello, This piece of code triggers a CSE bug: --8<---cut here---start->8--- (use-modules (ice-9 match)) (define (snix-derivation->guix-package derivation) (match derivation (((_ _ _)) #t))) --8<---cut here---end--