Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-02-07 Thread lilypond
Updates: Status: Verified Comment #20 on issue 1268 by brownian.box: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 I guess it is really fixed -- no tiny example, but regtest added. So, Verified. However, that regtest is hard to verify, one will have

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-02-01 Thread lilypond
Updates: Status: Fixed Labels: -Patch-review fixed_2_13_48 Comment #19 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Pushed. ___ bug-lilypond mailing list bug-lily

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-29 Thread lilypond
Updates: Labels: -Patch-needs_work Patch-review Comment #18 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 New patch looks good. ___ bug-lilypond mailing list bug-lilypond@

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-28 Thread lilypond
Updates: Labels: -Patch-review Patch-needs_work Comment #17 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Neil has identified some problems with this patch. Unfortunately I really should move ahead with 2.13.47 right

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-23 Thread lilypond
Updates: Status: Started Comment #16 on issue 1268 by carl.d.s...@gmail.com: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-23 Thread lilypond
Updates: Labels: -Patch Patch-review Comment #15 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 A few minor nitpicks, but nothing terribly wrong, so I'll move it to patch-review. __

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-18 Thread lilypond
Comment #14 on issue 1268 by benko@gmail.com: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 patchset at http://codereview.appspot.com/4025044/ ___ bug-lilypond mailing list bug-lilypond@gnu.org http://lists.gnu.

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-03 Thread lilypond
Updates: Status: Accepted Comment #13 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Yes; since there is now active discussion and work on the patch, it's certainly not invalid. ___

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-02 Thread lilypond
Comment #12 on issue 1268 by brownian.box: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Sorry, why "Invalid" so far? Shouldn't it be changed so smth else? ___ bug-lilypond mailing list bug-lilypond@gnu.org http://l

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-02 Thread lilypond
Comment #11 on issue 1268 by benko.pal: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 new patch in http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00040.html ___ bug-lilypond mailing list bug-lilypond@gn

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-12-25 Thread lilypond
Comment #10 on issue 1268 by benko.pal: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 hi Joe, (sorry if you got it twice) thanks for the hint. do you think my patch is a good start? I removed the center setting code and that (with my patch still active) made

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-12-22 Thread lilypond
Comment #9 on issue 1268 by joeneeman: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 I've tracked the problem down to Bar_line::compound_barline, which tries to center the bar line around the center of the staff (see lines 119 and below). ___

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-12-21 Thread lilypond
Comment #8 on issue 1268 by benko.pal: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 the problem is not specific to ancient music, I think: it's that overriding Staff.StaffSymbol #'line-positions makes something inconsistent: either the refpoint of the staff or

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-12-21 Thread lilypond
Comment #7 on issue 1268 by jameseli...@googlemail.com: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 So I understand • There is a problem with the span-bar in ancient music when using a mensurstrich layout • The patch submitted does not actually do what i

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-12-15 Thread lilypond
Comment #6 on issue 1268 by benko.pal: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 Re comment 2: the intent was to - replace bar-size by line_span - return not an uninitialised but default constructed variable, like the original version _

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-12-15 Thread lilypond
Comment #5 on issue 1268 by bealingsplayfordnews: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 I was checking the bug reports which did not have a valid status - i.e. accepted or started. Based on Graham's comment, it didn't seem a good idea to leave it f

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-12-15 Thread lilypond
Updates: Cc: PhilEHolmes Comment #4 on issue 1268 by v.villenave: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 This patch was meant to address a very specific issue with ancient music and custom staff-positions... Phil, do you know if this issue has

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-12-15 Thread lilypond
Updates: Status: Invalid Comment #3 on issue 1268 by PhilEHolmes: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org ht

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-10-11 Thread lilypond
Comment #2 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 As far as I can see, this patch: - removes the bar-size property from the calc_bar_extent() function - returns an uninitalized variable if it can't get a staff_symbol.

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2010-10-10 Thread lilypond
Updates: Labels: Priority-Medium Comment #1 on issue 1268 by percival.music.ca: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilyp

Issue 1268 in lilypond: [PATCH] span-bar problem

2010-09-21 Thread lilypond
Status: New Owner: Labels: Type-Enhancement Patch New issue 1268 by neziap: [PATCH] span-bar problem http://code.google.com/p/lilypond/issues/detail?id=1268 http://lists.gnu.org/archive/html/lilypond-devel/2010-09/msg00019.html ___ bug-lilypond