Hello,
Please review the proposed changes for 8008577[1], the implementation of
the JEP-252[2]. The proposed changes are located at:
http://cr.openjdk.java.net/~naoto/8008577/webrev.00/
Here are the very high level summary of changes:
- Now the default locale provider order is CLDR,JRE,SPI.
Hello Naoto,
Build changes look good to me.
/Erik
On 2015-06-08 22:58, Naoto Sato wrote:
Hello,
Please review the proposed changes for 8008577[1], the implementation
of the JEP-252[2]. The proposed changes are located at:
http://cr.openjdk.java.net/~naoto/8008577/webrev.00/
Here are the v
Thank you for the quick review, Erik!
Naoto
On 6/9/15 12:59 AM, Erik Joelsson wrote:
Hello Naoto,
Build changes look good to me.
/Erik
On 2015-06-08 22:58, Naoto Sato wrote:
Hello,
Please review the proposed changes for 8008577[1], the implementation
of the JEP-252[2]. The proposed changes
Sorry for taking time. Here are my comments.
src/jdk.localedata/share/classes/sun/text/resources/*JavaTimeSupplementary*.java:
- The year range of the first line of the copyright header should be
"2015," for the new ones and "2013, 2015," for the updated ones.
- I wonder if JavaTimeSupplementa
Here is the updated webrev:
http://cr.openjdk.java.net/~naoto/8008577/webrev.01/
As to the 3rd comment below, I did not modify it because that would
simply duplicate the same piece of code in each getCandidateLocales()
implementation (from the current location).
Naoto
On 6/19/15 1:53 AM, Ma
applyParentLocales() sets parentLocalesMap before populating the map
with data. It's possible that other threads look up the map without the
(full) data. So, a Map (local variable) should be populated and then
parentLocalesMap should be set to the Map. Also, parentLocalesMap needs
to be volatil
Thanks. Here is the diff from "webrev.01" to address your comment:
http://hg.openjdk.java.net/jdk9/sandbox/jdk/rev/b8faab65bb62
Naoto
On 6/24/15 2:16 AM, Masayoshi Okutsu wrote:
applyParentLocales() sets parentLocalesMap before populating the map
with data. It's possible that other threads loo
Looks good to me.
Masayoshi
On 6/25/2015 1:15 AM, Naoto Sato wrote:
Thanks. Here is the diff from "webrev.01" to address your comment:
http://hg.openjdk.java.net/jdk9/sandbox/jdk/rev/b8faab65bb62
Naoto
On 6/24/15 2:16 AM, Masayoshi Okutsu wrote:
applyParentLocales() sets parentLocalesMap be