Looks good!
/Erik
On 2016-05-06 15:35, Claes Redestad wrote:
Hi,
an innocuous last minute change slipped in which actually broke
cross-compilation support. Adding this puts things back in order:
diff -r c861a5be9c88 common/autoconf/buildjdk-spec.gmk.in
--- a/common/autoconf/buildjdk-spec.gm
Hi,
an innocuous last minute change slipped in which actually broke
cross-compilation support. Adding this puts things back in order:
diff -r c861a5be9c88 common/autoconf/buildjdk-spec.gmk.in
--- a/common/autoconf/buildjdk-spec.gmk.inThu May 05 22:39:14 2016 -0700
+++ b/common/autoconf/bui
> On May 4, 2016, at 1:12 PM, Claes Redestad wrote:
>
>
>>
>> One question: where do you create the interim JMOD files? Or do you create
>> it under images/jmods?
>
> No interim jmods are created for regular builds, while for cross-compilation
> a buildjdk is created from JMOD files genera
On 2016-05-04 21:45, Mandy Chung wrote:
On May 4, 2016, at 6:36 AM, Claes Redestad wrote:
Hi,
please review this change to generate classlists at build-time
bug: https://bugs.openjdk.java.net/browse/JDK-8150044
webrevs:
top: http://cr.openjdk.java.net/~redestad/8150044/top.01/
jdk: http://
> On May 4, 2016, at 6:36 AM, Claes Redestad wrote:
>
> Hi,
>
> please review this change to generate classlists at build-time
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8150044
>
> webrevs:
> top: http://cr.openjdk.java.net/~redestad/8150044/top.01/
> jdk: http://cr.openjdk.java.net/~
On 04/05/2016 14:36, Claes Redestad wrote:
Hi,
please review this change to generate classlists at build-time
bug: https://bugs.openjdk.java.net/browse/JDK-8150044
webrevs:
top: http://cr.openjdk.java.net/~redestad/8150044/top.01/
jdk: http://cr.openjdk.java.net/~redestad/8150044/jdk.01/
hot
Hi Ioi,
On 2016-05-04 16:05, Ioi Lam wrote:
Hi Claes,
The HotSpot changes look good to me.
thanks!
I am not knowledgeable enough to comment on the top repo makefile
changes.
Regarding the JDK changes, in HelloClasslist.java:
Maybe add a comment about how/why you choose this particular
Once installed, autoconf ran properly with make reconfigure - thx.
> On May 4, 2016, at 11:24 AM, Erik Joelsson wrote:
>
> Depends on which OS you are using. You need version 2.69, which is the
> latest. On linux, "apt-get/yum install autoconf" should do the trick unless
> your distribution i
On 04/05/2016 15:05, Ioi Lam wrote:
:
Regarding the JDK changes, in HelloClasslist.java:
Maybe add a comment about how/why you choose this particular set of
operations? When the JDK evolves in the future, how should this file
be changed?
I notice that no GUI classes are used. Is the reaso
Depends on which OS you are using. You need version 2.69, which is the
latest. On linux, "apt-get/yum install autoconf" should do the trick
unless your distribution is ancient. On windows add autoconf through the
cygwin installer. On mac I think "brew install autoconf" is easiest if
you are int
Correct. How do I set up autogen so I can apply these changes?
> On May 4, 2016, at 11:11 AM, Erik Joelsson wrote:
>
> Build changes look ok to me, but I also helped write most of them.
>
> This certainly adds some build complexity and might seem overly so for just
> this optimization. As I
Build changes look ok to me, but I also helped write most of them.
This certainly adds some build complexity and might seem overly so for
just this optimization. As I understand it, the plan is to expand this
build time profiling concept to generate more profile data that can be
used by for ex
Hi Claes,
The HotSpot changes look good to me.
I am not knowledgeable enough to comment on the top repo makefile changes.
Regarding the JDK changes, in HelloClasslist.java:
Maybe add a comment about how/why you choose this particular set of
operations? When the JDK evolves in the future, how
Hi,
please review this change to generate classlists at build-time
bug: https://bugs.openjdk.java.net/browse/JDK-8150044
webrevs:
top: http://cr.openjdk.java.net/~redestad/8150044/top.01/
jdk: http://cr.openjdk.java.net/~redestad/8150044/jdk.01/
hotspot: http://cr.openjdk.java.net/~redestad/815
14 matches
Mail list logo