Re: Review request : Erasure Code plugin loader implementation

2013-08-20 Thread Loic Dachary
Hi Sage, I created "erasure code : convenience functions to code / decode" http://tracker.ceph.com/issues/6064 to implement the suggested functions. Please let me know if this should be merged with another task. Cheers On 19/08/2013 17:06, Loic Dachary wrote: > > > On 19/08/2013 02:01, Sage

Re: Review request : Erasure Code plugin loader implementation

2013-08-19 Thread Sage Weil
On Mon, 19 Aug 2013, Loic Dachary wrote: > > > On 19/08/2013 02:01, Sage Weil wrote: > > On Sun, 18 Aug 2013, Loic Dachary wrote: > >> Hi Sage, > >> > >> Unless I misunderstood something ( which is still possible at this stage > >> ;-) decode() is used both for recovery of missing chunks and ret

Re: Review request : Erasure Code plugin loader implementation

2013-08-19 Thread Loic Dachary
On 19/08/2013 02:01, Sage Weil wrote: > On Sun, 18 Aug 2013, Loic Dachary wrote: >> Hi Sage, >> >> Unless I misunderstood something ( which is still possible at this stage ;-) >> decode() is used both for recovery of missing chunks and retrieval of the >> original buffer. Decoding the M data ch

Re: Review request : Erasure Code plugin loader implementation

2013-08-19 Thread Loic Dachary
Hi Sage, This makes a lot more sense indeed. I updated the http://tracker.ceph.com/issues/5878 description accordingly. ceph osd pool create poolname erasure-code-dir=/var/lib/ceph/erasure-code erasure-code-plugin=jerasure erasure-code-m=10 erasure-code-k=3 erasure-code-algorithm=Reed-Solomon

Re: Review request : Erasure Code plugin loader implementation

2013-08-18 Thread Sage Weil
Hi Loic, One other thought on http://tracker.ceph.com/issues/5878: The user interface there would let you adjust various parameters of the pool's erasure coding scheme after the pool is created. As a practical matter, I suspect that many/most of these fields will be specified exactly once (at

Re: Review request : Erasure Code plugin loader implementation

2013-08-18 Thread Sage Weil
On Sun, 18 Aug 2013, Loic Dachary wrote: > Hi Sage, > > Unless I misunderstood something ( which is still possible at this stage ;-) > decode() is used both for recovery of missing chunks and retrieval of the > original buffer. Decoding the M data chunks is a special case of decoding N > <= M c

Re: Review request : Erasure Code plugin loader implementation

2013-08-18 Thread Loic Dachary
Hi Sage, Unless I misunderstood something ( which is still possible at this stage ;-) decode() is used both for recovery of missing chunks and retrieval of the original buffer. Decoding the M data chunks is a special case of decoding N <= M chunks out of the M+K chunks that were produced by enc

Re: Review request : Erasure Code plugin loader implementation

2013-08-18 Thread Sage Weil
On Sun, 18 Aug 2013, Loic Dachary wrote: > Hi Ceph, > > I've implemented a draft of the Erasure Code plugin loader in the context of > http://tracker.ceph.com/issues/5878. It has a trivial unit test and an > example plugin. It would be great if someone could do a quick review. The > general ide

Review request : Erasure Code plugin loader implementation

2013-08-18 Thread Loic Dachary
Hi Ceph, I've implemented a draft of the Erasure Code plugin loader in the context of http://tracker.ceph.com/issues/5878. It has a trivial unit test and an example plugin. It would be great if someone could do a quick review. The general idea is that the erasure code pool calls something like: