Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

alexfh added inline comments. Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25 @@ +24,3 @@ + SmallVector Classes; + Option.split(Classes, ","); + return std::vector(Classes.begin(), Classes.end()); aaron.ballman wrote: > It might

Re: [PATCH] D16183: Added CheckName field to YAML report

alexfh added a comment. Thanks for addressing the comments. However, the main concern is this: In http://reviews.llvm.org/D16183#326759, @alexfh wrote: > I'm not sure `tooling::Replacement` is the best place to store check name. > Maybe create a separate wrapper class and serialize it instead

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

aaron.ballman added inline comments. Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25 @@ +24,3 @@ + SmallVector Classes; + Option.split(Classes, ","); + return std::vector(Classes.begin(), Classes.end()); alexfh wrote: >

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ASTContext.cpp:4635 @@ +4634,3 @@ + // If the two sides have Float128Rank and LongDoubleRank and the two types + // have the same representation on this platform, they have equal rank. + if ((LHSR ==

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

aaron.ballman added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:216 @@ +215,3 @@ +/// HeaderFileExtensions. +bool endWithHeaderFileExtensions(llvm::StringRef FileName, + llvm::StringRef HeaderFileExtensions); alexfh

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pxli168 updated this revision to Diff 44881. pxli168 added a comment. Add prefix "__" to CodeGen builtin function name. http://reviews.llvm.org/D15914 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

sbenza marked an inline comment as done. Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:51 @@ +50,3 @@ + const auto StringFindFunctions = + anyOf(hasName("find"), hasName("rfind"), hasName("find_first_of"), +hasName("find_first_not_of"),

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

aaron.ballman added inline comments. Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:29 @@ +28,3 @@ +Class = Class.trim(); + return std::vector(Classes.begin(), Classes.end()); +} I think hasName() will assert if given an empty string, so this

Re: [PATCH] D15686: PR25910: clang allows two var definitions with the same mangled name

This revision was automatically updated to reflect the committed changes. Closed by commit rL257754: PR25910: clang allows two var definitions with the same mangled name (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D15686?vs=44425=44845#toc Repository: rL LLVM

Re: [PATCH] D16138: Correct setting of UserLabelPrefix for MCU target

andreybokhanko added a comment. @rafael, thank you! In http://reviews.llvm.org/D16138#325739, @rafael wrote: > LGTM, but could you change the default in a followup commit? TargetInfo > should really be setting it to "" since it is far more common than "_". Sure, will do. Yours, Andrey

r257754 - PR25910: clang allows two var definitions with the same mangled name

Author: asbokhan Date: Thu Jan 14 04:41:16 2016 New Revision: 257754 URL: http://llvm.org/viewvc/llvm-project?rev=257754=rev Log: PR25910: clang allows two var definitions with the same mangled name Proper diagnostic and resolution of mangled names' conflicts in variables. When there is a

Re: [PATCH] D15686: PR25910: clang allows two var definitions with the same mangled name

andreybokhanko added a comment. @tra, @rnk, @rjmccall, thanks for the review! Yours, Andrey Repository: rL LLVM http://reviews.llvm.org/D15686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pekka.jaaskelainen added a comment. OK. Seems the LLVM 3.8 branching was done, it might be hard to get this in, but should we try and ask the release manager? Comment at: lib/CodeGen/CGBuiltin.cpp:1981 @@ +1980,3 @@ + const char *Name = + (BuiltinID ==

Re: [PATCH] D16138: Correct setting of UserLabelPrefix for MCU target

This revision was automatically updated to reflect the committed changes. Closed by commit rL257756: Correct setting of UserLabelPrefix for MCU target. (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D16138?vs=44726=44849#toc Repository: rL LLVM

r257756 - Correct setting of UserLabelPrefix for MCU target.

Author: asbokhan Date: Thu Jan 14 04:59:36 2016 New Revision: 257756 URL: http://llvm.org/viewvc/llvm-project?rev=257756=rev Log: Correct setting of UserLabelPrefix for MCU target. Differential Revision: http://reviews.llvm.org/D16138 Modified: cfe/trunk/lib/Basic/Targets.cpp

[PATCH] D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

xazax.hun created this revision. xazax.hun added reviewers: alexfh, congliu. xazax.hun added subscribers: cfe-commits, dkrupp. Herald added subscribers: rengolin, aemerson. First of all thank you for this great check! In this patch I propose one small cleanup and two changes in the behaviour.

[PATCH] D16178: [analyzer] A quick fix on top of D12901/r257464

NoQ created this revision. NoQ added reviewers: pgousseau, zaks.anna, dcoughlin, xazax.hun. NoQ added a subscriber: cfe-commits. Sorry for being a bit slow, i should have had a look at the review earlier; i noticed some stuff after the recent patch by Pierre Gousseau was committed. 1. There's

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev updated this revision to Diff 44848. ABataev added a comment. Updated to latest version + some fixes and improvements http://reviews.llvm.org/D11182 Files: include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AST/DeclOpenMP.h

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

Weiming Zhao wrote: weimingz created this revision. weimingz added a reviewer: nicholas. weimingz added a subscriber: cfe-commits. r255371 errors on redeclaring with a conflicting asm label. This patch changes errors to warnings to prevent breaking existing codes. Can you include a testcase

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

nicholas added a subscriber: nicholas. nicholas added a comment. Weiming Zhao wrote: > weimingz created this revision. > weimingz added a reviewer: nicholas. > weimingz added a subscriber: cfe-commits. > > r255371 errors on redeclaring with a conflicting asm label. > This patch changes

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

Anastasia added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:1981 @@ +1980,3 @@ + const char *Name = + (BuiltinID == Builtin::BIread_pipe) ? "read_pipe_2" : "write_pipe_2"; + // Re-Creating the function type for this call, since the original type

r257757 - Fix for armv7-a15 and thumbv7-a15 buildbot fails.

Author: asbokhan Date: Thu Jan 14 05:53:50 2016 New Revision: 257757 URL: http://llvm.org/viewvc/llvm-project?rev=257757=rev Log: Fix for armv7-a15 and thumbv7-a15 buildbot fails. Modified: cfe/trunk/test/CodeGenCXX/duplicate-mangled-name.cpp Modified:

Re: r257754 - PR25910: clang allows two var definitions with the same mangled name

On 14 January 2016 at 10:41, Andrey Bokhanko via cfe-commits wrote: > Author: asbokhan > Date: Thu Jan 14 04:41:16 2016 > New Revision: 257754 > > URL: http://llvm.org/viewvc/llvm-project?rev=257754=rev > Log: > PR25910: clang allows two var definitions with the same

Re: [PATCH] D16112: PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration

d.zobnin.bugzilla updated this revision to Diff 44859. d.zobnin.bugzilla added a comment. Thanks for the review! Updated the patch: added Subjects line for the attribute and removed the "err_attr_wrong_decl" diagnostics. http://reviews.llvm.org/D16112 Files: include/clang/AST/Decl.h

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

alexfh added a comment. Awesome! See a few comments inline. Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:51 @@ +50,3 @@ + const auto StringFindFunctions = + anyOf(hasName("find"), hasName("rfind"), hasName("find_first_of"), +

Re: [PATCH] D16183: Added CheckName field to YAML report

alexfh added a comment. I'm not sure `tooling::Replacement` is the best place to store check name. Maybe create a separate wrapper class and serialize it instead (clang-apply-replacements will have to be changed to support this format as well). This could be `ClangTidyDiagnostic` or just

Re: r257754 - PR25910: clang allows two var definitions with the same mangled name

Renato, Thanks! -- I committed a fix already: http://llvm.org/viewvc/llvm-project?view=revision=257757 Yours, Andrey On Thu, Jan 14, 2016 at 2:57 PM, Renato Golin wrote: > On 14 January 2016 at 10:41, Andrey Bokhanko via cfe-commits >

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

alexfh added inline comments. Comment at: clang-tidy/tool/ClangTidyMain.cpp:78 @@ +77,3 @@ +static cl::opt +HeaderFileExtensions("header-file-extensions", + cl::desc("File extensions that regard as header file.\n" hokein wrote: > alexfh wrote:

Re: [PATCH] D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

alexfh added a comment. > ... What about a configuration option to also report near misses when only a > qualifier is missing? Might be a useful thing. We should first check if it makes sense to always ignore a qualifier. Comment at:

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

a.makarov added a comment. Ping http://reviews.llvm.org/D15373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Adding Python 3 compatibility to Clang Python bindings

For your consideration: Attached is a patch that adds Python 3 compatibility (without losing Python 2 compatibility) to Clang’s Python bindings. The patch also includes PEP8 formatting cleanups, and a setup.py file to make it easier to install the bindings into a working Python development

[PATCH] D16183: Added CheckName field to YAML report

Elijah_Th created this revision. Elijah_Th added reviewers: klimek, alexfh, djasper, cfe-commits. Herald added a subscriber: klimek. See details in https://llvm.org/bugs/show_bug.cgi?id=26132 http://reviews.llvm.org/D16183 Files: tools/clang/include/clang/Tooling/Core/Replacement.h

Re: [PATCH] D16178: [analyzer] A quick fix on top of D12901/r257464

pgousseau accepted this revision. pgousseau added a comment. This revision is now accepted and ready to land. LGTM! Thanks Artom for finding the bug and new test case, sorry for missing those in my patch! Removing "!IsNotTruncated" is definitely worth trying. Please commit if code owners are

r257762 - [mips] Added support for -Wa,-mips32 and similar.

Author: s.egerton Date: Thu Jan 14 07:01:48 2016 New Revision: 257762 URL: http://llvm.org/viewvc/llvm-project?rev=257762=rev Log: [mips] Added support for -Wa,-mips32 and similar. Reviewers: vkalintiris, dsanders Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D15070

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

aaron.ballman added a comment. In http://reviews.llvm.org/D15373#315457, @a.makarov wrote: > I've updated the patch. Please, re-review it again. > About creating attributed type - I think we shouldn't create it if we > ignored specified CC attribute. Ignoring specified CC attribute (and

Re: [PATCH] D15907: Allow various function attributes to be specified on Objective-C blocks too.

aaron.ballman added a comment. At a high level, is there a reason why these should be supported on block, but not on ObjC method declarations? It smells like these may be useful there as well, which could also simplify the patch slightly. Comment at:

r257765 - [Hexagon] Change all builtins returning "bool" to return "int" instead

Author: kparzysz Date: Thu Jan 14 08:26:36 2016 New Revision: 257765 URL: http://llvm.org/viewvc/llvm-project?rev=257765=rev Log: [Hexagon] Change all builtins returning "bool" to return "int" instead Modified: cfe/trunk/include/clang/Basic/BuiltinsHexagon.def Modified:

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On Thu, Jan 14, 2016 at 02:05:21AM +, Weiming Zhao via cfe-commits wrote: > r255371 errors on redeclaring with a conflicting asm label. > This patch changes errors to warnings to prevent breaking existing codes. I'm not sure I agree with this. We have triggered this in NetBSD in two different

r257763 - clang-format: Fix incorrectly enforced linebreak with ColumnLimit 0.

Author: djasper Date: Thu Jan 14 07:36:46 2016 New Revision: 257763 URL: http://llvm.org/viewvc/llvm-project?rev=257763=rev Log: clang-format: Fix incorrectly enforced linebreak with ColumnLimit 0. Before: [] .(); After: [].(); Modified:

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! http://reviews.llvm.org/D15709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: r256468 - On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

Did you get an answer to this question? I think it's just that the FreeBSD class hasn't refactored to that style yet. That switch statement is getting quite large so it would be a nice cleanup to switch to that style. > -Original Message- > From: cfe-commits

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

alexfh added inline comments. Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25 @@ +24,3 @@ + SmallVector Classes; + Option.split(Classes, ","); + return std::vector(Classes.begin(), Classes.end()); aaron.ballman wrote: > alexfh

r257774 - [WebAssembly] Configure some simple include paths and runtime library settings.

Author: djg Date: Thu Jan 14 10:00:13 2016 New Revision: 257774 URL: http://llvm.org/viewvc/llvm-project?rev=257774=rev Log: [WebAssembly] Configure some simple include paths and runtime library settings. Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/ToolChains.h

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

alexfh added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:216 @@ +215,3 @@ +/// HeaderFileExtensions. +bool endWithHeaderFileExtensions(llvm::StringRef FileName, + llvm::StringRef HeaderFileExtensions); aaron.ballman

r257861 - Save the integer type for integral template arguments.

Author: rtrieu Date: Thu Jan 14 20:55:17 2016 New Revision: 257861 URL: http://llvm.org/viewvc/llvm-project?rev=257861=rev Log: Save the integer type for integral template arguments. Save the integer type when diffing integers in template type diffing. When integers are different sizes, print

Re: [PATCH] D15866: Warn when using `defined` in a macro definition.

thakis updated this revision to Diff 44958. thakis added a comment. For function-type macros, make the warning only show up with -pedantic http://reviews.llvm.org/D15866 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPExpressions.cpp

r257863 - When copying whitespace flags from the token naming a macro argument onto the

Author: rsmith Date: Thu Jan 14 21:24:18 2016 New Revision: 257863 URL: http://llvm.org/viewvc/llvm-project?rev=257863=rev Log: When copying whitespace flags from the token naming a macro argument onto the first token of the expansion, don't forget to copy the "is at the start of a line" token

Re: [PATCH] D15866: Warn when using `defined` in a macro definition.

thakis marked an inline comment as done. thakis added a comment. Also addressed your comment and added a test for that. http://reviews.llvm.org/D15866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15866: Warn when using `defined` in a macro definition.

thakis updated this revision to Diff 44959. thakis added a comment. Address review comment. http://reviews.llvm.org/D15866 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPExpressions.cpp test/Lexer/cxx-features.cpp

r257867 - [X86] Support 'interrupt' attribute for x86

Author: abataev Date: Thu Jan 14 22:06:31 2016 New Revision: 257867 URL: http://llvm.org/viewvc/llvm-project?rev=257867=rev Log: [X86] Support 'interrupt' attribute for x86 This attribute may be attached to a function definition and instructs the backend to generate appropriate function

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

This revision was automatically updated to reflect the committed changes. Closed by commit rL257867: [X86] Support 'interrupt' attribute for x86 (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D15709?vs=44754=44961#toc Repository: rL LLVM

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On 14 January 2016 at 10:38, Weiming Zhao via cfe-commits < cfe-commits@lists.llvm.org> wrote: > weimingz added a comment. > > Hi Nick, > > Below is a reduced code: > t.c: > > static long double acoshl (long double __x) __asm__ ("" "acosh") ; // > this is from

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

weimingz updated this revision to Diff 44931. weimingz added a comment. if the new decl is not used, we can just give warnings http://reviews.llvm.org/D16171 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/Sema/asm-label.c Index: test/Sema/asm-label.c

Re: [PATCH] D16175: Introduce -fsanitize-stats flag.

pcc updated this revision to Diff 44936. pcc added a comment. - Switch to an alternative in-memory representation that avoids the need for linker magic http://reviews.llvm.org/D16175 Files: docs/SanitizerStats.rst docs/UsersManual.rst docs/index.rst include/clang/AST/ASTConsumer.h

Re: [PATCH] D15866: Warn when using `defined` in a macro definition.

Thanks for the review! I tweaked it a bit so that this only warns on function-type macros in -pedantic mode. That way, the warning can even be used in practice :-) On Thu, Jan 14, 2016 at 10:33 PM, Nico Weber wrote: > thakis updated this revision to Diff 44958. > thakis

r257865 - [CodeGen] Attach attributes to thread local wrapper function.

Author: ahatanak Date: Thu Jan 14 21:34:06 2016 New Revision: 257865 URL: http://llvm.org/viewvc/llvm-project?rev=257865=rev Log: [CodeGen] Attach attributes to thread local wrapper function. This commit is a follow-up to r251734, r251476, and r249735, which fixes a bug where function attributes

r257838 - Change the TSTiterator in Template Type Diffing.

Author: rtrieu Date: Thu Jan 14 17:30:12 2016 New Revision: 257838 URL: http://llvm.org/viewvc/llvm-project?rev=257838=rev Log: Change the TSTiterator in Template Type Diffing. Modify the TSTiterator to have two internal iterators, which will walk the provided sugared type and the desugared

Re: [PATCH] D16206: Make -Wdelete-non-virtual-dtor warn on explicit `a->~A()` dtor calls too.

dblaikie added a subscriber: dblaikie. dblaikie accepted this revision. dblaikie added a reviewer: dblaikie. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! http://reviews.llvm.org/D16206 ___

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

hokein marked 11 inline comments as done. Comment at: clang-tidy/ClangTidy.h:65 @@ -56,3 +64,3 @@ /// \c CheckOptions. If the corresponding key is not present, returns /// \p Default. template Makes sense. I just refer from `std::string get(StringRef

r257828 - [CMake] Move the install logic for libclang's headers into the libclang CMakelists

Author: cbieneman Date: Thu Jan 14 16:48:45 2016 New Revision: 257828 URL: http://llvm.org/viewvc/llvm-project?rev=257828=rev Log: [CMake] Move the install logic for libclang's headers into the libclang CMakelists This makes it so if you disable building libclang you won't install the headers

Re: [PATCH] D15858: Warn undeclared identifiers in CUDA kernel calls

jhen updated this revision to Diff 44933. jhen added a comment. - Add extra test for OK parameter pack http://reviews.llvm.org/D15858 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h lib/AST/Expr.cpp test/SemaCUDA/cxx11-kernel-call.cu test/SemaCUDA/kernel-call.cu Index:

Re: [PATCH] D15858: Warn undeclared identifiers in CUDA kernel calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL257839: [CUDA] Warn undeclared identifiers in CUDA kernel calls (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D15858?vs=44933=44938#toc Repository: rL LLVM

r257839 - [CUDA] Warn undeclared identifiers in CUDA kernel calls

Author: jlebar Date: Thu Jan 14 17:31:30 2016 New Revision: 257839 URL: http://llvm.org/viewvc/llvm-project?rev=257839=rev Log: [CUDA] Warn undeclared identifiers in CUDA kernel calls Value, type, and instantiation dependence were not being handled correctly for CUDAKernelCallExpr AST nodes. As

Re: [PATCH] D15858: Warn undeclared identifiers in CUDA kernel calls

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. LGTM, thanks! Comment at: test/SemaCUDA/cxx11-kernel-call.cu:8 @@ +7,3 @@ +template void k1Wrapper() { + void (*f)() = [] { k1<<>>(); }; // expected-error

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

I agree what you said about different code generated with clang and GCC generates. In this case, we should throw an error (err_late_asm_label). But in this example, there is no use of the function. They are just redundant declarations and there is no actual code generated. So I suggest we just

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On 14 January 2016 at 15:05, Zhao, Weiming wrote: > I agree what you said about different code generated with clang and GCC > generates. In this case, we should throw an error (err_late_asm_label). > > But in this example, there is no use of the function. They are just >

[PATCH] D16206: Make -Wdelete-non-virtual-dtor warn on explicit `a->~A()` dtor calls too.

thakis created this revision. thakis added a reviewer: rtrieu. thakis added a subscriber: cfe-commits. -Wdelete-non-virtual-dtor warns if A is a type with virtual functions but without virtual dtor has its constructor called via `delete a`. This makes the warning also fire if the dtor is called

r257853 - Make template type diffing use the new desguared iterator.

Author: rtrieu Date: Thu Jan 14 19:08:56 2016 New Revision: 257853 URL: http://llvm.org/viewvc/llvm-project?rev=257853=rev Log: Make template type diffing use the new desguared iterator. If available, use the canonical template argument to fill in information for template type diffing instead of

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

hokein updated this revision to Diff 44951. hokein added a comment. Address review comments. http://reviews.llvm.org/D16113 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/google/GlobalNamesInHeadersCheck.cpp clang-tidy/google/GlobalNamesInHeadersCheck.h

r257827 - [CMake] Set SVN_REVISION if CLANG_APPEND_VC_REV=On

Author: cbieneman Date: Thu Jan 14 16:45:12 2016 New Revision: 257827 URL: http://llvm.org/viewvc/llvm-project?rev=257827=rev Log: [CMake] Set SVN_REVISION if CLANG_APPEND_VC_REV=On This matches autoconf's ability to put clang revisions in the clang --version spew. Modified:

Re: [PATCH] D15858: Warn undeclared identifiers in CUDA kernel calls

jhen marked an inline comment as done. jhen added a comment. Thanks for the review rsmith! http://reviews.llvm.org/D15858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On Thu, Jan 14, 2016 at 03:05:26PM -0800, Zhao, Weiming via cfe-commits wrote: > I agree what you said about different code generated with clang and GCC > generates. In this case, we should throw an error (err_late_asm_label). > > But in this example, there is no use of the function. They are

Re: [PATCH] D16175: Introduce -fsanitize-stats flag.

pcc updated this revision to Diff 44945. pcc marked an inline comment as done. pcc added a comment. - Add note about win32 function name mangling - Stop using -whole-archive to link the stats runtime http://reviews.llvm.org/D16175 Files: docs/SanitizerStats.rst docs/UsersManual.rst

Re: [PATCH] D15866: Warn when using `defined` in a macro definition.

rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Lex/PPExpressions.cpp:104-105 @@ +103,4 @@ + // #else branch. Emit a warning about this undefined behavior. + if (beginLoc.isMacroID()) +PP.Diag(beginLoc,

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

rsmith added a comment. I think you missed this from my previous review: > This should be checked and diagnosed in Sema, not in CodeGen. Comment at: lib/CodeGen/CGDeclCXX.cpp:333-337 @@ +332,7 @@ + [](const CXXMethodDecl *Method) { return Method->isVirtual(); })) +

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pxli168 marked 2 inline comments as done. Comment at: lib/Sema/SemaChecking.cpp:378 @@ +377,3 @@ + } + + return false; Anastasia wrote: > I am asking about setArg and not setType! Oh, I just mistook your meaning. It seems we don't need that as we have to

r257869 - Add new diff modes to template type diffing.

Author: rtrieu Date: Thu Jan 14 23:01:53 2016 New Revision: 257869 URL: http://llvm.org/viewvc/llvm-project?rev=257869=rev Log: Add new diff modes to template type diffing. Remove an old assertion that does not hold. It is possible for a template argument to be a declaration in one

r257870 - Fixing more issues with template type diffing

Author: rtrieu Date: Thu Jan 14 23:48:38 2016 New Revision: 257870 URL: http://llvm.org/viewvc/llvm-project?rev=257870=rev Log: Fixing more issues with template type diffing 1) Print qualifiers for templates with zero arguments 2) Add a few more tests for the template type diffing refactoring.

r257871 - Fix a -Wparentheses warning in ASTDiagnostic.cpp.

Author: jyknight Date: Thu Jan 14 23:57:41 2016 New Revision: 257871 URL: http://llvm.org/viewvc/llvm-project?rev=257871=rev Log: Fix a -Wparentheses warning in ASTDiagnostic.cpp. Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp URL:

r257868 - PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration, by Denis Zobnin

Author: abataev Date: Thu Jan 14 22:36:32 2016 New Revision: 257868 URL: http://llvm.org/viewvc/llvm-project?rev=257868=rev Log: PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration, by Denis Zobnin Allow "mode" attribute to be applied to VarDecl, not ValueDecl

Re: [PATCH] D16112: PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL257868: PR26111: segmentation fault with __attribute__((mode(QI))) on function… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D16112?vs=44859=44963#toc Repository: rL LLVM

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pxli168 updated this revision to Diff 44965. pxli168 added a comment. Forget about get_pipe_num/max_packets builtin. http://reviews.llvm.org/D15914 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/DiagnosticSemaKinds.td lib/Basic/Builtins.cpp

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

ABataev added a comment. LG Repository: rL LLVM http://reviews.llvm.org/D15220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r257831 - Refactor template type diffing

Author: rtrieu Date: Thu Jan 14 16:56:39 2016 New Revision: 257831 URL: http://llvm.org/viewvc/llvm-project?rev=257831=rev Log: Refactor template type diffing 1) Instead of using pairs of From/To* fields, combine fields into a struct TemplateArgInfo and have two in each DiffNode. 2) Use default

RE: r256468 - On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

-G isn't handled there at the moment but ClangAs::AddMIPSTargetArgs() and Clang::AddMIPSTargetArgs() would be the right place to add it in the Linux toolchain when we add it. The cleanup I'm referring to is that someone hoisted the bulk of the code out of the big switch-statement in

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

echristo accepted this revision. echristo added a comment. This is terrible, but the only other option is fixing bind arch and inverting the graph which is a major rewrite to the driver. So, LGTM. -eric http://reviews.llvm.org/D16082 ___

Re: r257765 - [Hexagon] Change all builtins returning "bool" to return "int" instead

This could be tested - though I'm not sure if there's precedent for testing the types of builtins for other targets, for example. Might be worth checking? On Thu, Jan 14, 2016 at 6:26 AM, Krzysztof Parzyszek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kparzysz > Date: Thu Jan

Re: [PATCH] D15858: Warn undeclared identifiers in CUDA kernel calls

jhen added a comment. rsmith, I think the patch is ready to be committed. Please take a look if you have a moment. Thanks for your help. http://reviews.llvm.org/D15858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r257802 - Update for LLVM function name change.

Author: ruiu Date: Thu Jan 14 15:00:27 2016 New Revision: 257802 URL: http://llvm.org/viewvc/llvm-project?rev=257802=rev Log: Update for LLVM function name change. Modified: cfe/trunk/include/clang/AST/CharUnits.h cfe/trunk/include/clang/AST/StmtOpenMP.h

Re: [PATCH] D16112: PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! http://reviews.llvm.org/D16112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

aaron.ballman added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:216 @@ +215,3 @@ +/// HeaderFileExtensions. +bool endWithHeaderFileExtensions(llvm::StringRef FileName, + llvm::StringRef HeaderFileExtensions); alexfh

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25 @@ +24,3 @@ + SmallVector Classes; + Option.split(Classes, ","); + return std::vector(Classes.begin(),

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pxli168 added a comment. I think we'd better to ask about to add this in. The pipe type support actually have no use without builtins to read or write it. Comment at: lib/CodeGen/CGBuiltin.cpp:1981 @@ +1980,3 @@ + const char *Name = + (BuiltinID ==

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

alexfh added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:216 @@ +215,3 @@ +/// HeaderFileExtensions. +bool endWithHeaderFileExtensions(llvm::StringRef FileName, + llvm::StringRef HeaderFileExtensions); aaron.ballman

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

sbenza updated this revision to Diff 44889. sbenza marked 2 inline comments as done. sbenza added a comment. Added support for non 'char' chars. http://reviews.llvm.org/D16152 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/FasterStringFindCheck.cpp

r257809 - [CUDA] Invoke ptxas and fatbinary during compilation.

Author: jlebar Date: Thu Jan 14 15:41:27 2016 New Revision: 257809 URL: http://llvm.org/viewvc/llvm-project?rev=257809=rev Log: [CUDA] Invoke ptxas and fatbinary during compilation. Summary: Previously we compiled CUDA device code to PTX assembly and embedded that asm as text in our host binary.

Re: [PATCH] D16080: [CUDA] Add tests for compiling CUDA files with -E.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257807: [CUDA] Add tests for compiling CUDA files with -E. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16080?vs=44823=44920#toc Repository: rL LLVM

r257810 - [CUDA] Add test for compiling CUDA code with -S.

Author: jlebar Date: Thu Jan 14 15:41:31 2016 New Revision: 257810 URL: http://llvm.org/viewvc/llvm-project?rev=257810=rev Log: [CUDA] Add test for compiling CUDA code with -S. Reviewers: tra Subscribers: cfe-commits, jhen Differential Revision: http://reviews.llvm.org/D16081 Added:

r257808 - Don't build jobs for the same Action + ToolChain twice.

Author: jlebar Date: Thu Jan 14 15:41:21 2016 New Revision: 257808 URL: http://llvm.org/viewvc/llvm-project?rev=257808=rev Log: Don't build jobs for the same Action + ToolChain twice. Summary: Right now if the Action graph is a DAG and we encounter an action twice, we will run it twice. This

Re: [PATCH] D16081: [CUDA] Add test for compiling CUDA code with -S.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257810: [CUDA] Add test for compiling CUDA code with -S. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16081?vs=44542=44922#toc Repository: rL LLVM

  1   2   >