[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper updated this revision to Diff 218284. craig.topper added a comment. Add more tests. Clarify which platforms are affected in LangOptions.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 Files:

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

zsrkmyn created this revision. zsrkmyn added a reviewer: erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. Multi-versioned functions defined by cpu_dispatch and implemented with IFunc can not be called outside the translation units where they are defined due to

[PATCH] D67057: [AST][JSON] Generate parent context id from Decl* instead of DeclContext*

piscisaureus created this revision. piscisaureus added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because of multiple inheritance, a DeclContext pointer does not produce the same pointer representation as a Decl pointer that references the

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

xyb created this revision. xyb added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add bugprone-argument-comment option: IgnoreSingleArgument. When true, the check will ignore the single argument. Sometimes, it's not necessary to add comment to single

[PATCH] D67023: Diagnose use of ATOMIC_VAR_INIT

jfb added a comment. I refer you to http://wg21.link/p0883 I don’t think this diagnostic should be added to clang until p0883 is fully implemented, even just for C. Otherwise we leave users with no portable way to do the right thing without diagnostic. CHANGES SINCE LAST ACTION

[PATCH] D67052: Add reference type transformation builtins

zoecarver updated this revision to Diff 218276. zoecarver added a comment. - remove accedentally added file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67052/new/ https://reviews.llvm.org/D67052 Files: clang/include/clang/AST/Type.h

[PATCH] D67052: Add reference type transformation builtins

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: libcxx/test/libcxx/utilities/meta/stress_tests/stress_test_remove_reference.sh.cpp:13 +// variants listed in the RUN script. +// +// Impl Compile Time Object

[PATCH] D67052: Add reference type transformation builtins

zoecarver created this revision. zoecarver added reviewers: EricWF, eli.friedman, rsmith, craig.topper. Herald added subscribers: libcxx-commits, cfe-commits, jfb, christof. Herald added projects: clang, libc++. This patch adds builtin type traits to transform reference types. Specifically, it

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper added a comment. In D64672#1653847 , @RKSimon wrote: > Please can you extend the test coverage to cover more vector sizes and cpu > target features, not just avx512, and also add x86_64-scei-ps4 triple tests. > Maybe 32-bit tests as well?

[PATCH] D66866: [ASTImporter] At import of records re-order indirect fields too.

a_sidorin accepted this revision. a_sidorin added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66866/new/ https://reviews.llvm.org/D66866 ___ cfe-commits mailing list

[PATCH] D67023: Diagnose use of ATOMIC_VAR_INIT

aaron.ballman added a comment. In D67023#1653425 , @jfb wrote: > Is atomic initialization now correct in all modes (including C++) without > this macro? My understanding is yes, but I am not an expert in atomics. However, the diagnostic is currently

[PATCH] D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

Mordante updated this revision to Diff 218264. Mordante marked an inline comment as done. Mordante added a comment. As discussed on IRC no longer allow `\return` on a `typedef`'ed type. This is consistent with `\param`. - Reverts all prior changes in `lib/AST/Comment.cpp` - Adds extra tests in

[PATCH] D67048: [AMDGPU] Set default flat work group size to (1, 256) for HIP

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67048/new/ https://reviews.llvm.org/D67048 ___ cfe-commits mailing list

[PATCH] D67048: [AMDGPU] Set default flat work group size to (1, 256) for HIP

yaxunl updated this revision to Diff 218261. yaxunl added a comment. Herald added a subscriber: jvesely. add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67048/new/ https://reviews.llvm.org/D67048 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenCUDA/kernel-amdgcn.cu Index:

[PATCH] D67048: [AMDGPU] Set default flat work group size to (1, 256) for HIP

yaxunl created this revision. yaxunl added reviewers: arsenm, rampitec, b-sumner. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. https://reviews.llvm.org/D67048 Files: lib/CodeGen/TargetInfo.cpp Index: lib/CodeGen/TargetInfo.cpp

r370609 - Fix variable HasArrayDesignator set but not used warning. NFCI.

Author: rksimon Date: Sun Sep 1 06:10:08 2019 New Revision: 370609 URL: http://llvm.org/viewvc/llvm-project?rev=370609=rev Log: Fix variable HasArrayDesignator set but not used warning. NFCI. Modified: cfe/trunk/lib/Sema/SemaInit.cpp Modified: cfe/trunk/lib/Sema/SemaInit.cpp URL:

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11031-11032 // Do not diagnose macros. - if (Loc.isMacroID()) + if (Loc.isMacroID() || XorLHS.get()->getBeginLoc().isMacroID() || +

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 218258. xbolva00 added a comment. Fixed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

Mordante updated this revision to Diff 218256. Mordante added a comment. Changed the approach to use `addInstantiatedParametersToScope` as suggested by @rsmith. Since the function was `static` in another file I made it a member of `LocalInstantiationScope` and adjusted all callers. Minor

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. Please can you extend the test coverage to cover more vector sizes and cpu target features, not just avx512, and also add x86_64-scei-ps4 triple tests. Maybe 32-bit tests as well? Comment at: clang/include/clang/Basic/LangOptions.h:143 +/// (SVN