[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen added a comment. Hi @lenary This is normal behavior in current clang implementation, `-mcpu=?` flag does not interact with any flags, it just print out the all of ProcessorModel registered in backend. https://github.com/llvm/llvm-project/blob/master/clang/tools/driver/cc1_main.cpp#L213-L

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Oops, missed that I'd become a blocking reviewer for this (cos of requesting changes before). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D792

[clang] 8c1a79d - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-07-14T19:30:08-07:00 New Revision: 8c1a79dc12f3cc600e16153961cd8cc50ba2c33b URL: https://github.com/llvm/llvm-project/commit/8c1a79dc12f3cc600e16153961cd8cc50ba2c33b DIFF: https://github.com/llvm/llvm-project/commit/8c1a79dc12f3cc600e16153961cd8cc50ba2c33b.diff LO

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c1a79dc12f3: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.o

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2386 +CheckReg = Inst.getOperand(3).getReg(); } +if (DestReg == CheckReg) fpallares wrote: > fpallares wro

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek reopened this revision. phosek added a comment. This revision is now accepted and ready to land. I had to revert this change because it broke bots that don't have zlib installed. What I haven't realized is that the shadowed variable will only be accessible from the same file. I could move

[PATCH] D83845: [LTO/WPD] Remove special type test handling for -flto-visibility-public-std

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. As discussed in follow up comments on D71913 , the special case handling for -flto

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:189-190 +// or rvalue references. +// In case of an InstanceCall don't invalidate the this-region since +// it is fully handled in checkPreCall and checkPostCall. +const

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked an inline comment as done. tejohnson added inline comments. Herald added a reviewer: MaskRay. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" //

[clang] fec1f21 - [OpenMP] Emit remarks during GPU state machine optimization

Author: Johannes Doerfert Date: 2020-07-14T22:33:57-05:00 New Revision: fec1f2109f33c9a1a7650272b3bfb8f0f81f6a2b URL: https://github.com/llvm/llvm-project/commit/fec1f2109f33c9a1a7650272b3bfb8f0f81f6a2b DIFF: https://github.com/llvm/llvm-project/commit/fec1f2109f33c9a1a7650272b3bfb8f0f81f6a2b.d

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

This revision was automatically updated to reflect the committed changes. Closed by commit rGfec1f2109f33: [OpenMP] Emit remarks during GPU state machine optimization (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D83707?vs=277962&id=278059#toc Repository: rG LLVM

[clang] 7af287d - [OpenMP][IRBuilder] Support nested parallel regions

Author: Johannes Doerfert Date: 2020-07-14T22:39:06-05:00 New Revision: 7af287d0d921471f18b5c3054ce42381c0f973ed URL: https://github.com/llvm/llvm-project/commit/7af287d0d921471f18b5c3054ce42381c0f973ed DIFF: https://github.com/llvm/llvm-project/commit/7af287d0d921471f18b5c3054ce42381c0f973ed.d

[PATCH] D82722: [OpenMP][IRBuilder] Support nested parallel regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG7af287d0d921: [OpenMP][IRBuilder] Support nested parallel regions (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D82722?vs=273959&id=278061#toc Repository: rG LLVM Github

[clang] d87c92e - [OpenMP][FIX] Check only for deterministic part of a generated function name

Author: Johannes Doerfert Date: 2020-07-14T22:48:22-05:00 New Revision: d87c92e5a2eca620903ce53592ccbe4f8807abe1 URL: https://github.com/llvm/llvm-project/commit/d87c92e5a2eca620903ce53592ccbe4f8807abe1 DIFF: https://github.com/llvm/llvm-project/commit/d87c92e5a2eca620903ce53592ccbe4f8807abe1.d

[PATCH] D83788: Removed unused variable in clang

nadav added a comment. @modocache Thank you for the review. I updated the permissions of the diff. Sorry, for the trouble. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-commits mailing lis

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

plotfi updated this revision to Diff 278064. plotfi added a comment. Update for harbormaster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clan

[PATCH] D83652: Merge some of the PCH object support with modular codegen

llunak added a comment. In D83652#2147539 , @dblaikie wrote: > Not quite - it's intended to implement the D48426 > functionality using an implementation > strategy that is closer to modular code generation. Removing the

[PATCH] D71124: [RISCV] support clang driver to select cpu

asb added a comment. I've added some suggestions to clarify the code comments. I think before landing it would be good to address the crash Sam pointed out for an invalid -march, but otherwise I think this looks good to me (at least, it seems worth landing this and if further issues crop up we

[PATCH] D83819: [RISCV] Add error checking for extensions missing separating underscores

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83819/new/ https://reviews.llvm.org/D83819

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

NoQ added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() { FILE *F1 = tmpfile(); if (!F1) return;

[PATCH] D82575: [OpenMP] Additional OpenMP test without version string after upgrading to 5.0

saiislam updated this revision to Diff 278079. saiislam added a comment. Instead of adding additional test cases without version string, removed all occurrences of -fopenmp-version=50. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82575/new/ https

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 278081. kbobyrev added a comment. Rebase on top of parent revision, add more logging on the client side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files: clang

<    1   2   3