[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

h-vetinari added a comment. In D133853#3797598 , @RIscRIpt wrote: > I am afraid it would take me some effort to implement semantics of > `[[msvc::no_unique_address]]`, so I'd like to focus only on > `[[msvc::constexpr]]` in current patch. Just for cont

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1061 return false; + if (ClangNameParts.TargetPrefix.empty()) +return false; Does it mean that executable without prefix won't load implicit config file? For example, execution of

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

J-Camilleri added a comment. The premerge checks have failed but the only message I can see is `HTTP 28` in the log. I am not sure where to look for more information about the failure, Can someone please point me in the right direction? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added a comment. LGTM. Tested on one little-endian machine with our internal tests (I attached them in the issue https://github.com/llvm/llvm-project/issues/55961) for the priority of `-fconvert=` option and `CONVERT` argument in open statement and all passed. I didn't see the the `GFORT

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

animeshk-amd updated this revision to Diff 461827. animeshk-amd added a comment. Updated the LIT test for omp_thread_mem_alloc allocator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132855/new/ https://reviews.llvm.org/D132855 Files: clang/test

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 461822. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D133807: Update Unicode to 15.0

cor3ntin added a comment. @tahonermann ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

J-Camilleri created this revision. J-Camilleri added a reviewer: dexonsmith. Herald added subscribers: jeroen.dobbelaere, hiraditya. Herald added a project: All. J-Camilleri requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/avx512bf16-intrinsics-upgrade.ll:30 ; X64-NEXT:kmovd %edi, %k1 # encoding: [0xc5,0xfb,0x92,0xcf] -; X64-NEXT:vcvtne2ps2bf16 %zmm1, %zmm0, %zmm0 {%k1} {z} # encoding: [0x62,0xf2,0x7f,0xc9,0x72,0xc1] +; X64-

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:2185 +addRegisterClass(MVT::v32bf16, &X86::VR512RegClass); +setOperationAction(ISD::BUILD_VECTOR, MVT::bf16, Custom); +setOperationAction(ISD::BUILD_VECTOR, MVT::v8bf16, Custom); --

[PATCH] D132975: [CMake] Add clang-bolt target

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 ___

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

phosek added inline comments. Comment at: clang/CMakeLists.txt:912-926 +TABLEGEN +-DLLVM_TABLEGEN=${LLVM_RUNTIME_OUTPUT_INTDIR}/llvm-tblgen +-DCLANG_TABLEGEN=${LLVM_RUNTIME_OUTPUT_INTDIR}/clang-tblgen +LINKER -DCMAKE_LINKER=${LLVM_RUNTIME_OUTPUT_I

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. @sepavloff, I'd appreciate if you could take a look at the logic before I start updating tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list c

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added subscribers: StephenFan, pengfei. Herald added a reviewer: sscalpone. Herald added a project: All. mgorny requested review of this revision. Update the rules used to load default configuration files to permit mo

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134316/new/ https://reviews.llvm.org/D134316 ___ cfe

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

MyDeveloperDay added a comment. given that #57538 manifested itself as a incorrect format (no doubt because of incorrect token annotation), should we add a verifyFormat tests somewhere for the example from the github issue, (it just protects the formatting for being broken by some other change

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

MyDeveloperDay added a comment. In D134325#3804817 , @zzyyyl wrote: > What if `concept c = (bool)(...)` ? > > or `concept c = static_cast(...)` Aren't these handled elsewhere in the case (by the static_cast and l_paren rules)? but possibly worth a test

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek added a comment. In D88299#3804910 , @owenpan wrote: > @sstwcw thanks for pointing it out. See D134329 > . Thanks Owen, really appreciate this! And sorry for not getting to it yet myself :( Repository: rG LLV

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. For the record, I'm working on support for loading defaults from multiple files in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing l

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny updated this revision to Diff 461803. mgorny added a comment. Combining `--config` and default configuration files is now explicitly allowed. Adjust the code to load default configs before explicitly specified files. Update tests to cover combining `--config` with defaults. Update the do

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, we of all people have to dogfood this stuff.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.ll

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

serge-sans-paille added inline comments. Comment at: clang/test/Sema/unbounded-array-bounds.c:101 + char tail[1]; // addr16-note {{declared here}} addr32-note {{declared here}} +} fam1; + msebor wrote: > msebor wrote: > > There's a difference between the sizes

[PATCH] D88299: [clang-format] Add MacroUnexpander.

owenpan added subscribers: MyDeveloperDay, owenpan. owenpan added a comment. @sstwcw thanks for pointing it out. See D134329 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D882

[PATCH] D134284: [AIX] change "llvm-nm" to "env OBJECT_MODE=any llvm-nm" in clang/test for AIX OS

jhenderson accepted this revision. jhenderson added a comment. LGTM, with nit. Comment at: clang/test/lit.cfg.py:287 + +# llvm-nm tools support an environment variable "OBJECT_MODE" on AIX OS, which +# controls the kind of objects they will support. If there is no "OBJECT_MODE"

<    1   2   3