[libunwind] [libcxxabi] [clang] [mlir] [compiler-rt] [clang-tools-extra] [libcxx] [flang] [lldb] [llvm] [libc] [lld] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
https://github.com/DrTodd13 edited https://github.com/llvm/llvm-project/pull/72654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [libunwind] [libcxx] [libcxxabi] [libc] [clang] [lldb] [compiler-rt] [lld] [clang-tools-extra] [flang] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
@@ -310,7 +312,7 @@ void WriteDOTGraphToFile(Function &F, GraphT &&Graph, std::string GraphName = DOTGraphTraits::getGraphName(Graph); std::string Title = GraphName + " for '" + F.getName().str() + "' function"; - if (!EC) + if (!EC && (Filename.length() <= MAX_FILENAME_

[llvm] [clang-tools-extra] [libcxx] [flang] [clang] [libc] [mlir] [lldb] [compiler-rt] [libunwind] [lld] [libcxxabi] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
@@ -94,7 +96,7 @@ void printGraphForFunction(Function &F, GraphT Graph, StringRef Name, raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF); std::string GraphName = DOTGraphTraits::getGraphName(Graph); - if (!EC) + if (!EC && (Filename.length() <= MAX_FILENAME_L

[clang] [libc] [libcxxabi] [mlir] [llvm] [compiler-rt] [lldb] [flang] [lld] [libcxx] [clang-tools-extra] [libunwind] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
@@ -94,7 +96,7 @@ void printGraphForFunction(Function &F, GraphT Graph, StringRef Name, raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF); DrTodd13 wrote: I needed to work around this bug when I found it so in my local version I did a (Name.str() +

[compiler-rt] [mlir] [libc] [libcxxabi] [clang-tools-extra] [libunwind] [libcxx] [clang] [lld] [lldb] [flang] [llvm] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
@@ -280,7 +282,7 @@ class DOTGraphTraitsModulePrinterWrapperPass : public ModulePass { raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF); std::string Title = DOTGraphTraits::getGraphName(Graph); -if (!EC) +if (!EC && (Filename.length() <= MAX_FILENAM

[lldb] [clang] [llvm] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -0,0 +1,72 @@ +//===--- OpenACCKinds.h - OpenACC Enums -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc] [libcxxabi] [mlir] [llvm] [compiler-rt] [lldb] [flang] [lld] [libcxx] [clang-tools-extra] [libunwind] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Shahid Iqbal via cfe-commits
@@ -94,7 +96,7 @@ void printGraphForFunction(Function &F, GraphT Graph, StringRef Name, raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF); shahidiqbal13 wrote: @DrTodd13 , Will change the fix later , need to think https://github.com/llvm/llvm-proje

[clang] c601be9 - [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (#71945)

2023-11-17 Thread via cfe-commits
Author: Utkarsh Saxena Date: 2023-11-17T17:29:30+01:00 New Revision: c601be9c8400929f7b5c015a2bceae57e3aab550 URL: https://github.com/llvm/llvm-project/commit/c601be9c8400929f7b5c015a2bceae57e3aab550 DIFF: https://github.com/llvm/llvm-project/commit/c601be9c8400929f7b5c015a2bceae57e3aab550.diff

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/71945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/72661 >From 01fc81b37ad744a265f712b26fd6c3a85430c719 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 17 Nov 2023 06:29:35 -0800 Subject: [PATCH 1/3] [OpenACC] Implement initial parsing for Construct/Directive

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for `parallel` construct (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/72661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for `parallel` construct (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/72661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for `parallel` construct (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
erichkeane wrote: @alexey-bataev : Patch reduced to just parallel as requested. https://github.com/llvm/llvm-project/pull/72661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for `parallel` construct (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/72661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 032fddf0fbb03f0e3da86505aa81634a8a8e1cbc Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[llvm] [compiler-rt] [clang] [clang-tools-extra] [AMDGPU] Avoid hitting AMDGPUAsmPrinter related asserts for local functions at O0 (PR #72129)

2023-11-17 Thread Janek van Oirschot via cfe-commits
https://github.com/JanekvO updated https://github.com/llvm/llvm-project/pull/72129 >From 04b0856ae59ff367fd1b6736d49430648976cb25 Mon Sep 17 00:00:00 2001 From: Janek van Oirschot Date: Mon, 13 Nov 2023 07:38:15 -0800 Subject: [PATCH 1/2] [AMDGPU] Avoid hitting AMDGPUAsmPrinter related asserts

[llvm] [compiler-rt] [clang] [clang-tools-extra] [AMDGPU] Avoid hitting AMDGPUAsmPrinter related asserts for local functions at O0 (PR #72129)

2023-11-17 Thread Janek van Oirschot via cfe-commits
https://github.com/JanekvO updated https://github.com/llvm/llvm-project/pull/72129 >From 04b0856ae59ff367fd1b6736d49430648976cb25 Mon Sep 17 00:00:00 2001 From: Janek van Oirschot Date: Mon, 13 Nov 2023 07:38:15 -0800 Subject: [PATCH 1/3] [AMDGPU] Avoid hitting AMDGPUAsmPrinter related asserts

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2023-11-17 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70772 >From 5436d89e4ca3fbb1d53f27f8d5347f3eff100dd3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 31 Oct 2023 07:17:16 +0100 Subject: [PATC

[clang] 764c3af - [Tooling/Inclusion] Avoid narrowing conversions in macro expansion (#72664)

2023-11-17 Thread via cfe-commits
Author: Krzysztof Parzyszek Date: 2023-11-17T10:53:43-06:00 New Revision: 764c3afd43128f7ccddb070953c330b340ebe811 URL: https://github.com/llvm/llvm-project/commit/764c3afd43128f7ccddb070953c330b340ebe811 DIFF: https://github.com/llvm/llvm-project/commit/764c3afd43128f7ccddb070953c330b340ebe811

[clang] [Tooling/Inclusion] Avoid narrowing conversions in macro expansion (PR #72664)

2023-11-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/72664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesManager (PR #72389)

2023-11-17 Thread Nico Weber via cfe-commits
nico wrote: I was wondering what this is. It looks like we have documentation that describes it at https://clang.llvm.org/docs/APINotes.html (in case anyone else is wondering too). https://github.com/llvm/llvm-project/pull/72389 ___ cfe-commits maili

[clang] [clang codegen][regression] Add dso_local/hidden/etc. markings to VTT definitions and declarations (PR #72452)

2023-11-17 Thread via cfe-commits
bd1976bris wrote: > I'd prefer not to call setGVProperties() twice on the same variable; under > what conditions is the first call not sufficient? The test-case I posted is one such scenario: https://godbolt.org/z/s4rPffsrK. I suspect it may be related to whether there is a key function presen

[clang] aafad2d - [Clang] Warn on deprecated specializations used in system headers. (#70353)

2023-11-17 Thread via cfe-commits
Author: cor3ntin Date: 2023-11-17T18:16:34+01:00 New Revision: aafad2d214246bae4d53ce3178b11486ebc83890 URL: https://github.com/llvm/llvm-project/commit/aafad2d214246bae4d53ce3178b11486ebc83890 DIFF: https://github.com/llvm/llvm-project/commit/aafad2d214246bae4d53ce3178b11486ebc83890.diff LOG:

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-11-17 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/70353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6e31709 - [ClangModule] Fix decl-params-determinisim test after serialization change (#72572)

2023-11-17 Thread via cfe-commits
Author: Steven Wu Date: 2023-11-17T09:17:15-08:00 New Revision: 6e31709283478aec409af924d9e9c13843f13c42 URL: https://github.com/llvm/llvm-project/commit/6e31709283478aec409af924d9e9c13843f13c42 DIFF: https://github.com/llvm/llvm-project/commit/6e31709283478aec409af924d9e9c13843f13c42.diff LOG

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

2023-11-17 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan closed https://github.com/llvm/llvm-project/pull/72572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3ce5c04 - Replace getAs with castAs, dyn_cast with cast (NFC) (#72600)

2023-11-17 Thread via cfe-commits
Author: Mike Rice Date: 2023-11-17T09:22:33-08:00 New Revision: 3ce5c04ad0585e5e14ba9d2f594492a257edf7b1 URL: https://github.com/llvm/llvm-project/commit/3ce5c04ad0585e5e14ba9d2f594492a257edf7b1 DIFF: https://github.com/llvm/llvm-project/commit/3ce5c04ad0585e5e14ba9d2f594492a257edf7b1.diff LOG

[clang] [llvm] Replace getAs with castAs, dyn_cast with cast (NFC) (PR #72600)

2023-11-17 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/72600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [flang] [clang] [llvm] [clang-tools-extra] [libc] [libcxx] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Ping https://github.com/llvm/llvm-project/pull/71398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correct handling of negative and out-of-bounds indices (PR #71877)

2023-11-17 Thread Nick Desaulniers via cfe-commits
@@ -827,6 +827,165 @@ CodeGenFunction::evaluateOrEmitBuiltinObjectSize(const Expr *E, unsigned Type, return ConstantInt::get(ResType, ObjectSize, /*isSigned=*/true); } +llvm::Value * +CodeGenFunction::emitFlexibleArrayMemberSize(const Expr *E, unsigned Type, +

[clang] [Clang] Correct handling of negative and out-of-bounds indices (PR #71877)

2023-11-17 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/71877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Fix CSPGO clang pass manager test (PR #72681)

2023-11-17 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg created https://github.com/llvm/llvm-project/pull/72681 Fix a `CHECK-NOT` line in a cspgo clang test >From f548c66f5084e9ce57565b6acc6f6caae0f89a8a Mon Sep 17 00:00:00 2001 From: Ellis Hoag Date: Fri, 17 Nov 2023 09:40:34 -0800 Subject: [PATCH] [NFC] Fix CSPGO clang

[clang] [NFC] Fix CSPGO clang pass manager test (PR #72681)

2023-11-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ellis Hoag (ellishg) Changes Fix a `CHECK-NOT` line in a cspgo clang test --- Full diff: https://github.com/llvm/llvm-project/pull/72681.diff 1 Files Affected: - (modified) clang/test/CodeGen/cspgo-instrumentation_thinlto.c (+2-2) `

[clang] [NFC] Fix CSPGO clang pass manager test (PR #72681)

2023-11-17 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/72681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [flang] [clang-tools-extra] [llvm] [clang] [libc] [libcxx] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-17 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/71398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [clang-tools-extra] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -322,6 +322,73 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 7b0b07e4a9adc5229226addd2700588bc0985c59 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang] [-Wunsafe-buffer-usage] Add FixableGadget for AddAssign in UnspecifiedUntypedContext (PR #71862)

2023-11-17 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud updated https://github.com/llvm/llvm-project/pull/71862 >From 6636745d1c444747a33c91b366a730d81ca5db5a Mon Sep 17 00:00:00 2001 From: Rashmi Mudduluru Date: Wed, 1 Nov 2023 13:43:12 -0700 Subject: [PATCH 01/14] [-Wunsafe-buffer-usage][WIP] Fixable gadget for AddAssi

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 580ad92c5cbaa88d402b71436ec90b6de325b1d2 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang] [clang codegen][regression] Add dso_local/hidden/etc. markings to VTT definitions and declarations (PR #72452)

2023-11-17 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I mean, looking at the code, as far as I can tell, we always call GetAddrOfVTT immediately before EmitVTTDefinition, so setGVProperties() has already run, so running it again shouldn't do anything... unless somehow EmitVTTDefinition is overwriting the visibility, or setGVP

[clang] [clang-format] Fix crashes in AlignArrayOfStructures (PR #72520)

2023-11-17 Thread Emilia Kond via cfe-commits
https://github.com/rymiel approved this pull request. Thanks for doing this! There were probably dozens of duplicates of this same crash across multiple years, so this is great https://github.com/llvm/llvm-project/pull/72520 ___ cfe-commits mailing li

[clang] 64b6ef0 - [OpenACC] Implement initial parsing for `parallel` construct (#72661)

2023-11-17 Thread via cfe-commits
Author: Erich Keane Date: 2023-11-17T10:47:42-08:00 New Revision: 64b6ef02e263a8ee48bd91f8b06dd3945eb9be44 URL: https://github.com/llvm/llvm-project/commit/64b6ef02e263a8ee48bd91f8b06dd3945eb9be44 DIFF: https://github.com/llvm/llvm-project/commit/64b6ef02e263a8ee48bd91f8b06dd3945eb9be44.diff L

[llvm] [lldb] [clang] [OpenACC] Implement initial parsing for `parallel` construct (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/72661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [compiler-rt] [flang] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread via cfe-commits
@@ -322,6 +322,73 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[flang] [llvm] [clang-tools-extra] [clang] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -322,6 +322,77 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang-tools-extra] [llvm] [compiler-rt] [flang] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -322,6 +322,77 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] [Clang][Sema] Don't say "is declared here" for invalid template locations (PR #71264)

2023-11-17 Thread Justin Bogner via cfe-commits
bogner wrote: ping. https://github.com/llvm/llvm-project/pull/71264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang][Driver] Support -nodefaultlibs, -nostartfiles and -nostdlib (PR #72601)

2023-11-17 Thread Brad Smith via cfe-commits
brad0 wrote: Looking at this again I am not sure if ```CLOption, DXCOption``` should be specified or not. I noticed this in the previous commit for the Flang driver. https://github.com/llvm/llvm-project/pull/72601 ___ cfe-commits mailing list cfe-comm

[clang] [Clang] Fix finding instantiated decls for class template specializations during instantiation (PR #72346)

2023-11-17 Thread Yuxuan Chen via cfe-commits
@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -verify -fsyntax-only %s yuxuanchen1997 wrote: gotcha, will do. https://github.com/llvm/llvm-project/pull/72346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [Clang] Fix finding instantiated decls for class template specializations during instantiation (PR #72346)

2023-11-17 Thread Yuxuan Chen via cfe-commits
yuxuanchen1997 wrote: Thanks for the review, @erichkeane. I am wondering what you mean by this needs "release note"? https://github.com/llvm/llvm-project/pull/72346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [Clang] Fix finding instantiated decls for class template specializations during instantiation (PR #72346)

2023-11-17 Thread Erich Keane via cfe-commits
erichkeane wrote: > Thanks for the review, @erichkeane. I am wondering what you mean by this > needs "release note"? Ah, yes! See `docs/ReleaseNotes.rst`. For each new bug fix (and most patches!) we require an entry into our release notes document. https://github.com/llvm/llvm-project/pull/

[clang] 9bd5f80 - [OpenACC] Implement 'trivial' construct/directive parsing.

2023-11-17 Thread via cfe-commits
Author: erichkeane Date: 2023-11-17T11:26:22-08:00 New Revision: 9bd5f808ccacef0acc84529a0bdd22b448d06e4a URL: https://github.com/llvm/llvm-project/commit/9bd5f808ccacef0acc84529a0bdd22b448d06e4a DIFF: https://github.com/llvm/llvm-project/commit/9bd5f808ccacef0acc84529a0bdd22b448d06e4a.diff LO

[libc] [clang-tools-extra] [mlir] [lldb] [libcxx] [llvm] [compiler-rt] [flang] [clang] [lld] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-17 Thread Fabian Mora via cfe-commits
https://github.com/fabianmcg edited https://github.com/llvm/llvm-project/pull/71430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [mlir] [clang-tools-extra] [lld] [compiler-rt] [lldb] [llvm] [libc] [libcxx] [clang] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-17 Thread Fabian Mora via cfe-commits
https://github.com/fabianmcg edited https://github.com/llvm/llvm-project/pull/71430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/72692 This patch implements the compound construct parsing, which allows 'parallel loop', 'serial loop', and 'kernel loop' to act as their own constructs. Note that this doesn't end up making any changes to the tes

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes This patch implements the compound construct parsing, which allows 'parallel loop', 'serial loop', and 'kernel loop' to act as their own constructs. Note that this doesn't end up making any changes to the

[clang-tools-extra] [llvm] [compiler-rt] [flang] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread via cfe-commits
@@ -322,6 +322,77 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] [llvm] [compiler-rt] [clang-tools-extra] [flang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread via cfe-commits
@@ -322,6 +322,77 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang-tools-extra] [llvm] [compiler-rt] [flang] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -322,6 +322,81 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang-tools-extra] [flang] [llvm] [clang] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -0,0 +1,164 @@ +// RUN: %clang_cc1 -fsyntax-only -verify=expected,c-local -x c %s +// RUN: %clang_cc1 -fsyntax-only -verify=expected,cpp-local -pedantic -x c++ -std=c++11 %s + +void foo() { + int i; + int a[10], b[10]; + + [[clang::code_align(8)]] + for (i = 0; i < 10; ++i

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 76bb83ad49840ceb92be2db5bfe7849f5280d6d3 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [llvm] [compiler-rt] [flang] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread via cfe-commits
@@ -0,0 +1,164 @@ +// RUN: %clang_cc1 -fsyntax-only -verify=expected,c-local -x c %s +// RUN: %clang_cc1 -fsyntax-only -verify=expected,cpp-local -pedantic -x c++ -std=c++11 %s + +void foo() { + int i; + int a[10], b[10]; + + [[clang::code_align(8)]] + for (i = 0; i < 10; ++i

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From bd6a6d0bd766813c770b47115c48333ad7a992cd Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 144b2f579ef06e663cf233431d291a913b895074 76bb83ad49840ceb92be2db5bfe7849f5280d6d3 --

[clang] [AVR] make the AVR ABI Swift compatible (PR #72298)

2023-11-17 Thread John McCall via cfe-commits
rjmccall wrote: > @efriedma-quic Cool. So it sounds like it's worth parking this for now, until > Kuba's work #71986 is merged? > > @rjmccall I'm not 100% sure I understand? The existing code in AVR.cpp > handles the standard AVR ABI, which has a few simple rules based on GCC > behaviour. Her

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 225ca71650e880e9584fe2d49e03baba34690883 Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[llvm] [clang] [Offload] Initial support for registering offloading entries on COFF targets (PR #72697)

2023-11-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/72697 Summary: This patch provides the initial support to allow handling the new driver's offloading entries. Normally, the ELF target can emit varibles at C-identifier named sections and the linker will provide a point

[llvm] [clang] [Offload] Initial support for registering offloading entries on COFF targets (PR #72697)

2023-11-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: This patch provides the initial support to allow handling the new driver's offloading entries. Normally, the ELF target can emit varibles at C-identifier named sections and the linker will provide a p

[llvm] [clang-tools-extra] [clang] [compiler-rt] [flang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-17 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/70762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [llvm] [lldb] [clang-tools-extra] [libcxx] [libunwind] [mlir] [libc] [clang] [compiler-rt] [flang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table a

2023-11-17 Thread Mingming Liu via cfe-commits
@@ -453,11 +471,94 @@ Error InstrProfSymtab::create(Module &M, bool InLTO) { if (Error E = addFuncWithName(F, getPGOFuncName(F, InLTO))) return E; } + + SmallVector Types; + for (GlobalVariable &G : M.globals()) { +if (!G.hasName()) + continue; +Types

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -22,7 +22,9 @@ using namespace llvm; namespace { -// Translate single-token string representations to the OpenACC Directive Kind. +// This doesn't completely comprehend 'Compound Constructs' (as it just +// identifies the first token) just the first token of each. So +//

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/72692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -50,6 +52,35 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { if (DirKind == OpenACCDirectiveKind::Invalid) P.Diag(FirstTok, diag::err_acc_invalid_directive) << FirstTokSpelling; + // Combined Constructs allows parallel loop, serial loop, or kernels loo

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -22,7 +22,9 @@ using namespace llvm; namespace { -// Translate single-token string representations to the OpenACC Directive Kind. +// This doesn't completely comprehend 'Compound Constructs' (as it just +// identifies the first token) just the first token of each. So +//

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/72692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [clang-tidy] Improve performance of misc-const-correctness (PR #72705)

2023-11-17 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/72705 Replaced certain AST matchers in ExprMutationAnalyzer with a more direct utilization of AST classes. The primary bottleneck was identified in the canResolveToExpr AST matcher. Since this matcher was employed mu

[clang] [clang-tools-extra] [clang-tidy] Improve performance of misc-const-correctness (PR #72705)

2023-11-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Replaced certain AST matchers in ExprMutationAnalyzer with a more direct utilization of AST classes. The primary bottleneck was identified in the canResolveT

[compiler-rt] [mlir] [clang-tools-extra] [flang] [clang] [libc] [llvm] [libcxx] [lldb] [lld] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

2023-11-17 Thread Sang Ik Lee via cfe-commits
@@ -0,0 +1,31 @@ +//===- SPIRVToLLVMIRTranslation.cpp - Translate SPIRV to LLVM IR --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/72692 >From 33ca88871b48fcfb16bdf7fa636a9ecfa4f38e08 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 17 Nov 2023 11:34:43 -0800 Subject: [PATCH 1/2] [OpenACC] Implement compound construct parsing This patch im

[compiler-rt] [llvm] [clang-tools-extra] [clang] [sanitizer_symbolizer] Symbolizer Markup for linux (PR #66126)

2023-11-17 Thread Andres Villegas via cfe-commits
=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: https://github.com/avillega closed https://github.com/llvm/llvm-project/pull/66126 ___ cfe-commits mailing

[clang-tools-extra] 12bdbe2 - [clang-tidy][NFC][DOC] Add missing HICPP rule id's (#72553)

2023-11-17 Thread via cfe-commits
Author: Björn Svensson Date: 2023-11-17T22:37:42+01:00 New Revision: 12bdbe2792b53ee1253c508b44f24d43735e7de9 URL: https://github.com/llvm/llvm-project/commit/12bdbe2792b53ee1253c508b44f24d43735e7de9 DIFF: https://github.com/llvm/llvm-project/commit/12bdbe2792b53ee1253c508b44f24d43735e7de9.diff

[clang-tools-extra] [clang-tidy][NFC][DOC] Add missing HICPP rule id's (PR #72553)

2023-11-17 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Björn?= Svensson Message-ID: In-Reply-To: https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/72553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [llvm] [libcxx] [libc++] Allow running the test suite with optimizations (PR #68753)

2023-11-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 2a5035e7b1db4b77ec30426c988478a35b077b7b Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH] [libc++] Allow running the test suite with optimizations This pat

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -45,11 +47,36 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { P.ConsumeToken(); std::string FirstTokSpelling = P.getPreprocessor().getSpelling(FirstTok); - OpenACCDirectiveKind DirKind = GetOpenACCDirectiveKind(FirstTokSpelling); + OpenACCDirectiveKind

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/72692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -50,6 +52,35 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { if (DirKind == OpenACCDirectiveKind::Invalid) P.Diag(FirstTok, diag::err_acc_invalid_directive) << FirstTokSpelling; + // Combined Constructs allows parallel loop, serial loop, or kernels loo

[clang] 2402b14 - Fix python SyntaxWarnings in check-all output (#72538)

2023-11-17 Thread via cfe-commits
Author: Georgios Eleftheriou Date: 2023-11-17T16:40:21-05:00 New Revision: 2402b14046b9628b584c07789830d7ed481f7d74 URL: https://github.com/llvm/llvm-project/commit/2402b14046b9628b584c07789830d7ed481f7d74 DIFF: https://github.com/llvm/llvm-project/commit/2402b14046b9628b584c07789830d7ed481f7d7

[compiler-rt] [clang] [libcxx] [llvm] fix python SyntaxWarnings in check-all output (PR #72538)

2023-11-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/72538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve alternate snake case warnings (PR #71385)

2023-11-17 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: @jcmoyer Do you want this be merged as jcmo...@users.noreply.github.com ? If not then please disable privacy settings in GitHub or change author of commit. https://github.com/llvm/llvm-project/pull/71385 ___ cfe-commits mailing list cf

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -45,11 +47,36 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { P.ConsumeToken(); std::string FirstTokSpelling = P.getPreprocessor().getSpelling(FirstTok); - OpenACCDirectiveKind DirKind = GetOpenACCDirectiveKind(FirstTokSpelling); + OpenACCDirectiveKind

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -45,11 +47,36 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { P.ConsumeToken(); std::string FirstTokSpelling = P.getPreprocessor().getSpelling(FirstTok); - OpenACCDirectiveKind DirKind = GetOpenACCDirectiveKind(FirstTokSpelling); + OpenACCDirectiveKind

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/72692 >From 33ca88871b48fcfb16bdf7fa636a9ecfa4f38e08 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 17 Nov 2023 11:34:43 -0800 Subject: [PATCH 1/3] [OpenACC] Implement compound construct parsing This patch im

[llvm] [libcxx] [libunwind] [libc++] Allow running the test suite with optimizations (PR #68753)

2023-11-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 2a5035e7b1db4b77ec30426c988478a35b077b7b Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH 1/2] [libc++] Allow running the test suite with optimizations This

[clang] 6168337 - [OpenACC] Handle lack of construct/directive

2023-11-17 Thread via cfe-commits
Author: erichkeane Date: 2023-11-17T13:48:50-08:00 New Revision: 6168337640addcf137c780d83770bd5e6e06a8c2 URL: https://github.com/llvm/llvm-project/commit/6168337640addcf137c780d83770bd5e6e06a8c2 DIFF: https://github.com/llvm/llvm-project/commit/6168337640addcf137c780d83770bd5e6e06a8c2.diff LO

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -45,11 +47,36 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { P.ConsumeToken(); std::string FirstTokSpelling = P.getPreprocessor().getSpelling(FirstTok); - OpenACCDirectiveKind DirKind = GetOpenACCDirectiveKind(FirstTokSpelling); + OpenACCDirectiveKind

[libunwind] 0133e25 - [runtimes][NFC] Remove trailing whitespace

2023-11-17 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2023-11-17T16:50:49-05:00 New Revision: 0133e25d99df9468ec3d9b523f14733a4b5e7180 URL: https://github.com/llvm/llvm-project/commit/0133e25d99df9468ec3d9b523f14733a4b5e7180 DIFF: https://github.com/llvm/llvm-project/commit/0133e25d99df9468ec3d9b523f14733a4b5e7180.diff

[clang] [Clang] Fix finding instantiated decls for class template specializations during instantiation (PR #72346)

2023-11-17 Thread Bruno Cardoso Lopes via cfe-commits
bcardosolopes wrote: I'm not 100% confident here but the fix makes sense and seems good (nice testcase!). https://github.com/llvm/llvm-project/pull/72346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang-format] Fix crashes in AlignArrayOfStructures (PR #72520)

2023-11-17 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/72520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix crashes in AlignArrayOfStructures (PR #72520)

2023-11-17 Thread Owen Pan via cfe-commits
@@ -20709,6 +20709,18 @@ TEST_F(FormatTest, CatchExceptionReferenceBinding) { TEST_F(FormatTest, CatchAlignArrayOfStructuresRightAlignment) { auto Style = getLLVMStyle(); Style.AlignArrayOfStructures = FormatStyle::AIAS_Right; + + verifyNoCrash("f({\n" +"ta

[clang] [clang-format] Fix crashes in AlignArrayOfStructures (PR #72520)

2023-11-17 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/72520 >From efdf321e9447e8b3f1c27ccdf6da842107deb6dd Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 16 Nov 2023 06:36:41 -0800 Subject: [PATCH 1/4] [clang-format] Fix crashes in AlignArrayOfStructures Fixed #55493.

<    1   2   3   4   >