[clang-tools-extra] [clang-tidy] Ignore non-forwarded arguments if they are unnamed (PR #87832)

2024-04-08 Thread Danny Mösch via cfe-commits
https://github.com/SimplyDanny closed https://github.com/llvm/llvm-project/pull/87832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1950ebd - [ARM64EC] Fix compilation of intrin.h in ARM64EC mode. (#87717)

2024-04-08 Thread via cfe-commits
Author: Eli Friedman Date: 2024-04-08T15:03:34-07:00 New Revision: 1950ebd17bbf1f2ad2a3799cd5966412ccfee9c4 URL: https://github.com/llvm/llvm-project/commit/1950ebd17bbf1f2ad2a3799cd5966412ccfee9c4 DIFF: https://github.com/llvm/llvm-project/commit/1950ebd17bbf1f2ad2a3799cd5966412ccfee9c4.diff

[clang] [ARM64EC] Fix compilation of intrin.h in ARM64EC mode. (PR #87717)

2024-04-08 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/87717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][llvm] Remove "implicit-section-name" attribute (PR #87906)

2024-04-08 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I'd suggest adding bitcode upgrade if it isn't too hard (I don't think it should be?) Otherwise looks fine. https://github.com/llvm/llvm-project/pull/87906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: ok please paste here what ever looks like real failure from the patch buildbot does not sent me, as I am not on the blame list https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] 7ad481e - Revert "[AArch64] Add support for -ffixed-x30" (#88019)

2024-04-08 Thread via cfe-commits
Author: Eli Friedman Date: 2024-04-08T15:16:00-07:00 New Revision: 7ad481e76c9bee5b9895ebfa0fdb52f31cb7de77 URL: https://github.com/llvm/llvm-project/commit/7ad481e76c9bee5b9895ebfa0fdb52f31cb7de77 DIFF: https://github.com/llvm/llvm-project/commit/7ad481e76c9bee5b9895ebfa0fdb52f31cb7de77.diff

[clang] [llvm] Revert "[AArch64] Add support for -ffixed-x30" (PR #88019)

2024-04-08 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/88019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add support for scalable vectors in __builtin_reduce_* functions (PR #87750)

2024-04-08 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Given there isn't any target-independent way to construct such a type, it feels sort of redundant. (A user could easily implement this themselves.) But I can't think of a reason to avoid adding this. Please update documentation and add a release note. https://github.com

[clang] [Clang][CodeGen] Fix `CanSkipVTablePointerInitialization` for dynamic classes with a trivial anonymous union (PR #84651)

2024-04-08 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/84651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f94bbfe - [Clang][CodeGen] Fix `CanSkipVTablePointerInitialization` for dynamic classes with a trivial anonymous union (#84651)

2024-04-08 Thread via cfe-commits
Author: Max Winkler Date: 2024-04-08T15:24:08-07:00 New Revision: f94bbfed7cf08f60e20756dce8965d2c6ed70ea1 URL: https://github.com/llvm/llvm-project/commit/f94bbfed7cf08f60e20756dce8965d2c6ed70ea1 DIFF: https://github.com/llvm/llvm-project/commit/f94bbfed7cf08f60e20756dce8965d2c6ed70ea1.diff L

[clang] [Clang][CodeGen] Fix `CanSkipVTablePointerInitialization` for dynamic classes with a trivial anonymous union (PR #84651)

2024-04-08 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/84651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][llvm] Remove "implicit-section-name" attribute (PR #87906)

2024-04-08 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/87906 >From 7a9df42b4c4f4f1b02dc3158d24800f3d4b68d8f Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Sun, 7 Apr 2024 05:29:36 + Subject: [PATCH 1/2] [clang][llvm] Remove "implicit-section-name" attribute D334

[clang] [llvm] [clang][llvm] Remove "implicit-section-name" attribute (PR #87906)

2024-04-08 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: > I'd suggest adding bitcode upgrade if it isn't too hard (I don't think it > should be?) done https://github.com/llvm/llvm-project/pull/87906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [llvm] [clang][llvm] Remove "implicit-section-name" attribute (PR #87906)

2024-04-08 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/87906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-04-08 Thread Fangrui Song via cfe-commits
@@ -7238,10 +7238,15 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, Args.addOptInFlag(CmdArgs, options::OPT_frelaxed_template_template_args, options::OPT_fno_relaxed_template_template_args); - // -fsized-deallocation is off by default,

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-04-08 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/83774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-08 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/87866 >From 2847b8be2e4938c03aea57609842e2fee776d916 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Fri, 5 Apr 2024 21:51:37 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF-

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-08 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/87866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-08 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/87866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ccdebba - [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin

2024-04-08 Thread via cfe-commits
Author: Fangrui Song Date: 2024-04-08T16:51:34-07:00 New Revision: ccdebbae4d77d3efc236af92c22941de5d437e01 URL: https://github.com/llvm/llvm-project/commit/ccdebbae4d77d3efc236af92c22941de5d437e01 DIFF: https://github.com/llvm/llvm-project/commit/ccdebbae4d77d3efc236af92c22941de5d437e01.diff

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/88071 Summary: These entires are generic for offloading with the new driver now. Having the `omp` prefix was a historical artifact and is confusing when used for CUDA. This patch just renames them for now, future patche

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: These entires are generic for offloading with the new driver now. Having the `omp` prefix was a historical artifact and is confusing when used for CUDA. This patch just renames them for now, future pa

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1950ebd17bbf1f2ad2a3799cd5966412ccfee9c4 651ebdc8b9875bc336aed345d61df8a9395fd6d7 --

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-04-08 Thread Jun Wang via cfe-commits
jwanggit86 wrote: Added a testcase that has flat_atomic_swap, which is an atomic without return. https://github.com/llvm/llvm-project/pull/79236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [clang][c++20] Fix code coverage mapping crash with generalized NTTPs (PR #85837)

2024-04-08 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: @erichkeane, @cor3ntin, @Endilll, @efriedma-quic ping. https://github.com/llvm/llvm-project/pull/85837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/88071 >From e236a4351c198f261e544970d4355f749db11fd7 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 8 Apr 2024 19:10:37 -0500 Subject: [PATCH] [Offload][NFC] Remove `omp_` prefix from offloading entries Summar

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-04-08 Thread Craig Topper via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: not %clang_cc1 -triple riscv64-linux-gnu -target-feature +i -S -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORT-EXT +// RUN: not %clang_cc1 -triple riscv64 -target-feature +i -S -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-04-08 Thread Craig Topper via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: not %clang_cc1 -triple riscv64-linux-gnu -target-feature +i -S -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORT-EXT +// RUN: not %clang_cc1 -triple riscv64 -target-feature +i -S -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=

[clang] [llvm] [AMDGPU] Add cCang builtins for amdgcn s_ttrace intrinsics (PR #88076)

2024-04-08 Thread Corbin Robeck via cfe-commits
https://github.com/CRobeck created https://github.com/llvm/llvm-project/pull/88076 None >From 1e2cab61cbf46e5cc73d7ee6523dcce1a75c7549 Mon Sep 17 00:00:00 2001 From: Corbin Robeck Date: Mon, 8 Apr 2024 19:58:57 -0500 Subject: [PATCH] add clang builtins for amdgcn s_ttrace intrinsics --- clan

[clang] [llvm] [AMDGPU] Add Clang builtins for amdgcn s_ttrace intrinsics (PR #88076)

2024-04-08 Thread Corbin Robeck via cfe-commits
https://github.com/CRobeck edited https://github.com/llvm/llvm-project/pull/88076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add Clang builtins for amdgcn s_ttrace intrinsics (PR #88076)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Corbin Robeck (CRobeck) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/88076.diff 2 Files Affected: - (modified) clang/include/clang/Basic/BuiltinsAMDGPU.def (+2) - (modified) llvm/include/llvm/IR/IntrinsicsAMDGPU.td

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-04-08 Thread Craig Topper via cfe-commits
@@ -14156,6 +14157,84 @@ CodeGenFunction::EmitAArch64CpuSupports(ArrayRef FeaturesStrs) { return Result; } +llvm::SmallVector +CodeGenFunction::EmitRISCVExtSupports(ArrayRef FeaturesStrs) { + auto BaseExtReqs = llvm::RISCV::getBaseExtensionKey(FeaturesStrs); + auto IMACom

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-04-08 Thread Craig Topper via cfe-commits
@@ -14156,6 +14157,84 @@ CodeGenFunction::EmitAArch64CpuSupports(ArrayRef FeaturesStrs) { return Result; } +llvm::SmallVector +CodeGenFunction::EmitRISCVExtSupports(ArrayRef FeaturesStrs) { + auto BaseExtReqs = llvm::RISCV::getBaseExtensionKey(FeaturesStrs); + auto IMACom

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-04-08 Thread Craig Topper via cfe-commits
@@ -14156,6 +14157,84 @@ CodeGenFunction::EmitAArch64CpuSupports(ArrayRef FeaturesStrs) { return Result; } +llvm::SmallVector +CodeGenFunction::EmitRISCVExtSupports(ArrayRef FeaturesStrs) { + auto BaseExtReqs = llvm::RISCV::getBaseExtensionKey(FeaturesStrs); + auto IMACom

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-04-08 Thread Craig Topper via cfe-commits
@@ -14156,6 +14157,84 @@ CodeGenFunction::EmitAArch64CpuSupports(ArrayRef FeaturesStrs) { return Result; } +llvm::SmallVector +CodeGenFunction::EmitRISCVExtSupports(ArrayRef FeaturesStrs) { + auto BaseExtReqs = llvm::RISCV::getBaseExtensionKey(FeaturesStrs); + auto IMACom

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-04-08 Thread Jessica Clarke via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: not %clang_cc1 -triple riscv64-linux-gnu -target-feature +i -S -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORT-EXT +// RUN: not %clang_cc1 -triple riscv64 -target-feature +i -S -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-04-08 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 edited https://github.com/llvm/llvm-project/pull/85786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-04-08 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > > Still crash on > > ```c++ > > template constexpr auto x = F(); > > template constexpr int a() { return 1; } > > > > template > > struct A { > > using Func = decltype( > > [](T) { > > return x<[] constexpr { return a(); }>; > > // return x<[] constexpr {

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Shilei Tian via cfe-commits
shiltian wrote: How about `llvm.offload`? This might need broader discussion but I'm fine either way. https://github.com/llvm/llvm-project/pull/88071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [llvm] [AMDGPU] Add Clang builtins for amdgcn s_ttrace intrinsics (PR #88076)

2024-04-08 Thread Corbin Robeck via cfe-commits
CRobeck wrote: Probably want to add a test in: clang/test/CodeGenOpenCL/builtins-amdgcn-gfx12.cl as well. https://github.com/llvm/llvm-project/pull/88076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/88071 >From 24c3253093491d0fbe297bc10cba8552b7bef665 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 8 Apr 2024 19:10:37 -0500 Subject: [PATCH] [Offload][NFC] Remove `omp_` prefix from offloading entries Summar

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > How about `llvm.offload`? This might need broader discussion but I'm fine > either way. I don't think it's too important here since these are effectively internal variables. However in the future I want to combine `cuda_offload_entires` and friends into just `llvm_offload_ent

[clang] f7d9337 - [Sema][NFC] Cleanups after 843cc474f (#87996)

2024-04-08 Thread via cfe-commits
Author: Younan Zhang Date: 2024-04-09T09:53:58+08:00 New Revision: f7d93373969b2b757f5d5ef5e157dabe3bb9b0ae URL: https://github.com/llvm/llvm-project/commit/f7d93373969b2b757f5d5ef5e157dabe3bb9b0ae DIFF: https://github.com/llvm/llvm-project/commit/f7d93373969b2b757f5d5ef5e157dabe3bb9b0ae.diff

[clang] [Sema][NFC] Cleanups after 843cc474f (PR #87996)

2024-04-08 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/87996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/88071 >From 198e77ad14ff83d2ed9ea80a1dcecafa1b1336a0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 8 Apr 2024 19:10:37 -0500 Subject: [PATCH] [Offload][NFC] Remove `omp_` prefix from offloading entries Summar

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-04-08 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @jcsxky At the glance of the stacktrace, I suspect we probably need some mechanism of deferral codegen while instantiating the enclosing struct. Can you please file a separate issue? https://github.com/llvm/llvm-project/pull/82310 ___

[clang] [Clang] Reduce the size of Decl and classes derived from it (PR #87361)

2024-04-08 Thread Chuanqi Xu via cfe-commits
@@ -268,17 +268,34 @@ class alignas(8) Decl { /// } /// void A::f(); // SemanticDC == namespace 'A' ///// LexicalDC == global namespace - llvm::PointerUnion DeclCtx; + llvm::PointerIntPair< ChuanqiXu9 wrote: +1 for more comments. I

[clang] [llvm] [AMDGPU] Add Clang builtins for amdgcn s_ttrace intrinsics (PR #88076)

2024-04-08 Thread Corbin Robeck via cfe-commits
https://github.com/CRobeck updated https://github.com/llvm/llvm-project/pull/88076 >From 1e2cab61cbf46e5cc73d7ee6523dcce1a75c7549 Mon Sep 17 00:00:00 2001 From: Corbin Robeck Date: Mon, 8 Apr 2024 19:58:57 -0500 Subject: [PATCH 1/3] add clang builtins for amdgcn s_ttrace intrinsics --- clang/

[clang] [llvm] [mlir] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/88071 >From c94d444b4317706c7434853c0c3490826bdbc110 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 8 Apr 2024 19:10:37 -0500 Subject: [PATCH] [Offload][NFC] Remove `omp_` prefix from offloading entries Summar

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Haonan Yang via cfe-commits
@@ -0,0 +1,94 @@ +// RUN: %clang -x c++ -fsanitize=implicit-bitfield-conversion -target x86_64-linux -S -emit-llvm -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-BITFIELD-CONVERSION +// RUN: %clang -x c++ -fsanitize=implicit-integer-conversion -target x86_64-linux -S -emit

[clang] [openmp] Revert "[Libomp] Place generated OpenMP headers into build resource d… (PR #88083)

2024-04-08 Thread Pete Steinfeld via cfe-commits
https://github.com/psteinfeld created https://github.com/llvm/llvm-project/pull/88083 …irectory (#88007)" This reverts commit 8671429151d5e67d3f21a737809953ae8bdfbfde. This commit broke the flang build, so I'm reverting it. See the comments in merge request #88007 for more information. >Fro

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Haonan Yang via cfe-commits
https://github.com/haonanya edited https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] Revert "[Libomp] Place generated OpenMP headers into build resource d… (PR #88083)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pete Steinfeld (psteinfeld) Changes …irectory (#88007)" This reverts commit 8671429151d5e67d3f21a737809953ae8bdfbfde. This commit broke the flang build, so I'm reverting it. See the comments in merge request #88007 for more information.

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread Pete Steinfeld via cfe-commits
psteinfeld wrote: Hey, @jhuber. This change broke the flang build. When I revert the change, everything builds cleanly. So I reverted it in merge request After this change was added, I started getting messages like: ``` [4/205] Building CXX object projects/openmp/libomptarget/plugins-nex

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Haonan Yang via cfe-commits
https://github.com/haonanya edited https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Hey, @jhuber. This change broke the flang build. > > When I revert the change, everything builds cleanly. So I reverted it in > merge request #88083. > > After this change was added, I started getting messages like: > > ``` > [4/205] Building CXX object > projects/openmp/lib

[clang] 25e3d2b - Revert "[Libomp] Place generated OpenMP headers into build resource d… (#88083)

2024-04-08 Thread via cfe-commits
Author: Pete Steinfeld Date: 2024-04-08T20:20:27-07:00 New Revision: 25e3d2b0fc1e2b4df19d7f18fbdd04c154e1d0e8 URL: https://github.com/llvm/llvm-project/commit/25e3d2b0fc1e2b4df19d7f18fbdd04c154e1d0e8 DIFF: https://github.com/llvm/llvm-project/commit/25e3d2b0fc1e2b4df19d7f18fbdd04c154e1d0e8.diff

[clang] [openmp] Revert "[Libomp] Place generated OpenMP headers into build resource d… (PR #88083)

2024-04-08 Thread Pete Steinfeld via cfe-commits
https://github.com/psteinfeld closed https://github.com/llvm/llvm-project/pull/88083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Hey, @jhuber. This change broke the flang build. > > When I revert the change, everything builds cleanly. So I reverted it in > merge request #88083. > > After this change was added, I started getting messages like: > > ``` > [4/205] Building CXX object > projects/openmp/lib

[clang] [clang-format] instanceof is a keyword only in Java/JavaScript (PR #88085)

2024-04-08 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/88085 Fixes #87907. >From 0daef6caaac5d3779cda0d4cbbf9cd2514662b92 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 8 Apr 2024 20:29:26 -0700 Subject: [PATCH] [clang-format] instanceof is a keyword only in Java/Java

[clang] [clang-format] instanceof is a keyword only in Java/JavaScript (PR #88085)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #87907. --- Full diff: https://github.com/llvm/llvm-project/pull/88085.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+2-1) - (modified) clang/unittests/Format/TokenAnnot

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > So the error is caused by your `c++` not supporting `__has_feature` > presumably. However I have no clue why that would happen due to this patch. I > believe in a few days @jdoerfert will flip the switch and we won't even allow > `libomptarget` to be built without using the ru

[clang] [clang] Introduce `SemaSYCL` (PR #88086)

2024-04-08 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/88086 This patch moves SYCL-related `Sema` functions into new `SemaSYCL` class, following the recent example of OpenACC and HLSL. This is a part of the effort to split `Sema`. Additional context can be found in #82217

[clang] [clang] Introduce `SemaSYCL` (PR #88086)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch moves SYCL-related `Sema` functions into new `SemaSYCL` class, following the recent example of OpenACC and HLSL. This is a part of the effort to split `Sema`. Additional context can be found

[clang] [ASTMatchers] fix captureVars assertion failure on capturesVariables (PR #76619)

2024-04-08 Thread Ding Fei via cfe-commits
https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/76619 >From 0ca1a2b2573d1f89a1b4d13cd43628a46c1e5c98 Mon Sep 17 00:00:00 2001 From: dingfei Date: Sun, 31 Dec 2023 00:32:01 +0800 Subject: [PATCH] [ASTMatchers] fix captureVars assertion failure on capturesVariables

[clang] [ASTMatchers] fix captureVars assertion failure on capturesVariables (PR #76619)

2024-04-08 Thread Ding Fei via cfe-commits
danix800 wrote: > LGTM but please add a release note so users know about the bug fix. Release note added. https://github.com/llvm/llvm-project/pull/76619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] a30662f - Rework the printing of attributes (#87281)

2024-04-08 Thread via cfe-commits
Author: Vassil Vassilev Date: 2024-04-09T07:14:43+03:00 New Revision: a30662fc2acdd73ca1a9217716299a4676999fb4 URL: https://github.com/llvm/llvm-project/commit/a30662fc2acdd73ca1a9217716299a4676999fb4 DIFF: https://github.com/llvm/llvm-project/commit/a30662fc2acdd73ca1a9217716299a4676999fb4.dif

[clang] Rework the printing of attributes (PR #87281)

2024-04-08 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/87281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5c056b3 - [clang-format] Clean up unit tests from commit 13be0d4a34c4

2024-04-08 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-04-08T21:20:18-07:00 New Revision: 5c056b32350e834924356b1af78504d261d24e42 URL: https://github.com/llvm/llvm-project/commit/5c056b32350e834924356b1af78504d261d24e42 DIFF: https://github.com/llvm/llvm-project/commit/5c056b32350e834924356b1af78504d261d24e42.diff LOG:

[clang] [AST][RecoveryExpr] Fix a crash on c89/c90 invalid InitListExpr (#88008) (PR #88014)

2024-04-08 Thread Ding Fei via cfe-commits
https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/88014 >From fbd0780923d40b0d8290280731239a722a7af7a9 Mon Sep 17 00:00:00 2001 From: dingfei Date: Tue, 9 Apr 2024 00:26:03 +0800 Subject: [PATCH 1/2] [AST][RecoveryExpr] Fix a crash on c89/c90 invalid InitListExpr (#

[clang] 62e9257 - Revert "Rework the printing of attributes (#87281)"

2024-04-08 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2024-04-09T05:03:34Z New Revision: 62e92573d28d62ab7e6438ac34d513b07c51ce09 URL: https://github.com/llvm/llvm-project/commit/62e92573d28d62ab7e6438ac34d513b07c51ce09 DIFF: https://github.com/llvm/llvm-project/commit/62e92573d28d62ab7e6438ac34d513b07c51ce09.diff LO

[clang] d412047 - [clang][Interp] Fix "Initializing" zero-size arrays

2024-04-08 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-09T07:04:35+02:00 New Revision: d4120477130a5f9e472753068dcc627baddc44f6 URL: https://github.com/llvm/llvm-project/commit/d4120477130a5f9e472753068dcc627baddc44f6 DIFF: https://github.com/llvm/llvm-project/commit/d4120477130a5f9e472753068dcc627baddc44f6.diff LO

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-04-08 Thread Felix via cfe-commits
@@ -3369,6 +3369,59 @@ SDValue PPCTargetLowering::LowerGlobalTLSAddressAIX(SDValue Op, bool Is64Bit = Subtarget.isPPC64(); bool HasAIXSmallLocalExecTLS = Subtarget.hasAIXSmallLocalExecTLS(); TLSModel::Model Model = getTargetMachine().getTLSModel(GV); + // Initialize TLS

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-04-08 Thread Felix via cfe-commits
@@ -3369,6 +3369,59 @@ SDValue PPCTargetLowering::LowerGlobalTLSAddressAIX(SDValue Op, bool Is64Bit = Subtarget.isPPC64(); bool HasAIXSmallLocalExecTLS = Subtarget.hasAIXSmallLocalExecTLS(); TLSModel::Model Model = getTargetMachine().getTLSModel(GV); + // Initialize TLS

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-04-08 Thread Felix via cfe-commits
https://github.com/orcguru deleted https://github.com/llvm/llvm-project/pull/84132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c7db450 - [clang][NFC] Refactor `EvaluateBinaryTypeTrait` to accept `TypeSourceInfo`

2024-04-08 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-04-09T08:51:36+03:00 New Revision: c7db450e5c1a83ea768765dcdedfd50f3358d418 URL: https://github.com/llvm/llvm-project/commit/c7db450e5c1a83ea768765dcdedfd50f3358d418 DIFF: https://github.com/llvm/llvm-project/commit/c7db450e5c1a83ea768765dcdedfd50f3358d418.

[clang] [Clang] [C++26] Implement P2573R2: `= delete("should have a reason");` (PR #86526)

2024-04-08 Thread via cfe-commits
Sirraide wrote: > I wanted to make you aware of this new core issue > https://cplusplus.github.io/CWG/issues/2876.html (which i think we should > have tests for). Thanks So, as of now, this ```c++ using T = void (); using U = int; T a = delete ("hello"); U b = delete ("hello"), c, d = delete

[clang] [Clang] [C++26] Implement P2573R2: `= delete("should have a reason");` (PR #86526)

2024-04-08 Thread via cfe-commits
Sirraide wrote: I’ve also added a parser test for that as well just now. https://github.com/llvm/llvm-project/pull/86526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5d1f779 - [clang][Interp][NFC] Add Dump debug op

2024-04-08 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-09T07:55:36+02:00 New Revision: 5d1f779540517f47abb4927f4ded51cac94fd366 URL: https://github.com/llvm/llvm-project/commit/5d1f779540517f47abb4927f4ded51cac94fd366 DIFF: https://github.com/llvm/llvm-project/commit/5d1f779540517f47abb4927f4ded51cac94fd366.diff LO

[clang] acff0b0 - [clang][Interp][NFC] Improve Record debugging

2024-04-08 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-09T07:55:36+02:00 New Revision: acff0b03167f877f783d9386014e1ebc20db1c2f URL: https://github.com/llvm/llvm-project/commit/acff0b03167f877f783d9386014e1ebc20db1c2f DIFF: https://github.com/llvm/llvm-project/commit/acff0b03167f877f783d9386014e1ebc20db1c2f.diff LO

[clang] 11ba795 - [clang][Interp][NFC] Add sanity checks to This op

2024-04-08 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-09T07:55:37+02:00 New Revision: 11ba795565c231a95a7e34bb0e4dff099234c736 URL: https://github.com/llvm/llvm-project/commit/11ba795565c231a95a7e34bb0e4dff099234c736 DIFF: https://github.com/llvm/llvm-project/commit/11ba795565c231a95a7e34bb0e4dff099234c736.diff LO

[clang] [llvm] [InstCombine] Infer nsw/nuw for trunc (PR #87910)

2024-04-08 Thread Yingwei Zheng via cfe-commits
@@ -897,7 +897,20 @@ Instruction *InstCombinerImpl::visitTrunc(TruncInst &Trunc) { } } - return nullptr; + bool Changed = false; + if (!Trunc.hasNoSignedWrap() && + ComputeMaxSignificantBits(Src, /*Depth=*/0, &Trunc) <= DestWidth) { +Trunc.setHasNoSignedWrap

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-04-08 Thread Timm Baeder via cfe-commits
@@ -11444,9 +11444,12 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult &LHS, ExprResult &RHS, llvm::APSInt Right = RHSResult.Val.getInt(); if (Right.isNegative()) { -S.DiagRuntimeBehavior(Loc, RHS.get(), - S.PDiag(diag::warn_shift_neg

[clang] [clang-format] instanceof is a keyword only in Java/JavaScript (PR #88085)

2024-04-08 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/88085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Implement approved resolution for CWG2858 (PR #88042)

2024-04-08 Thread via cfe-commits
cor3ntin wrote: This needs a release note and a test in test/CXX/drs/dr28xx.cpp (and a rerun of www/make_cxx_dr_status ) https://github.com/llvm/llvm-project/pull/88042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [Clang] Refactor implementation of "Lifetime extension in range-based for loops" (PR #87930)

2024-04-08 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. Give @hubert-reinterpretcast a few days to possibly review, otherwise LGTM https://github.com/llvm/llvm-project/pull/87930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [polly] [clang-format] Correctly annotate braces in macros (PR #87953)

2024-04-08 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/87953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix FormatToken::isSimpleTypeSpecifier() (PR #85564)

2024-04-08 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/85564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [C++26] Implement P2573R2: `= delete("should have a reason");` (PR #86526)

2024-04-08 Thread via cfe-commits
cor3ntin wrote: Thanks for the new tests. did you see this comment? https://github.com/llvm/llvm-project/pull/86526#pullrequestreview-1976690810 https://github.com/llvm/llvm-project/pull/86526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

<    1   2   3   4