Just saw this. I'll take a look, and thanks for pointing it out...
On Fri, Aug 2, 2019 at 6:24 PM Artem Dergachev via Phabricator <
revi...@reviews.llvm.org> wrote:
> NoQ added a comment.
>
> Ugh, there seems to be one more forgotten buildbot with plugins problems:
> http://green.lab.llvm.org/gr
Author: dhinton
Date: Wed Jul 10 10:57:05 2019
New Revision: 365675
URL: http://llvm.org/viewvc/llvm-project?rev=365675&view=rev
Log:
Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the
Option class."
Previously reverted in 364141 due to buildbot breakage, and fixed here
Author: dhinton
Date: Wed Jul 10 10:57:05 2019
New Revision: 365675
URL: http://llvm.org/viewvc/llvm-project?rev=365675&view=rev
Log:
Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the
Option class."
Previously reverted in 364141 due to buildbot breakage, and fixed here
Author: dhinton
Date: Sun Jun 16 12:15:04 2019
New Revision: 363521
URL: http://llvm.org/viewvc/llvm-project?rev=363521&view=rev
Log:
[docs] Fix another bot error by setting highlight language of objc code-block
to objc instead of c++.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe
Author: dhinton
Date: Sun Jun 16 11:41:31 2019
New Revision: 363520
URL: http://llvm.org/viewvc/llvm-project?rev=363520&view=rev
Log:
[docs] Fix another bot warning by adding a blank line to separate the
`option::` command from the text below.
Modified:
clang-tools-extra/trunk/docs/clang-ti
Author: dhinton
Date: Sun Jun 16 10:57:37 2019
New Revision: 363518
URL: http://llvm.org/viewvc/llvm-project?rev=363518&view=rev
Log:
[docs] Fix a few problems with clang-tool docs to get the bots green again.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
clang-tools-extra/trunk
Author: dhinton
Date: Sat Jun 15 18:09:41 2019
New Revision: 363504
URL: http://llvm.org/viewvc/llvm-project?rev=363504&view=rev
Log:
Fix gcc-05.4 bot failures caused by in r363481 "[clangd] Index API and
implementations for relations"
Use std::make_tuple instead of initializer list to make gcc-
Author: dhinton
Date: Sat Jun 15 13:09:54 2019
New Revision: 363502
URL: http://llvm.org/viewvc/llvm-project?rev=363502&view=rev
Log:
Recommit r363298 "[lit] Disable test on darwin when building shared libs."
Was reverted in r363379 due to build breakage.
Thanks to Nico Weber for reverting the o
Author: dhinton
Date: Thu Jun 13 12:08:49 2019
New Revision: 363298
URL: http://llvm.org/viewvc/llvm-project?rev=363298&view=rev
Log:
[lit] Disable test on darwin when building shared libs.
Summary:
This test fails to link shared libraries because tries to run
a copied version of clang-check to s
Author: dhinton
Date: Tue Jun 4 15:07:40 2019
New Revision: 362555
URL: http://llvm.org/viewvc/llvm-project?rev=362555&view=rev
Log:
[Analysis] Only build Analysis plugins when CLANG_ENABLE_STATIC_ANALYZER is
enabled.
Fixes bug introduced in r362328.
Thanks to Nathan Chancellor for reporting t
Author: dhinton
Date: Sun Jun 2 10:56:26 2019
New Revision: 362334
URL: http://llvm.org/viewvc/llvm-project?rev=362334&view=rev
Log:
Fix bug in r362328 -- append to dependency list instead of overwrite it.
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
Author: dhinton
Date: Sun Jun 2 08:53:43 2019
New Revision: 362328
URL: http://llvm.org/viewvc/llvm-project?rev=362328&view=rev
Log:
[test] Fix plugin tests
Recommit of r361790 that was temporarily reverted in r361793 due to bot
breakage.
Summary:
The following changes were required to fix the
Author: dhinton
Date: Mon May 27 23:38:16 2019
New Revision: 361793
URL: http://llvm.org/viewvc/llvm-project?rev=361793&view=rev
Log:
Revert [test] Fix plugin tests
This reverts r361790 (git commit fe5eaab2b5b4523886bd63aebcfea8cfce586fa1)
It's causing buildbot breakage, so reverting while I inv
Author: dhinton
Date: Mon May 27 23:26:58 2019
New Revision: 361790
URL: http://llvm.org/viewvc/llvm-project?rev=361790&view=rev
Log:
[test] Fix plugin tests
Summary:
The following changes were required to fix these tests:
1) Change LLVM_ENABLE_PLUGINS to an option and move it to
llvm/CMakeLi
I've submitted a patch to fix this, https://reviews.llvm.org/D62445.
Without it, non of the bots can build/test any plugins.
On Fri, May 24, 2019 at 5:47 PM Akira Hatanaka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I reverted the patch in r361685 to make the bot green again.
>
> > On
Author: dhinton
Date: Fri May 24 12:21:21 2019
New Revision: 361663
URL: http://llvm.org/viewvc/llvm-project?rev=361663&view=rev
Log:
[cmake] Remove old unused version of FindZ3.cmake from clang [NFC]
Summary: This file was moved to llvm in D54978, r356929, but the old
file was never removed.
Re
Author: dhinton
Date: Tue May 21 18:01:11 2019
New Revision: 361344
URL: http://llvm.org/viewvc/llvm-project?rev=361344&view=rev
Log:
[clang-tidy] remove default header-filter for run-clang-tidy
Summary:
run-clang-tidy.py was enforcing '-header-filter' parameter with an
unfortunate default value
Author: dhinton
Date: Tue May 21 17:56:42 2019
New Revision: 361343
URL: http://llvm.org/viewvc/llvm-project?rev=361343&view=rev
Log:
[Docs] Increase Doxygen cache size
Summary:
When building Doxygen docs for llvm and clang, it helpfully prints a warning at
the end noting that the `LOOKUP_CACHE_S
Author: dhinton
Date: Wed May 15 10:47:51 2019
New Revision: 360788
URL: http://llvm.org/viewvc/llvm-project?rev=360788&view=rev
Log:
[clang-tidy] Recommit r360785 "modernize-loop-convert: impl const cast iter"
with correct attribution
Summary:
modernize-loop-convert was not detecting implicit c
Author: dhinton
Date: Wed May 15 10:36:54 2019
New Revision: 360787
URL: http://llvm.org/viewvc/llvm-project?rev=360787&view=rev
Log:
Revert [clang-tidy] modernize-loop-convert: impl const cast iter
This reverts r360785 (git commit 42d28be802fe5beab18bc1a27f89894c0a290d44)
Modified:
clang-to
Just wanted to note that this patch was contributed by Torbjörn Klatt, and
I failed to add the following line to the commit message:
Patch by Torbjörn Klatt!
Sorry about that Torbjörn.
On Wed, May 15, 2019 at 9:56 AM Don Hinton via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
&g
Author: dhinton
Date: Wed May 15 09:58:58 2019
New Revision: 360785
URL: http://llvm.org/viewvc/llvm-project?rev=360785&view=rev
Log:
[clang-tidy] modernize-loop-convert: impl const cast iter
Summary:
modernize-loop-convert was not detecting implicit casts to
const_iterator as convertible to rang
Author: dhinton
Date: Fri May 10 11:27:09 2019
New Revision: 360450
URL: http://llvm.org/viewvc/llvm-project?rev=360450&view=rev
Log:
[clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'
Summary:
Change the namespace for llvm checkers from 'llvm' to
'llvm_check', and mo
Author: dhinton
Date: Fri May 3 10:47:29 2019
New Revision: 359909
URL: http://llvm.org/viewvc/llvm-project?rev=359909&view=rev
Log:
[CommandLine] Change help output to prefix long options with `--` instead of
`-`. NFC . Part 3 of 5
Summary:
By default, `parseCommandLineOptions()` will accept e
Author: dhinton
Date: Wed Apr 24 14:25:57 2019
New Revision: 359142
URL: http://llvm.org/viewvc/llvm-project?rev=359142&view=rev
Log:
[clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals
Summary:
Looks at conditionals and finds cases of ``cast<>``, which will
assert rather th
Author: dhinton
Date: Mon Apr 15 10:18:10 2019
New Revision: 358428
URL: http://llvm.org/viewvc/llvm-project?rev=358428&view=rev
Log:
[CommandLineParser] Add DefaultOption flag
Summary: Add DefaultOption flag to CommandLineParser which provides a
default option or alias, but allows users to overr
Author: dhinton
Date: Sat Apr 13 09:55:28 2019
New Revision: 358337
URL: http://llvm.org/viewvc/llvm-project?rev=358337&view=rev
Log:
[CommandLineParser] Add DefaultOption flag
Summary: Add DefaultOption flag to CommandLineParser which provides a
default option or alias, but allows users to overr
Author: dhinton
Date: Mon Mar 18 23:14:14 2019
New Revision: 356441
URL: http://llvm.org/viewvc/llvm-project?rev=356441&view=rev
Log:
Refactor cast<>'s in if conditionals, which can only assert on failure.
Summary:
This patch refactors several instances of cast<> used in if
conditionals. Since c
Hi John:
I found this investigating the cast assert noted here:
http://lists.llvm.org/pipermail/cfe-dev/2019-March/061685.html
I subsequently did quick grep and found a number of cases in clang+llvm
(didn't find any in other projects) . I'm happy to fix these in mass,
i.e., s/cast/dyn_cast/, but
It looks like this change introduced a small bug; Specifically, the
following cast test:
- if (auto PT = dyn_cast(DestTy)) {
...
+ // If we're producing a pointer, this is easy.
+ if (auto destPtrTy = cast(destTy)) {
Since the cast can fail, shouldn't you prefer dyn_cast<>(), which can
re
Author: dhinton
Date: Sat Jan 27 11:31:44 2018
New Revision: 323601
URL: http://llvm.org/viewvc/llvm-project?rev=323601&view=rev
Log:
[cmake] [libunwind] LLVM_FOUND isn't always set, so just test if
llvm_setup_rpath() is available instead.
Modified:
libunwind/trunk/src/CMakeLists.txt
Modifie
Author: dhinton
Date: Sat Jan 27 11:18:04 2018
New Revision: 323600
URL: http://llvm.org/viewvc/llvm-project?rev=323600&view=rev
Log:
[cmake] [libcxxabi] LLVM_FOUND isn't always set, so just test if
llvm_setup_rpath() is available instead.
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modifie
Author: dhinton
Date: Sat Jan 27 10:55:30 2018
New Revision: 323599
URL: http://llvm.org/viewvc/llvm-project?rev=323599&view=rev
Log:
LLVM_FOUND isn't always set, so just test if llvm_setup_rpath() is
available instead.
Modified:
libcxx/trunk/lib/CMakeLists.txt
Modified: libcxx/trunk/lib/CMa
gt;>
>>>> That doesn't necessarily mean it's safe. Does anyone know why this
>>>> might have "worked"?
>>>>
>>>
>>> I'm not an expert, but llvm installs all of these cmake modules along
>>> side llvm-config, s
Author: dhinton
Date: Thu Jan 25 20:01:50 2018
New Revision: 323496
URL: http://llvm.org/viewvc/llvm-project?rev=323496&view=rev
Log:
[cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries.
Clang and llvm already use llvm_setup_rpath(), so this change will
help standarize rpath
Author: dhinton
Date: Thu Jan 25 19:41:58 2018
New Revision: 323495
URL: http://llvm.org/viewvc/llvm-project?rev=323495&view=rev
Log:
Reland:
[cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.
Clang and llvm already use llvm_setup_rpath(), so this change will
help standariz
Author: dhinton
Date: Thu Jan 25 17:34:51 2018
New Revision: 323492
URL: http://llvm.org/viewvc/llvm-project?rev=323492&view=rev
Log:
Reland: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.
Clang and llvm already use llvm_setup_rpath(), so this change will
help standarize r
modules along
>> side llvm-config, so if you find llvm-config, you find these modules.
>>
>> So, unless I'm missing something, it looks like AddLLVM.cmake is always
>> available.
>>
>>
>>>
>>> On Jan 25, 2018, at 11:02, Shoaib
g libc++ standalone (i.e. without any LLVM
>> repository or even its CMake modules), right? Some upstream users care a
>> lot about that use case (CC beanz and Duncan).
>>
>> *From: *cfe-commits on behalf of
>> Don Hinton via cfe-commits
>> *Reply-To: *Don Hinton
ository or even its CMake modules), right? Some upstream users care a
> lot about that use case (CC beanz and Duncan).
>
> *From: *cfe-commits on behalf of Don
> Hinton via cfe-commits
> *Reply-To: *Don Hinton
> *Date: *Thursday, January 25, 2018 at 10:15 AM
> *To: *"cfe
Ah, I think that's the issue.
local:/Users/dhinton/projects/llvm_project/libcxxabi $ cat .arcconfig
{
"repository.callsign" : "CXXA",
"conduit_uri" : "https://reviews.llvm.org/";
}
So, it should set repository to CXXA, not LLVM.
On Thu, Jan 25, 2018 at 11:25 AM, Ben Hamilton
wrote:
> Yes
Author: dhinton
Date: Thu Jan 25 11:22:23 2018
New Revision: 323459
URL: http://llvm.org/viewvc/llvm-project?rev=323459&view=rev
Log:
Revert [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding
shared libraries.
Shoaib Meenai pointed out this will break standalone builds when
Author: dhinton
Date: Thu Jan 25 11:18:51 2018
New Revision: 323458
URL: http://llvm.org/viewvc/llvm-project?rev=323458&view=rev
Log:
Revert [libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when
adding shared libraries.
Shoaib Meenai pointed out this will break standalone builds
Btw, I'm seeing other inconsistencies, e.g., I just committed
https://reviews.llvm.org/D42460 and herald ended up adding both cfe-commits
and llvm-commits to subscribers.
When I created it, I left subscribers blank, so herald added cfe-commits --
which seems to be correct.
Then, when I committed i
Author: dhinton
Date: Thu Jan 25 10:43:18 2018
New Revision: 323455
URL: http://llvm.org/viewvc/llvm-project?rev=323455&view=rev
Log:
[cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.
Clang and llvm already use llvm_setup_rpath(), so this change will
help standarize rpath
Author: dhinton
Date: Thu Jan 25 10:13:26 2018
New Revision: 323453
URL: http://llvm.org/viewvc/llvm-project?rev=323453&view=rev
Log:
[cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.
Clang and llvm already use llvm_setup_rpath(), so this change will
help standarize rpath usa
Thanks Ben...
On Thu, Jan 25, 2018 at 9:53 AM, Ben Hamilton
wrote:
> Ah, I see from http://bcain-llvm.readthedocs.io/projects/
> libunwind/en/latest/ that libunwind review discussion does take place on
> cfe-commits.
>
> Added. Sorry about not doing that earlier!
>
> Ben
>
> On Thu, Jan 25, 2018
Currently, herald doesn't subscribe libunwind to any group. Should it be
added to cfe-commits?
https://reviews.llvm.org/H268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dhinton
Date: Mon Jan 22 19:30:23 2018
New Revision: 323171
URL: http://llvm.org/viewvc/llvm-project?rev=323171&view=rev
Log:
[cmake] Always respect existing CMAKE_REQUIRED_FLAGS when adding additional
ones.
* Previously part of https://reviews.llvm.org/D41622.
Modified:
libcxx/trun
Author: dhinton
Date: Mon Jan 22 11:41:05 2018
New Revision: 323145
URL: http://llvm.org/viewvc/llvm-project?rev=323145&view=rev
Log:
[cmake] [libcxxabi] Fix find_path() problems when cross compiling
When CMAKE_SYSROOT or CMAKE_FIND_ROOT_PATH is set, cmake
recommends setting CMAKE_FIND_ROOT_PATH_
Author: dhinton
Date: Mon Jan 22 11:26:38 2018
New Revision: 323143
URL: http://llvm.org/viewvc/llvm-project?rev=323143&view=rev
Log:
[cmake] [libcxx] Fix find_path() problems when cross compiling.
When CMAKE_SYSROOT or CMAKE_FIND_ROOT_PATH is set, cmake
recommends setting CMAKE_FIND_ROOT_PATH_MO
Author: dhinton
Date: Mon Jan 22 11:15:06 2018
New Revision: 323141
URL: http://llvm.org/viewvc/llvm-project?rev=323141&view=rev
Log:
[cmake] [libunwind] Fix find_path() problems when cross compiling
When CMAKE_SYSROOT or CMAKE_FIND_ROOT_PATH is set, cmake
recommends setting CMAKE_FIND_ROOT_PATH_
Author: dhinton
Date: Fri Jan 19 10:31:12 2018
New Revision: 322977
URL: http://llvm.org/viewvc/llvm-project?rev=322977&view=rev
Log:
[cmake] Also pass CMAKE_ASM_COMPILER_ID to next stage when bootstrapping
Summary:
When setting CMAKE_ASM_COMPILER=clang, we also need to set
CMAKE_ASM_COMPILER_ID=
Author: dhinton
Date: Thu Jan 18 10:29:36 2018
New Revision: 322870
URL: http://llvm.org/viewvc/llvm-project?rev=322870&view=rev
Log:
[cmake] [libcxxabi] Don't print warning when tests are disabled.
Summary:
Don't print, possibly erroneous, warning if
LIBCXXABI_INCLUDE_TESTS is false.
This patch
Author: dhinton
Date: Tue Jan 9 17:00:28 2018
New Revision: 322147
URL: http://llvm.org/viewvc/llvm-project?rev=322147&view=rev
Log:
[cmake] Delete redundant install command for clang-refactor.
Summary: Install targets for clang tools are controlled by
CLANG_BUILD_TOOLS, and when OFF, cmake issu
On Mon, Dec 25, 2017 at 1:10 PM, whitequark
wrote:
> On 2017-12-25 20:54, Don Hinton wrote:
>
>> On Mon, Dec 25, 2017 at 12:43 PM, whitequark
>> wrote:
>>
>>> On 2017-12-25 20:32, Don Hinton wrote:
>>>
It should also assert for non-integral types.
>>>
>>> True, but I do not know enough
On Mon, Dec 25, 2017 at 12:43 PM, whitequark
wrote:
> On 2017-12-25 20:32, Don Hinton wrote:
>
>> While beauty is in the eye of the beholder, I'm not sure introducing a
>> new template function in a header that's only used in that header is a
>> good idea. Every file that includes DwarfParser.hp
While beauty is in the eye of the beholder, I'm not sure introducing a new
template function in a header that's only used in that header is a good
idea. Every file that includes DwarfParser.hpp is going to get that
template function -- and someone may try to use it someday.
However, if you did wa
Here's the patch I applied locally.
hth...
don
diff --git a/src/DwarfParser.hpp b/src/DwarfParser.hpp
index 518101e..ac4f1c4 100644
--- a/src/DwarfParser.hpp
+++ b/src/DwarfParser.hpp
@@ -540,7 +540,7 @@ bool CFI_Parser::parseInstructions(A &addressSpace,
pint_t instructions,
results->cfa
On Mon, Dec 25, 2017 at 11:09 AM, whitequark
wrote:
> On 2017-12-25 19:04, Don Hinton wrote:
>
>> Hi:
>>
>> This change breaks in a local debug build, e.g.,:
>>
>> /Users/dhinton/projects/llvm_project/libunwind/src/DwarfPars
>> er.hpp:559:28:
>> error: no member named 'numeric_limits' in namespac
Hi:
This change breaks in a local debug build, e.g.,:
/Users/dhinton/projects/llvm_project/libunwind/src/DwarfParser.hpp:559:28:
error: no member named 'numeric_limits' in namespace 'std'
assert(length < std::numeric_limits::max() && "pointer
overflow");
~^
thanks
Author: dhinton
Date: Sun Dec 24 21:33:42 2017
New Revision: 321435
URL: http://llvm.org/viewvc/llvm-project?rev=321435&view=rev
Log:
[libcxx] Suppress unused warning on apple.
Summary:
This warning is already suppressed on non-apple platforms, so
this change just suppresses it on apple as well.
Author: dhinton
Date: Thu Dec 14 14:12:46 2017
New Revision: 320751
URL: http://llvm.org/viewvc/llvm-project?rev=320751&view=rev
Log:
[debuginfo] Remove temporary FIXME.
Summary:
Now that r320495, "[debuginfo-tests] Support moving
debuginfo-tests to llvm/projects," has landed, remove temporary FI
Author: dhinton
Date: Tue Dec 12 11:47:40 2017
New Revision: 320519
URL: http://llvm.org/viewvc/llvm-project?rev=320519&view=rev
Log:
[cmake] Follow-up to rL320494.
EXISTS requires full paths.
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
http://llvm.
Author: dhinton
Date: Tue Dec 12 08:48:35 2017
New Revision: 320494
URL: http://llvm.org/viewvc/llvm-project?rev=320494&view=rev
Log:
[debuginfo-tests] Add support for moving debuginfo-tests from clang/test to
llvm/projects or monorepo.
Summary:
The new version of debuginfo-tests will have it's
On Mon, Nov 20, 2017 at 5:20 PM, Zachary Turner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: zturner
> Date: Mon Nov 20 17:20:28 2017
> New Revision: 318722
>
> URL: http://llvm.org/viewvc/llvm-project?rev=318722&view=rev
> Log:
> Re-revert "Refactor debuginfo-tests."
>
> This is
Hi Zachery:
I'm seeing a breakage when cross-compiling and including libcxx in the
runtimes directory.
The problem is that `include(AddLLVM)`, guarded by LIBCXX_INCLUDE_TESTS, comes
after your change to call `configure_lit_site_cfg`.
I've fixed this locally by adding `include(AddLLVM)` to the t
Author: dhinton
Date: Fri Oct 27 10:02:33 2017
New Revision: 316773
URL: http://llvm.org/viewvc/llvm-project?rev=316773&view=rev
Log:
New lldb python module for managing diagnostic breakpoints
Summary:
Can be used to set breakpoints for either the diagnostics actually
emitted for the current comp
On Thu, Oct 26, 2017 at 5:44 PM, Zachary Turner wrote:
>
>
> On Thu, Oct 26, 2017 at 3:18 PM Don Hinton wrote:
>
>> On Thu, Oct 26, 2017 at 2:48 PM, Zachary Turner
>> wrote:
>>
>>> Seems fine, it would be nice if the workflow could be improved a little
>>> bit so that all you have to do is say
On Thu, Oct 26, 2017 at 2:48 PM, Zachary Turner wrote:
> Seems fine, it would be nice if the workflow could be improved a little
> bit so that all you have to do is say `clangdiag break
> —error=“-Wcovered-switch”` or something . I think that gives the most
> intuitive usage for people, even it’s
On Thu, Oct 26, 2017 at 3:00 PM, Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg added a comment.
>
> Each lldb.SBValue has accessors for the stuff in an execution context:
>
> ``
>
> lldb::SBTarget GetTarget();
> lldb::SBProcess GetProcess();
> lldb::SBThread GetT
Author: dhinton
Date: Thu Aug 3 09:13:13 2017
New Revision: 309955
URL: http://llvm.org/viewvc/llvm-project?rev=309955&view=rev
Log:
[diagtool] Add ability to pass in the id and return the name for a
particular diagnostic.
Differential Revision: https://reviews.llvm.org/D36252
Modified:
cfe
Author: dhinton
Date: Thu Jun 29 20:03:28 2017
New Revision: 306783
URL: http://llvm.org/viewvc/llvm-project?rev=306783&view=rev
Log:
Remove test commit.
Modified:
cfe/trunk/README.txt
Modified: cfe/trunk/README.txt
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/README.txt?rev=306783&r1
Author: dhinton
Date: Thu Jun 29 19:57:34 2017
New Revision: 306782
URL: http://llvm.org/viewvc/llvm-project?rev=306782&view=rev
Log:
Test Commit
Modified:
cfe/trunk/README.txt
Modified: cfe/trunk/README.txt
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/README.txt?rev=306782&r1=306781&
On Sat, Jun 10, 2017 at 8:55 PM John McCall via Phabricator <
revi...@reviews.llvm.org> wrote:
> rjmccall accepted this revision.
> rjmccall added a comment.
> This revision is now accepted and ready to land.
>
> Thanks, looks great.
Great, thanks.
>
>
> If you're going to be submitting multipl
Thanks Alex...
On Fri, Jun 9, 2017 at 1:02 AM, Alexander Kornienko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Fixes committed in r305024 and r305057.
>
> On Fri, Jun 9, 2017 at 12:07 AM, Alexander Kornienko
> wrote:
>
>> It looks like the buildbots have exceptions turned off by defau
Minor nit: your diff is much bigger than it should have been due to
whitespace changes.
On Sun, Feb 5, 2017 at 9:21 AM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Sun Feb 5 11:21:52 2017
> New Revision: 294127
>
> URL: http://llvm.org/view
hintonda added a comment.
The comment says to rebuild TypeSourceInfo, but isn't that what this does?
if (TSInfo->getType() != FD->getType())
Updated = getFunctionTypeWithExceptionSpec(*this, TSInfo->getType(), ESI);
TSInfo->overrideType(Updated);
If so, could you fix this by either remov
hintonda added a comment.
Thanks Aaron. If you could commit for me, I'd appreciate it. Thanks again...
http://reviews.llvm.org/D20687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
hintonda updated this revision to Diff 59794.
hintonda added a comment.
Update matcher to use functionProtoType instead of functionType.
http://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptC
hintonda updated this revision to Diff 59747.
hintonda added a comment.
Use FunctionProtoType instead of auto for clarity.
http://reviews.llvm.org/D20687
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unit
hintonda updated this revision to Diff 59726.
hintonda added a comment.
Update narrowing matchers, isNoThrow and hasDynamicExceptionSpec, to
work with both functionDecl and functionProtoType matchers. Update
tests and regenerate documentation.
Since FunctionDecl and FunctionProtoType are not pol
hintonda added a comment.
This marcher was recently added, and has never been in a release.
Specifically, it was added by me in support of a checker that has now been
abandoned in lieu of a better approach -- the new approach requires this change
-- so I doubt it would break anything.
That sa
hintonda added a comment.
Ping...
http://reviews.llvm.org/D20687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda abandoned this revision.
hintonda added a comment.
This revision is OBE.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ Sourc
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ Sourc
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ Sourc
hintonda added a comment.
Please see http://reviews.llvm.org/D20693 for an alternative approach.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda created this revision.
hintonda added reviewers: alexfh, aaron.ballman.
hintonda added subscribers: etienneb, Eugene.Zelenko, cfe-commits.
[clang-tidy] New checker to replace dynamic exception
specifications
This is an alternative to D18575 which relied on reparsing the decl to
find the
hintonda created this revision.
hintonda added a reviewer: aaron.ballman.
hintonda added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Update hasDynamicExceptionSpec to use functionType instead of
functionDecl.
http://reviews.llvm.org/D20687
Files:
docs/LibASTMatchersReference.
hintonda added a comment.
Actually, this will never work correctly -- in fact, raw lexing will always be
problematic. Consider:
void foo()
#if !__has_feature(cxx_noexcept)
throw(std::bad_alloc)
#endif
{}
In this case we *could* figure out if __has_feature(cxx_noexcept) evaluated to
true o
hintonda added a comment.
In http://reviews.llvm.org/D18575#435388, @alexfh wrote:
> Let's wait for http://reviews.llvm.org/D20428
No worries.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
hintonda updated this revision to Diff 58151.
hintonda added a comment.
Fixed matcher -- added 'unless(isImplicit())'. Thanks to Aaron Ballman for the
suggestion.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang
hintonda added a comment.
Sure that sounds good to me. However, I would like to learn how to write
better ASTMatchers.
In any case, this has been a great learning experience.
http://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits
hintonda added a comment.
Btw, this version can successfully check libcxx.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 57811.
hintonda added a comment.
Adjust matcher, add better error checking, and additional test cases.
We can now parse all dynamic exception specifications, but haven't
been able to develop a matcher that will find the following function
declaration without
hintonda added a comment.
I can already catch all of these cases, but I can't catch this one, will this
catch it too?
void g(void (*fp)(void) throw()) throw();
^^^
http://reviews.llvm.org/D20428
___
cfe-commits mail
hintonda updated this revision to Diff 57686.
hintonda added a comment.
Improved matcher logic and add better range handling to try to deal
with multiple asserts concerning bad ranges when running checker again
real code, e.g., libcxx.
Even so, still seeing some asserts in Lexer::getSourceLocatio
hintonda updated this revision to Diff 57555.
hintonda added a comment.
- Added another test.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoexcept
1 - 100 of 249 matches
Mail list logo
