eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87495
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
clang/lib/Tooling
eduucaldas updated this revision to Diff 291152.
eduucaldas added a comment.
Remove unused include
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87495/new/
https://reviews.llvm.org/D87495
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
c
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
According to LLVM coding standards:
https://llvm.org/docs/CodingStandards.html#name-types-functions-variab
eduucaldas updated this revision to Diff 291190.
eduucaldas marked 5 inline comments as done.
eduucaldas added a comment.
Answer inline comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87495/new/
https://reviews.llvm.org/D87495
Files:
clan
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:51
+ return createLeaf(A, tok::getKeywordSpelling(K), K);
+}
+
gribozavr2 wrote:
> Could we make a combined function that does not require the user to make a
> distinction betw
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4c14ee61b737: [SyntaxTree] Rename functions to start with
verb (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
eduucaldas updated this revision to Diff 291229.
eduucaldas marked an inline comment as done.
eduucaldas added a comment.
`createPunctuation`, `createKeyword` -> `createLeaf`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87495/new/
https://reviews.
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:51
+ return createLeaf(A, tok::getKeywordSpelling(K), K);
+}
+
gribozavr2 wrote:
> eduucaldas wrote:
> > gribozavr2 wrote:
> > > Could we make a combined function that does not
eduucaldas updated this revision to Diff 291239.
eduucaldas added a comment.
fix clang-tidy warning
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87495/new/
https://reviews.llvm.org/D87495
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87522
Files:
clang/lib/Tooling/Syntax/
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87523
Files:
clang/include/clang/Tooli
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87526
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
clang/lib/Tooling
eduucaldas updated this revision to Diff 291261.
eduucaldas added a comment.
add previous patch to allow pre-merge checks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87526/new/
https://reviews.llvm.org/D87526
Files:
clang/include/clang/Tooling
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
In a future patch
- Implement helper function to generate Trees for tests
- and test Tree methods, namely `findFirstLeaf` and `findLastLeaf`
Rep
eduucaldas updated this revision to Diff 291280.
eduucaldas marked 2 inline comments as done.
eduucaldas added a comment.
Remove `createLeafLowLevel`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87495/new/
https://reviews.llvm.org/D87495
Files:
eduucaldas updated this revision to Diff 291284.
eduucaldas added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87533/new/
https://reviews.llvm.org/D87533
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
clang/lib/Toolin
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5d152127d48f: [SyntaxTree][Synthesis] Add support for simple
Leafs and test based on tree dump (authored by eduucaldas).
Repository:
rG LLVM Githu
eduucaldas updated this revision to Diff 291293.
eduucaldas added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87523/new/
https://reviews.llvm.org/D87523
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/lib/Tooling/Syn
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG515238d5b113: [SyntaxTree] Reduce visibility of
`Arena::lexBuffer`. (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
This revision was automatically updated to reflect the committed changes.
Closed by commit rG238ae4eee051: [SyntaxTree] Add const qualifiers, from
[llvm-qualified-auto] (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87522/new
eduucaldas updated this revision to Diff 291320.
eduucaldas marked an inline comment as done.
eduucaldas added a comment.
Add argument names to function declaration
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87533/new/
https://reviews.llvm.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7c37b82f5ba5: [SyntaxTree][Synthesis] Add support for Tree.
(authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87533/new/
https://revie
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87598
Files:
clang/lib/Tooling/Syntax/
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87599
Files:
clang/include/clang/Tooli
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87600
Files:
clang/include/clang/Tooli
eduucaldas updated this revision to Diff 291522.
eduucaldas marked 2 inline comments as done.
eduucaldas added a comment.
Fix build error and clang-tidy lint error
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87600/new/
https://reviews.llvm.org/D8
This revision was automatically updated to reflect the committed changes.
Closed by commit rG12232dc181cb: [SyntaxTree][List] Fix:
`ParameterDeclarationList` is the `List` inside… (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0f4cc64fd747: [SyntaxTree] Provide `List::classof` (authored
by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87599/new/
https://reviews.llvm.o
eduucaldas updated this revision to Diff 291532.
eduucaldas added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87600/new/
https://reviews.llvm.org/D87600
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/lib/Tooling/Syn
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGceb0128509c5: [SyntaxTree][List] `assertInvariants` for
`List`s (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87749
Files:
clang/include/clang/Tooli
eduucaldas updated this revision to Diff 292145.
eduucaldas added a comment.
Remove extraneous qualifiers in `createTree`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87749/new/
https://reviews.llvm.org/D87749
Files:
clang/include/clang/Tooling
eduucaldas created this revision.
Herald added subscribers: cfe-commits, mgorny.
Herald added a project: clang.
eduucaldas requested review of this revision.
- Introduce `TreeTest.cpp` to unit test `Tree.h`
- Add `generateAllTreesWithShape` to generating test cases
- Add tests for `findFirstLeaf`
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Prior to this change `createTree` could not create arbitrary syntax
trees. Now it dispatches to the constr
eduucaldas updated this revision to Diff 292444.
eduucaldas edited the summary of this revision.
eduucaldas added a comment.
Fix comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87820/new/
https://reviews.llvm.org/D87820
Files:
clang/includ
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1e19165bd89d: [SyntaxTree][Synthesis] Fix allocation in
`createTree` for more general use (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
eduucaldas updated this revision to Diff 292539.
eduucaldas added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87749/new/
https://reviews.llvm.org/D87749
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
clang/lib/Toolin
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87839
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/unittests/Toolin
eduucaldas updated this revision to Diff 292547.
eduucaldas added a comment.
Apply arc lint patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87839/new/
https://reviews.llvm.org/D87839
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/u
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87895
Files:
clang/unittests/Tooling/S
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
The new test shows that `createLeaf` depends on the C++ version.
Repository:
rG LLVM Github Monorepo
eduucaldas updated this revision to Diff 292831.
eduucaldas added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87896/new/
https://reviews.llvm.org/D87896
Files:
clang/unittests/Tooling/Syntax/SynthesisTest.cpp
Index: clang/u
eduucaldas updated this revision to Diff 292832.
eduucaldas added a comment.
Fix typo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87895/new/
https://reviews.llvm.org/D87895
Files:
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
Index: clang
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87925
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
clang/lib/Tooling
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbb5b28f12fbd: [SyntaxTree][Synthesis] Improve testing
`createLeaf` (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87896/new/
https:
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe616a4259889: [SyntaxTree] Test for '\' inside
token. (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
eduucaldas updated this revision to Diff 293085.
eduucaldas marked 3 inline comments as done.
eduucaldas added a comment.
- `deepCopy` returns `nullptr` if copy code with Macro expansions.
- `deepCopy` also deep copies the Tokens.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:237
+
+syntax::Node *clang::syntax::deepCopy(syntax::Arena &A, const Node *N) {
+ if (!canModifyAllDescendants(N))
We are ignoring nullability of pointers.
The casting machiner
eduucaldas updated this revision to Diff 293089.
eduucaldas marked 3 inline comments as done.
eduucaldas added a comment.
Fix canModifyAllDescendants, add tests for it
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87749/new/
https://reviews.llvm.or
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D88004
Files:
clang/lib/Tooling/Syntax/BuildTree.cpp
clang/lib/Tooling/Syntax/
eduucaldas updated this revision to Diff 293101.
eduucaldas added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87749/new/
https://reviews.llvm.org/D87749
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
clang/lib/Tooling/Syn
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4a5cc389c51d: [SyntaxTree][Synthesis] Implement `deepCopy`
(authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
This revision was automatically updated to reflect the committed changes.
Closed by commit rG87f0b51d68de: [SyntaxTree][NFC] follow naming convention +
remove auto on empty vector… (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
eduucaldas updated this revision to Diff 293163.
eduucaldas marked 3 inline comments as done.
eduucaldas added a comment.
- Answer Review
- Change names in `generateAllTreesWithShape`
- `auto x = vector()` -> `vector x;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
eduucaldas updated this revision to Diff 293167.
eduucaldas added a comment.
Comment `generateAllTreesWithShape`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87779/new/
https://reviews.llvm.org/D87779
Files:
clang/lib/Tooling/Syntax/Tree.cpp
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
I also assured that there are no other functions unnecessarily using
std::vector as argument.
Repositor
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D88034
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
clang/lib/Tooling
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1dc7836aed13: [SyntaxTree][Nit] Take `ArrayRef` instead of
`std::vector` as argument for… (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaf582c9b0f3a: [SyntaxTree] Test `findFirstLeaf` and
`findLastLeaf` (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87779/new/
https:
eduucaldas updated this revision to Diff 293361.
eduucaldas added a comment.
Remove buggy `deepCopy`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88034/new/
https://reviews.llvm.org/D88034
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
eduucaldas updated this revision to Diff 293363.
eduucaldas added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88034/new/
https://reviews.llvm.org/D88034
Files:
clang/include/clang/Tooling/Syntax/BuildTree.h
clang/lib/Tooling/Syn
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D88077
Files:
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
Index: clang/uni
This revision was automatically updated to reflect the committed changes.
Closed by commit rG66bcb14312a0: [SyntaxTree][Synthesis] Fix: `deepCopy` ->
`deepCopyExpandingMacros`. (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D8
eduucaldas updated this revision to Diff 293386.
eduucaldas added a comment.
- [SyntaxTree] Split `TreeTest` and `ListTest` testing fixtures.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87839/new/
https://reviews.llvm.org/D87839
Files:
clang/i
eduucaldas updated this revision to Diff 293389.
eduucaldas added a comment.
Add FIXME for `MIN(X, Y)`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88077/new/
https://reviews.llvm.org/D88077
Files:
clang/unittests/Tooling/Syntax/BuildTreeTest.c
eduucaldas added a reviewer: gribozavr2.
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:3858
-TEST_P(BuildSyntaxTreeTest, NonModifiableNodes) {
- // Some nodes are non-modifiable, they are marked with 'I:'.
+TEST_P(BuildSyntaxTre
eduucaldas added a reviewer: gribozavr2.
eduucaldas added a comment.
I made a separate class for the tests on Lists, as it didn't share any methods
with the tests for Trees. What do you think about that?
Should I also put the tests for lists in a different file, even though
`TreeTest.cpp` could
eduucaldas added a comment.
Looking for feedback, specially on the names I used.
Also if you have ideas of interesting tests they will be gladly accepted :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88077/new/
https://reviews.llvm.org/D88077
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6dc06fa09d1a: [SyntaxTree] Add tests for the assignment of
the `canModify` tag. (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88077
eduucaldas updated this revision to Diff 293489.
eduucaldas marked 3 inline comments as done.
eduucaldas added a comment.
Answer code review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87839/new/
https://reviews.llvm.org/D87839
Files:
clang/i
eduucaldas updated this revision to Diff 293490.
eduucaldas added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87839/new/
https://reviews.llvm.org/D87839
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/unittests/Tooling/Sy
eduucaldas marked an inline comment as done.
eduucaldas added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:224
+ /// "a, b c" <=> [("a", ","), ("b", nul), ("c", nul)]
+ /// "a, b,"<=> [("a", ","), ("b", ","), (nul, nul)]
///
g
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D88106
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/lib/Tooling/Synt
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc3c08bfdfd62: [SyntaxTree] Test the List API (authored by
eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87839/new/
https://reviews.llvm.org/D87
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
After this change all nodes that have a delimited-list are using the
`List` API.
Implementation details:
Let's look at a declaration with multiple
eduucaldas added a reviewer: gribozavr2.
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:594
+/// Shrink \p Range to a subrange that only contains tokens of a list.
+ArrayRef shrinkToFitList(ArrayRef Range) {
+ auto BeginChildren
eduucaldas marked 3 inline comments as done.
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:2932
|-'void'
- |-SimpleDeclarator Declarator
- | |-'foo'
- | `-ParametersAndQualifiers
- | |-'(' OpenParen
- | `-')' CloseParen
eduucaldas updated this revision to Diff 294905.
eduucaldas marked an inline comment as done.
eduucaldas added a comment.
Improve comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88403/new/
https://reviews.llvm.org/D88403
Files:
clang/inclu
eduucaldas updated this revision to Diff 295053.
eduucaldas added a comment.
Update tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88403/new/
https://reviews.llvm.org/D88403
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tool
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5011d43108d1: Migrate Declarators to use the List API
(authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88403/new/
https://reviews.llv
eduucaldas updated this revision to Diff 296994.
eduucaldas added a comment.
- [SyntaxTree] Provide iterator for `List` that iterates through
`ElementAndDelimiter`s even for not well-defined lists.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D8810
eduucaldas updated this revision to Diff 296996.
eduucaldas added a comment.
Better comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.org/D88106
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/lib/To
eduucaldas updated this revision to Diff 297001.
eduucaldas added a comment.
Reorganize methods to minimize diffs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.org/D88106
Files:
clang/include/clang/Tooling/Syntax/
eduucaldas updated this revision to Diff 297006.
eduucaldas added a comment.
Replace `auto .. = std::vector();` with `std::vector ..;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.org/D88106
Files:
clang/include/
eduucaldas added a reviewer: gribozavr2.
eduucaldas added a comment.
This is quite low priority, compared to the other branches of work, but it was
almost ready work, so I decided to polish it and send it to review now.
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:238
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D89146
Files:
clang/include/clang/Tooli
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Previously `replaceChildRangeLowLevel` took the new child range as a
`Node* New`. `New` was expected to have siblings attached already, and
thus i
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Not intended for submission.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D89148
Files:
clang/include/clang/Tooling/Syntax/
eduucaldas updated this revision to Diff 297389.
eduucaldas added a comment.
Add reachability assertions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89147/new/
https://reviews.llvm.org/D89147
Files:
clang/include/clang/Tooling/Syntax/Tree.h
eduucaldas updated this revision to Diff 297395.
eduucaldas added a comment.
Add role sanity-check. Introduce `GetBegin()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89147/new/
https://reviews.llvm.org/D89147
Files:
clang/include/clang/Tooli
eduucaldas updated this revision to Diff 297396.
eduucaldas added a comment.
Fix whitespacing
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89147/new/
https://reviews.llvm.org/D89147
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/lib/T
eduucaldas updated this revision to Diff 297398.
eduucaldas added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89148/new/
https://reviews.llvm.org/D89148
Files:
clang/include/clang/Tooling/Syntax/Mutations.h
clang/lib/Toolin
eduucaldas updated this revision to Diff 297502.
eduucaldas added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89146/new/
https://reviews.llvm.org/D89146
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
Index: clang/include
eduucaldas updated this revision to Diff 297511.
eduucaldas added a comment.
Add asserts to `MutationsImpl::remove`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89147/new/
https://reviews.llvm.org/D89147
Files:
clang/include/clang/Tooling/Synta
eduucaldas added a subscriber: gribozavr2.
eduucaldas added a comment.
This patch implements the use case we discussed. It is merely for illustration.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89148/new/
https://reviews.llvm.org/D89148
___
eduucaldas updated this revision to Diff 297574.
eduucaldas marked 8 inline comments as done.
eduucaldas added a comment.
Answer comments, TODO: think about templated iterators
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://review
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
- Add assertions for other preconditions.
- If nothing is modified, don't mark it.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.or
eduucaldas updated this revision to Diff 297800.
eduucaldas added a comment.
minor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89303/new/
https://reviews.llvm.org/D89303
Files:
clang/lib/Tooling/Syntax/Tree.cpp
Index: clang/lib/Tooling/Synta
eduucaldas updated this revision to Diff 297803.
eduucaldas added a comment.
minor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89303/new/
https://reviews.llvm.org/D89303
Files:
clang/lib/Tooling/Syntax/Tree.cpp
Index: clang/lib/Tooling/Synta
eduucaldas added a reviewer: gribozavr2.
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/Tree.cpp:103
#ifndef NDEBUG
- for (auto *N = New; N; N = N->getNextSibling()) {
+ for (auto *N = New; N; N = N->NextSibling) {
assert(N->Parent == nullptr);
---
301 - 400 of 480 matches
Mail list logo