[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

joey updated this revision to Diff 172122. joey added a comment. I re-worked where the builtins are actually inserted, now it's in a similar place to the "normal" clang builtins. I addressed the issue of putting the return type also into the args type (could rename this to signature/proto table

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

joey updated this revision to Diff 169182. joey added a comment. Re-uploading the patch. The previous version of the patch was missing the include and lib prefixes. https://reviews.llvm.org/D53023 Files: include/clang/Basic/CMakeLists.txt include/clang/Basic/OpenCLBuiltins.td lib/Sema/Se

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

joey created this revision. joey added reviewers: asavonic, Anastasia. Herald added subscribers: cfe-commits, yaxunl, mgorny. This is the prototype for the approach that was mentioned by Anastasia in http://lists.llvm.org/pipermail/cfe-dev/2018-September/059529.html The tablegen file describes t

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

joey closed this revision. joey added a comment. I committed all the parts separately: r309567 (with r309571 to fix a test), r309678 and r310477. https://reviews.llvm.org/D33945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

joey updated this revision to Diff 108452. joey added a comment. Updated all the comments you made and rebased. Sorry for the long delay. https://reviews.llvm.org/D33945 Files: CodeGen/CGBuiltin.cpp CodeGenOpenCL/cl20-device-side-enqueue.cl CodeGenOpenCL/pipe_builtin.cl Sema/SemaChecki

[PATCH] D34948: [OpenCL] Generalise err_opencl_enqueue_kernel_expected_type to be used with other builtins

joey added a comment. In https://reviews.llvm.org/D34948#798332, @bader wrote: > LGTM. > Do you have another built-in in mind which can use this diagnostic message? > If so, it would make sense to re-use it in the same patch. This is split off from https://reviews.llvm.org/D33945, which I wil

[PATCH] D34948: [OpenCL] Generalise err_opencl_enqueue_kernel_expected_type to be used with other builtins

joey created this revision. Herald added subscribers: Anastasia, yaxunl. Refactor err_opencl_enqueue_kernel_expected_type so that other builtins can use the same diagnostic. https://reviews.llvm.org/D34948 Files: Sema/SemaChecking.cpp SemaOpenCL/cl20-device-side-enqueue.cl clang/Basic/Di

[PATCH] D34871: [OpenCL] Add function name to extension diagnostic

joey added a comment. Thanks! Making that change, going to re-run the tests and then I'll commit. https://reviews.llvm.org/D34871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34871: [OpenCL] Add function name to extension diagnostic

joey created this revision. Herald added subscribers: Anastasia, yaxunl. Slightly improve the diagnostic by including the function name. This has been separated out from https://reviews.llvm.org/D33945. https://reviews.llvm.org/D34871 Files: Sema/Sema.cpp SemaOpenCL/extension-begin.cl cl

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

joey created this revision. Herald added subscribers: Anastasia, yaxunl. This adds get_kernel_max_sub_group_size_for_ndrange and get_kernel_sub_group_count_for_ndrange. Note this also changes err_opencl_requires_extension to print the name of the function that the diagnostic is warning about.

[PATCH] D29718: [libclang] [OpenCL] Expose half type

This revision was automatically updated to reflect the committed changes. Closed by commit rL294754: [libclang] [OpenCL] Expose half type. (authored by joey). Changed prior to commit: https://reviews.llvm.org/D29718?vs=87654&id=88002#toc Repository: rL LLVM https://reviews.llvm.org/D29718

[PATCH] D27049: [OpenCL] Refactor out ReadPipe/WritePipe

joey closed this revision. joey added a comment. Committed in r288332. Thanks Yaron! Repository: rL LLVM https://reviews.llvm.org/D27049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D27049: [OpenCL] Refactor out ReadPipe/WritePipe

joey updated this revision to Diff 79399. joey added a comment. Pipe types cannot be merged by ASTContext::mergeTypes. Repository: rL LLVM https://reviews.llvm.org/D27049 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Serialization/ASTBitCodes.h lib/AST/