sdkrystian wrote:
Ping @erichkeane
https://github.com/llvm/llvm-project/pull/84050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/86817
Currently, clang erroneously rejects the following:
```cpp
template
struct A
{
template
auto f();
};
template<>
template
auto A::f(); // error: conflicting types for 'f'
```
This happens because the ex
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/86817
>From 468e3d9414a797ea73411a779343dee351e09e42 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 27 Mar 2024 11:23:19 -0400
Subject: [PATCH] [Clang][Sema] Fix explicit specializations of member fun
sdkrystian wrote:
Still needs a release note but should otherwise be good to go
https://github.com/llvm/llvm-project/pull/86817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/86817
>From 468e3d9414a797ea73411a779343dee351e09e42 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 27 Mar 2024 11:23:19 -0400
Subject: [PATCH 1/3] [Clang][Sema] Fix explicit specializations of member
@@ -12107,6 +12090,35 @@ bool Sema::CheckFunctionDeclaration(Scope *S,
FunctionDecl *NewFD,
CheckConstPureAttributesUsage(*this, NewFD);
+ // C++23 [dcl.spec.auto.general]p12:
+ // Return type deduction for a templated function with a placeholder in its
+ // declare
@@ -345,6 +345,10 @@ Bug Fixes in This Version
- Fixes an assertion failure on invalid code when trying to define member
functions in lambdas.
+- Clang now allows for member function templates of class templates declared
with a deduced return type
+ to be explicitly specia
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/86817
>From 468e3d9414a797ea73411a779343dee351e09e42 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 27 Mar 2024 11:23:19 -0400
Subject: [PATCH 1/4] [Clang][Sema] Fix explicit specializations of member
sdkrystian wrote:
Ping @erichkeane
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1735,48 +1757,21 @@ MemberExpr *MemberExpr::Create(
ValueDecl *MemberDecl, DeclAccessPair FoundDecl,
DeclarationNameInfo NameInfo, const TemplateArgumentListInfo *TemplateArgs,
QualType T, ExprValueKind VK, ExprObjectKind OK, NonOdrUseReason NOUR) {
- bool HasQ
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/81642
>From b45a42322682f3b872e6753965c4e4a7edb68333 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 9 Feb 2024 14:00:49 -0500
Subject: [PATCH 1/4] [Clang] Unify interface for accessing template argume
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/81642
>From b45a42322682f3b872e6753965c4e4a7edb68333 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 9 Feb 2024 14:00:49 -0500
Subject: [PATCH 1/5] [Clang] Unify interface for accessing template argume
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/81642
>From b45a42322682f3b872e6753965c4e4a7edb68333 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 9 Feb 2024 14:00:49 -0500
Subject: [PATCH 1/6] [Clang] Unify interface for accessing template argume
sdkrystian wrote:
@erichkeane Regarding "Still waiting on this?", I pushed a commit that
addresses the fixme. I'll be addressing the rest of your review comments in a
subsequent commit..
Also, if we are renaming `ExplicitInstantiationInfo::ExternLoc` to
`ExternKeywordLoc`, should we rename th
@@ -1287,7 +1287,10 @@ static ExprResult LookupMemberExpr(Sema &S, LookupResult
&R,
return ExprError();
QualType BaseType = BaseExpr.get()->getType();
+
+#if 0
sdkrystian wrote:
This assertion should be deleted since the lookup context could be the cur
@@ -990,6 +970,18 @@ Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType
BaseExprType,
const Scope *S,
bool SuppressQualifierCheck,
ActOnMemberAccessExtraArgs *ExtraArgs) {
+ asse
sdkrystian wrote:
Ping @erichkeane
https://github.com/llvm/llvm-project/pull/86817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/86817
>From e84e4b6fedb5a643082cd38d0e10d910b299f73f Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 27 Mar 2024 11:23:19 -0400
Subject: [PATCH] [Clang][Sema] Fix explicit specializations of member fun
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/86817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/86678
>From d257fa46da4f84dfcedfa8d25267f3326996d72e Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 26 Mar 2024 10:04:44 -0400
Subject: [PATCH] [Clang][AST][NFC] MemberExpr stores NestedNameSpecifierL
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/86682
>From d257fa46da4f84dfcedfa8d25267f3326996d72e Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 26 Mar 2024 10:04:44 -0400
Subject: [PATCH 1/2] [Clang][AST][NFC] MemberExpr stores
NestedNameSpeci
@@ -583,11 +583,14 @@ class alignas(void *) Stmt {
unsigned IsArrow : 1;
/// True if this member expression used a nested-name-specifier to
-/// refer to the member, e.g., "x->Base::f", or found its member via
-/// a using declaration. When true, a MemberExprN
sdkrystian wrote:
@erichkeane Requested changes applied... should I wait for other reviews on the
other PR (#86678), or do you think I should go ahead and merge #86678 and then
this one?
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits
sdkrystian wrote:
@erichkeane Just merging this PR will result in the commits being squashed into
a single commit... is that alright?
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
sdkrystian wrote:
Thanks! I'll add a comment on the other PR saying the commit was reviewed here
& then I'll merge
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
sdkrystian wrote:
Changes were reviewed in the review of #86682
https://github.com/llvm/llvm-project/pull/86678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/86678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/86682
>From 125b91778874e9f61e178ea4dd2efaf592ea84bb Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 26 Mar 2024 11:27:28 -0400
Subject: [PATCH] [Clang][AST][NFC] Move template argument dependence
com
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -131,7 +131,9 @@ struct BuiltinTypeDeclBuilder {
DeclarationNameInfo NameInfo =
DeclarationNameInfo(DeclarationName(&II), SourceLocation());
LookupResult R(S, NameInfo, Sema::LookupOrdinaryName);
-S.LookupParsedName(R, S.getCurScope(), &SS, false);
+S
@@ -1055,9 +1045,19 @@ Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType
BaseExprType,
}
}
-Diag(R.getNameLoc(), diag::err_no_member)
- << MemberName << DC
- << (BaseExpr ? BaseExpr->getSourceRange() : SourceRange());
+if (SS.isNotEmpty() &&
sdkrystian wrote:
@erichkeane PR updated.
When we encounter a class member access expression with a nested-name-specifier
that is invalid, should we simply ignore it and instead use the type of the
object expression as the lookup context? This is the current behavior, but it
leads to lots of
sdkrystian wrote:
> Sorry, I'm not really getting the question here. Obviously that 2nd error is
> invalid and we shouldn't be emitting it, and doing the `::z` lookup inside of
> `A` seems wrong to me. But I'm not sure I get the issue.
We currently emit the second error. I'm asking if we shoul
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/88042
The approved resolution for
[CWG2858](https://cplusplus.github.io/CWG/issues/2858.html) changes
[[expr.prim.id.qual] p2 sentence
2](https://eel.is/c++draft/expr.prim.id.qual#2) to read:
> A declarative _nest
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
>From 9c3b78f1f37049224f31e3bcd07ae8d762b760d1 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 8 Apr 2024 09:46:08 -0400
Subject: [PATCH] [Clang][Sema] Implement approved resolution for CWG2858
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/88042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
Ping @erichkeane :)
https://github.com/llvm/llvm-project/pull/87541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/87541
>From 6ad6b5e698c3ae6fd8e881582fcfa4c8bb231da4 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 3 Apr 2024 14:33:27 -0400
Subject: [PATCH 1/4] [Clang][Sema] Fix crash when 'this' is used in a
dep
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/87541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@cor3ntin Should I just move the test from
`test/CXX/expr/expr.prim/expr.prim.id/expr.prim.id.qual/p3.cpp` to
`test/CXX/drs/dr28xx.cpp`?
https://github.com/llvm/llvm-project/pull/88042
___
cfe-commits mailing list
cfe-commits@lists.
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
Unicorn! ยท GitHub
body {
background-color: #f1f1f1;
margin: 0;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}
.container { margin: 50px
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
>From e850ae0982efbb7cec7c33d6b927844d89128743 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 8 Apr 2024 09:46:08 -0400
Subject: [PATCH 1/3] [Clang][Sema] Implement approved resolution for CWG28
@@ -58,3 +58,24 @@ void B::g() requires true;
#endif
} // namespace dr2847
+
+namespace dr2858 { // dr2858: 19
+
+#if __cplusplus > 202302L
+
+template
+struct A {
+ // FIXME: The nested-name-specifier in the following friend declarations are
declarative,
sd
@@ -58,3 +58,24 @@ void B::g() requires true;
#endif
} // namespace dr2847
+
+namespace dr2858 { // dr2858: 19
+
+#if __cplusplus > 202302L
+
+template
+struct A {
+ // FIXME: The nested-name-specifier in the following friend declarations are
declarative,
+ // but we don't
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/88139
This patch adds a `Typename` bit-field to `TemplateTemplateParmDecl` which
stores whether the template template parameter was declared with the `typename`
keyword.
>From 5bc0f03437349705ac9dff096fcc0c5b8b16c
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88139
>From a3a9dd90ffd82c738c41c6c581852a10742f2bbc Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 10:51:56 -0400
Subject: [PATCH] [Clang][AST] Track whether template template parameters u
sdkrystian wrote:
@erichkeane I added a release note. Regarding the addition of an enumeration
type, how about:
```cpp
enum class TypeParmKeyword {
Class,
Typename
};
```
(I used `TypeParm` because a template template parameter is a _type-parameter_
in the C++ grammar, but I'm open to alte
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
>From e850ae0982efbb7cec7c33d6b927844d89128743 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 8 Apr 2024 09:46:08 -0400
Subject: [PATCH 1/4] [Clang][Sema] Implement approved resolution for CWG28
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
>From e850ae0982efbb7cec7c33d6b927844d89128743 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 8 Apr 2024 09:46:08 -0400
Subject: [PATCH 1/4] [Clang][Sema] Implement approved resolution for CWG28
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
>From e850ae0982efbb7cec7c33d6b927844d89128743 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 8 Apr 2024 09:46:08 -0400
Subject: [PATCH 1/5] [Clang][Sema] Implement approved resolution for CWG28
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/88146
Dependent `PackIndexType`s currently print the memory address of the index
`Expr*` rather than pretty printing the expression. This patch fixes that.
>From 04869abc01117c6f4f270b9b9b61cdb2a7e1acc6 Mon Sep 17
sdkrystian wrote:
@rupprecht That's unintended, will revert and address it.
https://github.com/llvm/llvm-project/pull/87541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/88264
Reverts llvm/llvm-project#87541
>From 0fa09befb37c36ec1ed796c28f6b33605fc04ecd Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 10 Apr 2024 08:36:37 -0400
Subject: [PATCH] =?UTF-8?q?Revert=20"[Cl
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/88264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/88146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/88311
Reapplies #87541 and addresses the bug which caused expressions naming overload
sets to be incorrectly rebuilt.
>From f6d703151ec06cec140c4d425dc2bbd8b7ac4f93 Mon Sep 17 00:00:00 2001
From: Krystian Stasiows
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH] Reapply "[Clang][Sema] Fix crash when 'this' is used in a
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
sdkrystian wrote:
@Endilll `clang/www/make_cxx_dr_status` queries core issues from
https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_index.html. Since a new
revision of the index has not yet been published since CWG2858 was opened,
`clang/www/make_cxx_dr_status` doesn't add an entry for the iss
sdkrystian wrote:
@erichkeane Apologies, I should have structured the commits differently so it's
clear what the new changes are...
I added an `IsAddressOfOperand` parameter to
`TreeTransform::TransformUnresolvedLookupExpr` and changed the conditions under
which `Sema::BuildPossibleImplicitMe
sdkrystian wrote:
Could also get them from the CWG GitHub pages repository
(https://github.com/cplusplus/CWG/tree/gh-pages/issues)... anyways, am I good
to merge this?
https://github.com/llvm/llvm-project/pull/88042
___
cfe-commits mailing list
cfe-c
sdkrystian wrote:
Oh, sorry. I'll do that :)
https://github.com/llvm/llvm-project/pull/88042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/4] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
>From e850ae0982efbb7cec7c33d6b927844d89128743 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 8 Apr 2024 09:46:08 -0400
Subject: [PATCH 1/6] [Clang][Sema] Implement approved resolution for CWG28
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/5] Reapply "[Clang][Sema] Fix crash when 'this' is used
sdkrystian wrote:
@Endilll I ran `make_cxx_dr_status` with the index from the WG21 wiki... should
I drop the commit?
https://github.com/llvm/llvm-project/pull/88042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/6] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
>From e850ae0982efbb7cec7c33d6b927844d89128743 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 8 Apr 2024 09:46:08 -0400
Subject: [PATCH 1/5] [Clang][Sema] Implement approved resolution for CWG28
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/88042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@erichkeane I'm thinking of keeping the use of `bool` to represent the presence
of `typename` in this patch, and opening another PR that changes both
`TemplateTemplateParmDecl` and `TypeTemplateParmDecl` to use
`TypeParmKeyword`... What do you think?
https://github.com/llvm/
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88139
>From a3a9dd90ffd82c738c41c6c581852a10742f2bbc Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 10:51:56 -0400
Subject: [PATCH 1/2] [Clang][AST] Track whether template template paramete
sdkrystian wrote:
What category should the release note go under?
https://github.com/llvm/llvm-project/pull/88139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88139
>From a3a9dd90ffd82c738c41c6c581852a10742f2bbc Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 10:51:56 -0400
Subject: [PATCH 1/3] [Clang][AST] Track whether template template paramete
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88139
>From bf5efab69470cfca1c4bea4d8fc31415012a1b17 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 10:51:56 -0400
Subject: [PATCH 1/3] [Clang][AST] Track whether template template paramete
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/88139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
Seems like there is a stray call to `TemplateTemplateParmDecl::Create` in
LLDB... #88139 will address it
https://github.com/llvm/llvm-project/pull/88139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/88311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@rupprecht looks like the issue is with non-static members in base classes:
```cpp
struct B
{
int z;
void h(int);
};
template
struct A : B
{
int y;
void g(int);
template
void f(U);
template<>
void f(int x)
{
x;
y;
sdkrystian wrote:
The expression type need to be set to `ASTContext::DependentTy` (currently,
it's set to `ASTContext::OverloadTy`) if we find a member of a base class (as
it is for direct members). Should be an easy fix, so I'm thinking of not
reverting and just opening a PR that will address
sdkrystian wrote:
@mizvekov I totally forgot about this PR, sorry! I'll add a test and merge
tomorrow :)
https://github.com/llvm/llvm-project/pull/68222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/88731
Reapplies #87541 and #88311 (again) addressing the bug which caused expressions
naming overload sets to be incorrectly rebuilt, as well as the bug which caused
base class members to always be treated as overl
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88731
>From 02d98a20ad2214c928d6ffcc7f54abe1172a2407 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 15 Apr 2024 09:17:39 -0400
Subject: [PATCH] Reapply "[Clang][Sema] Fix crash when 'this' is used in
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88731
>From 02d98a20ad2214c928d6ffcc7f54abe1172a2407 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 15 Apr 2024 09:17:39 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88731
>From 02d98a20ad2214c928d6ffcc7f54abe1172a2407 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 15 Apr 2024 09:17:39 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88731
>From 02d98a20ad2214c928d6ffcc7f54abe1172a2407 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 15 Apr 2024 09:17:39 -0400
Subject: [PATCH 1/4] Reapply "[Clang][Sema] Fix crash when 'this' is used
sdkrystian wrote:
The primary change since #88311 is `UnresolvedLookupExpr::Create` is called
directly in `BuildPossibleImplicitMemberExpr` with `KnownDependent` as `true`
(which causes the expression type to be set to `ASTContext::DependentTy`). This
ensures that any further semantic analysis
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/83842
The following snippet causes a crash ([godbolt
link](https://godbolt.org/z/E17sYfYrY)):
```cpp
template
struct A : T {
using T::f;
void f();
void g() {
f(); // crash here
}
};
```
This happens bec
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/83842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/79683
>From 7d05842505dbcabcc54cb365006c794ab9371983 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 16 Jan 2024 08:05:33 -0500
Subject: [PATCH] Reapply "[Clang][Sema] Diagnose function/variable templa
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/79683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
Actually, I don't think the proposed fix here is quite right. If we _only_ find
an `UnresolvedUsingValueDecl`, then we shouldn't assume the name is a template
per [[temp.names] p3.3](http://eel.is/c++draft/temp.names#3.3)... will work on
a new fix.
https://github.com/llvm/ll
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/83842
>From aeeb445a9e52a8011a008a5ee3438709f835034c Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 4 Mar 2024 08:10:35 -0500
Subject: [PATCH 1/2] [Clang][Sema] Fix crash when using name of
Unresolve
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/83842
>From aeeb445a9e52a8011a008a5ee3438709f835034c Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 4 Mar 2024 08:10:35 -0500
Subject: [PATCH 1/2] [Clang][Sema] Fix crash when using name of
Unresolve
sdkrystian wrote:
Updated with new fix
https://github.com/llvm/llvm-project/pull/83842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/83842
>From aeeb445a9e52a8011a008a5ee3438709f835034c Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 4 Mar 2024 08:10:35 -0500
Subject: [PATCH 1/2] [Clang][Sema] Fix crash when using name of
Unresolve
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/83842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/83842
>From aeeb445a9e52a8011a008a5ee3438709f835034c Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 4 Mar 2024 08:10:35 -0500
Subject: [PATCH 1/3] [Clang][Sema] Fix crash when using name of
Unresolve
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/83842
>From 4725321631e69c8d8480e0dba85128d177541a89 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 4 Mar 2024 08:10:35 -0500
Subject: [PATCH 1/3] [Clang][Sema] Fix crash when using name of
Unresolve
101 - 200 of 846 matches
Mail list logo
