This revision was automatically updated to reflect the committed changes.
Closed by commit rG7440e2274fbd: [RISCV] Add '32bit' feature to rv32
only builtins. (authored by craig.topper).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132192/new/
https
kito-cheng accepted this revision.
kito-cheng added a comment.
This revision is now accepted and ready to land.
LGTM, and +1 for the error message improvement, but could be separated patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132192/new/
craig.topper added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:4359
-return Diag(TheCall->getCallee()->getBeginLoc(),
-diag::err_32_bit_builtin_64_bit_tgt);
-
luismarques wrote:
> That tablegen def is still being used for X86.
luismarques added a comment.
Overall LGTM.
I have one concern, though. The old error message was more user friendly.
Referring to RV32 as an extension is... weird. You're already massaging the
error with the `OF = "RV64"` / `OF = "RV32"`. Can't you special case this
feature check error handlin
craig.topper created this revision.
craig.topper added reviewers: asb, luismarques, reames, kito-cheng.
Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr,
frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult, MartinM
