This revision was automatically updated to reflect the committed changes.
Closed by commit rL264149: [X86] Add "x87" in x86 target feature map. (authored
by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D13980?vs=48904=51398#toc
Repository:
rL LLVM
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
-eric
http://reviews.llvm.org/D13980
___
cfe-commits mailing list
rsmith added inline comments.
Comment at: lib/Basic/Targets.cpp:2603
@@ -2599,3 +2602,3 @@
case CK_i386:
case CK_i486:
case CK_i586:
echristo wrote:
> Waiting for rsmith to comment here.
>
>
This seems fine to me.
http://reviews.llvm.org/D13980
echristo added a comment.
Can you add an explicit test for soft/hard-float.
One inline comment as well, waiting on Richard to pipe up.
-eric
Comment at: lib/Basic/Targets.cpp:2603
@@ -2599,3 +2602,3 @@
case CK_i386:
case CK_i486:
case CK_i586:
aturetsk added a comment.
Hi,
The related LLVM patch (http://reviews.llvm.org/D13979) was approved. Is this
patch ok for commit?
http://reviews.llvm.org/D13980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aturetsk updated this revision to Diff 41511.
aturetsk added a comment.
Enable X87 back for all X86 processors.
http://reviews.llvm.org/D13980
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86-mmx.c
test/CodeGen/attr-target-x86.c
Index: test/CodeGen/attr-target-x86.c
aturetsk added inline comments.
Comment at: lib/Basic/Targets.cpp:2551
@@ -2547,3 +2550,3 @@
case CK_i386:
case CK_i486:
case CK_i586:
"x87 instructions probably work" is more like it, and having feature x87
disabled would mean "x87 instructions
aturetsk added inline comments.
Comment at: lib/Basic/Targets.cpp:2548
@@ +2547,3 @@
+ // All X86 processors but i386 have X87.
+ if (Kind != CK_i386)
+setFeatureEnabledImpl(Features, "x87", true);
rsmith wrote:
> What about `CK_Generic`? Also, if `CK_i486`
rsmith added inline comments.
Comment at: lib/Basic/Targets.cpp:2548
@@ +2547,3 @@
+ // All X86 processors but i386 have X87.
+ if (Kind != CK_i386)
+setFeatureEnabledImpl(Features, "x87", true);
aturetsk wrote:
> rsmith wrote:
> > What about `CK_Generic`?
rsmith added inline comments.
Comment at: lib/Basic/Targets.cpp:2548
@@ +2547,3 @@
+ // All X86 processors but i386 have X87.
+ if (Kind != CK_i386)
+setFeatureEnabledImpl(Features, "x87", true);
What about `CK_Generic`? Also, if `CK_i486` can be used for
aturetsk updated this revision to Diff 41137.
aturetsk added a comment.
Use getCPUKind once
http://reviews.llvm.org/D13980
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86-mmx.c
test/CodeGen/attr-target-x86.c
Index: test/CodeGen/attr-target-x86.c
aturetsk added a comment.
> Are there any of the intrinsics in the headers that also depend on x87?
Not that I could find.
Comment at: lib/Basic/Targets.cpp:2545-2546
@@ -2544,2 +2544,4 @@
- switch (getCPUKind(CPU)) {
+ CPUKind Kind = getCPUKind(CPU);
+
+ // All X86
aturetsk added a comment.
Hello Richard,
Thank for the review.
Comment at: lib/Basic/Targets.cpp:2538-2539
@@ -2537,1 +2537,4 @@
+ // All X86 processors but i386 have X87.
+ if (getCPUKind(CPU) != CK_i386)
+setFeatureEnabledImpl(Features, "x87", true);
aturetsk created this revision.
aturetsk added a reviewer: rsmith.
aturetsk added a subscriber: cfe-commits.
Add 'x87' in x86 target feature map
http://reviews.llvm.org/D13980
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86-mmx.c
test/CodeGen/attr-target-x86.c
Index:
14 matches
Mail list logo
