This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6e794ba0b238: [Clang][RISCV] Guard vector int64, float32,
float64 with semantic analysis (authored by eopXD).
Repository:
rG LLVM Github Monorepo
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143665/new/
https://reviews.llvm.org/D143665
___
eopXD updated this revision to Diff 497224.
eopXD added a comment.
Update code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143665/new/
https://reviews.llvm.org/D143665
Files:
clang/lib/Sema/Sema.cpp
clang/lib/Sema/SemaRISCVVectorLookup.cpp
eopXD updated this revision to Diff 497223.
eopXD added a comment.
Update code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143665/new/
https://reviews.llvm.org/D143665
Files:
clang/include/clang/Basic/RISCVVTypes.def
clang/lib/Sema/Sema.cpp
craig.topper added inline comments.
Comment at: clang/lib/Sema/Sema.cpp:2049
-if (Ty->isVectorFloat16Type() &&
-!Context.getTargetInfo().hasVectorFloat16Support()) {
+if ((Ty->isVectorInt64Type() &&
+ !Context.getTargetInfo().hasVectorInt64Support()) ||
eopXD added inline comments.
Comment at: clang/lib/Sema/Sema.cpp:2049
-if (Ty->isVectorFloat16Type() &&
-!Context.getTargetInfo().hasVectorFloat16Support()) {
+if ((Ty->isVectorInt64Type() &&
+ !Context.getTargetInfo().hasVectorInt64Support()) ||
---
eopXD added inline comments.
Comment at: clang/include/clang/Basic/TargetInfo.h:668
+ /// Determine whether vector int64 type is supported on this target.
+ virtual bool hasVectorInt64Support() const { return false; }
+
craig.topper wrote:
> Having a different
craig.topper added inline comments.
Comment at: clang/include/clang/AST/Type.h:7209
+inline bool Type::isVectorFloat32Type() const {
+#define RVV_TYPE(Name, Id, SingletonId) false ||
This function is RVV specific so it's name is misleading. It's also identical
eopXD updated this revision to Diff 496185.
eopXD added a comment.
Bump CI.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143665/new/
https://reviews.llvm.org/D143665
Files:
clang/include/clang/AST/Type.h
clang/include/clang/Basic/RISCVVTypes.
eopXD created this revision.
eopXD added reviewers: craig.topper, aaron.ballman, kito-cheng, asb.
Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro,
luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,
PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, e
10 matches
Mail list logo