[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

2023-09-16 Thread Faisal Vali via Phabricator via cfe-commits
faisalv closed this revision. faisalv added a comment. Sorry about the delay - this patch has landed - https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

2023-09-15 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. In D150075#4646487 , @royjacobson wrote: > @shafik @aaron.ballman does any of you want to commandeer this diff? seems > simple enough of a change I think Aaron might be better since he is more familiar with Windows.

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

2023-09-15 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson added a comment. @shafik @aaron.ballman does any of you want to commandeer this diff? seems simple enough of a change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150075/new/ https://reviews.llvm.org/D150075

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

2023-05-08 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150075/new/ https://reviews.llvm.org/D150075

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

2023-05-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Can you also add a release note for the fix? The changes generally LGTM Comment at: clang/test/SemaCXX/cxx23-static-callop-lambda-expression.cpp:12 + + auto lstatic = []() static consteval //expected-note {{declared here}}

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

2023-05-07 Thread Faisal Vali via Phabricator via cfe-commits
faisalv created this revision. faisalv added reviewers: aaron.ballman, shafik, royjacobson. faisalv added a project: clang. Herald added a subscriber: pengfei. Herald added a project: All. faisalv requested review of this revision. Herald added a subscriber: cfe-commits. See issue