mcrosier added a comment.
In https://reviews.llvm.org/D40476#936700, @mcrosier wrote:
> In https://reviews.llvm.org/D40476#936372, @pirama wrote:
>
> > Thanks for the review. Now let's just hope the windows bots stay happy :)
>
>
> Actually, I just checked and it looks like falkor and saphira
mcrosier added a comment.
In https://reviews.llvm.org/D40476#936372, @pirama wrote:
> Thanks for the review. Now let's just hope the windows bots stay happy :)
Actually, I just checked and it looks like falkor and saphira were both added
as of a few weeks ago. I'll revert this part of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319077: Switch CPU names not recognized by GNU assembler
(authored by pirama).
Repository:
rL LLVM
https://reviews.llvm.org/D40476
Files:
cfe/trunk/lib/Driver/ToolChains/Gnu.cpp
pirama updated this revision to Diff 124417.
pirama added a comment.
Normalize falkor and saphira as well.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
mcrosier added a comment.
Am I correct in assuming this is going to be a problem for Falkor and Saphira
as well? If so, can you add solutions for those as well? Cortex-a57 should be
good enough for those targets as well.
https://reviews.llvm.org/D40476
pirama updated this revision to Diff 124415.
pirama added a comment.
Sink 'Arg *' declaration.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
===
---
srhines added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:661
Arg *A;
-if ((A = Args.getLastArg(options::OPT_mcpu_EQ)) &&
-StringRef(A->getValue()).equals_lower("krait"))
- CmdArgs.push_back("-mcpu=cortex-a15");
-else
-
pirama updated this revision to Diff 124410.
pirama added a comment.
Address review comments.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
===
---
srhines added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:660
+// of a cpu flag.
+Arg *A = Args.getLastArg(options::OPT_mcpu_EQ);
+if (A) {
Is it better to sink A into the if condition again?
Comment at:
pirama updated this revision to Diff 124318.
pirama added a comment.
Few refactorings.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
===
--- /dev/null
pirama created this revision.
Using -no-integrated-as causes -mcpu=kryo to fail since GNU assembler
doesn't recognize kryo. Cortex-a57 is the closest CPU to kryo that the
assembler does recognize. So we should switch the assembler to use
that instead.
https://reviews.llvm.org/D40476
Files:
11 matches
Mail list logo