teemperor abandoned this revision.
teemperor added a comment.
So, the idea of going back to the headers and see if we can potentially remove
mm_malloc from the modulemap didn't work out (mostly because a lot of headers
include it indirectly).
However, when going back to the original issue i
joerg added a comment.
This header is used on systems without glibc. So please don't argue about
behavior based only on that. Granted, most other libc implementation are less
annoying when it comes to `free` and `malloc`, but still.
CHANGES SINCE LAST ACTION
teemperor added a comment.
@joerg Yeah, we saw the commit explaining why the original fwd declaration
patch was reverted. However, from what I can see, we only have three ways to
fix the cyclic dependency between glibc and Clang's internal module:
1. We say that we don't support including
v.g.vassilev added a comment.
ping...
https://reviews.llvm.org/D43871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teemperor updated this revision to Diff 164885.
teemperor marked 3 inline comments as done.
teemperor added a comment.
- Removed comment about redeclaring free in the test. That's wasn't correctly
formulated and is anyway no longer true now that the test case including this
file got bigger.
-
joerg added a comment.
Please check the history of the file for some of the problems with the
redefinition. I'm quite against this change.
https://reviews.llvm.org/D43871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Headers/mm_malloc.h:42
extern "C" int posix_memalign(void **__memptr, size_t __alignment, size_t
__size);
+extern "C" void(free)(void *ptr);
+extern
teemperor updated this revision to Diff 162940.
teemperor marked an inline comment as done.
teemperor added a comment.
- Reverted unintended change to test case that slipped into the latest diff.
https://reviews.llvm.org/D43871
Files:
lib/Headers/mm_malloc.h
lib/Sema/SemaExceptionSpec.cpp
teemperor marked 3 inline comments as done.
teemperor added inline comments.
Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:6
+#include "libc-empty-except.h"
+
+void f() {
bruno wrote:
> In a testcase like this but using the actual real headers,
teemperor updated this revision to Diff 162902.
teemperor added a comment.
- Now using UpdateExceptionSpec.
- Added a comment to the SemaExceptionSpec.cpp code why we are permitting this.
https://reviews.llvm.org/D43871
Files:
lib/Headers/mm_malloc.h
lib/Sema/SemaExceptionSpec.cpp
teemperor planned changes to this revision.
teemperor marked an inline comment as done.
teemperor added a comment.
(Just marking this as "Plan changes" because otherwise it's just stuck in my
"Waiting on review" queue).
https://reviews.llvm.org/D43871
rsmith added inline comments.
Comment at: lib/Sema/SemaExceptionSpec.cpp:312
+OldProto->getReturnType(), OldProto->getParamTypes(),
+OldProto->getExtProtoInfo().withExceptionSpec(EST_DynamicNone)));
+return false;
Updating the old function's
v.g.vassilev added inline comments.
Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:27
+#else
+#include "mm_malloc.h"
+#include "stdlib.h"
Maybe we should reverse the includes here as we discussed offline.
https://reviews.llvm.org/D43871
teemperor updated this revision to Diff 139963.
teemperor added a comment.
- Added more test cases for reverse include order and clang modules.
https://reviews.llvm.org/D43871
Files:
lib/Headers/mm_malloc.h
lib/Sema/SemaExceptionSpec.cpp
chandlerc resigned from this revision.
chandlerc added a comment.
I think this is more a question for Richard... Add me back to the reviewers if
there is a specific need for my input here.
Repository:
rC Clang
https://reviews.llvm.org/D43871
bruno added inline comments.
Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:3
+// RUN: not %clang_cc1 -std=c++11 -I %S/libc-empty-except-sys -fexceptions
-fcxx-exceptions -fsyntax-only -verify %s
+
+// expected-no-diagnostics
Since this is
teemperor created this revision.
teemperor added reviewers: rsmith, v.g.vassilev, chandlerc.
The GNU C library includes headers from the `_Builtin_intrinsics` module. As
the `_Builtin_intrinsics` module via
the `mm_malloc.h` header also includes the `stdlib.h` header from libc, we get
a cyclic
17 matches
Mail list logo