This revision was automatically updated to reflect the committed changes.
Closed by commit rC340649: Reland r340552, "Driver: Enable
address-significance tables by default when… (authored by pcc, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51049
Files:
lib/Driver/ToolChai
pcc added a comment.
https://reviews.llvm.org/D51199 fixes the above breakage as well as
crbug.com/877235. Once it lands, I'll reland this change.
Repository:
rC Clang
https://reviews.llvm.org/D51049
___
cfe-commits mailing list
cfe-commits@list
pcc reopened this revision.
pcc added a comment.
This revision is now accepted and ready to land.
I received another report of breakage so I reverted in
https://reviews.llvm.org/rC340579.
Repository:
rC Clang
https://reviews.llvm.org/D51049
___
pcc added a comment.
Thanks, I'll take a look.
Repository:
rC Clang
https://reviews.llvm.org/D51049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka added a comment.
This breaks Windows bot
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/33846/steps/run%20check-asan/logs/stdio
742542.065 [0/1/37] Running the AddressSanitizer tests
-- Testing: 607 tests, 16 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50
FAIL: A
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340552: Driver: Enable address-significance tables by
default when targeting COFF. (authored by pcc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51049?vs=161763&id=162232#toc
Rep
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Excellent!
Repository:
rL LLVM
https://reviews.llvm.org/D51049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
pcc added a comment.
With ELF it was around 0.1% for a self-host of Clang. I also checked the
overhead with COFF for Chromium's base_unittests and it was around 0.2% without
debug info. I think that's small enough that we can turn this on by default.
Repository:
rL LLVM
https://reviews.llvm
rnk added a comment.
Remind me what the approximate size overhead of this is? I expect it is
negligible, as most symbols are not address taken.
Repository:
rL LLVM
https://reviews.llvm.org/D51049
___
cfe-commits mailing list
cfe-commits@lists.ll
pcc created this revision.
pcc added a reviewer: rnk.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51049
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/addrsig.c
Index: clang/test/Driver/addrsig.c
=
10 matches
Mail list logo