This revision was automatically updated to reflect the committed changes.
Closed by commit rC347262: [Coverage] Fix PR39258: support coverage regions
that start deeper than they end (authored by vedantk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53244?vs=172042&id=17466
orivej added a comment.
@vsk, I think this is ready, but I don't have the merge rights. Could you
commit it and https://reviews.llvm.org/D53231 for me?
Repository:
rC Clang
https://reviews.llvm.org/D53244
___
cfe-commits mailing list
cfe-commits
vsk added a comment.
Friendly ping -- @orivej were you still looking for more feedback? If not, do
you still need someone to land this patch on your behalf?
Repository:
rC Clang
https://reviews.llvm.org/D53244
___
cfe-commits mailing list
cfe-co
orivej updated this revision to Diff 172042.
orivej added a comment.
Remove unrelated change.
Repository:
rC Clang
https://reviews.llvm.org/D53244
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macros.c
Index: test/CoverageMapping/macros.c
===
orivej updated this revision to Diff 172041.
orivej added a comment.
Herald added a subscriber: mgorny.
Use relative line offset.
Repository:
rC Clang
https://reviews.llvm.org/D53244
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macros.c
tools/CMakeLists.txt
Index: to
orivej added a comment.
Thanks! Could you merge this (after a while to let others review)?
Comment at: test/CoverageMapping/macros.c:60
+// CHECK-NEXT: func6
+void func6(unsigned count) { // CHECK-NEXT: File 0, [[@LINE]]:28 ->
[[@LINE+4]]:2 = #0
vsk wrote:
>
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Comment at: test/CoverageMapping/macros.c:60
+// CHECK-NEXT: func6
+void func6(unsigned count) { // CHECK-NEXT: File 0, [[@LINE]]:28 ->
[[@LINE+4]]:2 = #0
orivej updated this revision to Diff 169568.
orivej added a comment.
Fix typo
Repository:
rC Clang
https://reviews.llvm.org/D53244
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macros.c
Index: test/CoverageMapping/macros.c
===
orivej updated this revision to Diff 169562.
orivej added a comment.
This looks better to me. (There is no difference in check-clang test results.)
Repository:
rC Clang
https://reviews.llvm.org/D53244
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/macros.c
Index: test/Co
orivej created this revision.
orivej added reviewers: bogner, rsmith, vsk, aaron.ballman.
Herald added a subscriber: cfe-commits.
popRegions used to assume that the start location of a region can't be nested
deeper than the end location, which is not always true.
Repository:
rC Clang
https:/
10 matches
Mail list logo