This revision was automatically updated to reflect the committed changes.
Closed by commit rGfec1f2109f33: [OpenMP] Emit remarks during GPU state machine
optimization (authored by jdoerfert).
Changed prior to commit:
https://reviews.llvm.org/D83707?vs=277962=278059#toc
Repository:
rG LLVM
ye-luo accepted this revision.
ye-luo added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83707/new/
https://reviews.llvm.org/D83707
jdoerfert updated this revision to Diff 277962.
jdoerfert added a comment.
Add SPMD tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83707/new/
https://reviews.llvm.org/D83707
Files:
jdoerfert updated this revision to Diff 277951.
jdoerfert added a comment.
Improve wording (again)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83707/new/
https://reviews.llvm.org/D83707
Files:
jdoerfert updated this revision to Diff 277889.
jdoerfert added a comment.
Improve wording
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83707/new/
https://reviews.llvm.org/D83707
Files:
jdoerfert updated this revision to Diff 277524.
jdoerfert added a comment.
simplify test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83707/new/
https://reviews.llvm.org/D83707
Files:
ye-luo added inline comments.
Comment at: clang/test/OpenMP/remarks_parallel_in_target_state_machine.c:12
+#pragma omp parallel // #1
+// expected-remark@#1 {{Found parallel region that is called through a
state machine__omp_outlined__2_wrapper in non-SPMD target
jdoerfert created this revision.
jdoerfert added reviewers: jhuber6, fghanim, JonChesterfield, grokos,
AndreyChurbanov, ye-luo, tianshilei1992, ggeorgakoudis.
Herald added subscribers: llvm-commits, cfe-commits, sstefan1, guansong, bollu,
hiraditya, yaxunl.
Herald added projects: clang, LLVM.