[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG850325348ae8: [clang-format] Fix misformatted macro definitions after D86959 (authored by arichardson). Changed prior to commit: https://reviews.l

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88956/new/ https://reviews.llvm.org/D88956 _

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson updated this revision to Diff 299054. arichardson added a comment. fix name of test class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88956/new/ https://reviews.llvm.org/D88956 Files: clang/lib/Format/TokenAnnotator.cpp clang/uni

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson updated this revision to Diff 299039. arichardson added a comment. Herald added a subscriber: mgorny. Split the token annotion test into a separate file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88956/new/ https://reviews.llvm.org/D

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8365 + EXPECT_TOKEN(Tokens[11], tok::star, TT_PointerOrReference); + verifyFormat("#define lambda [](const decltype(x) *ptr) {}"); +} I like this style of test, I think some

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

MyDeveloperDay added a comment. I have noticed that clang-format has a tendency to over eagerly make * and & a TT_BinaryOperator, I know its too late to change it now, but sometimes I wonder if they should be detected as TT_PointerOrReference and then the clauses try and expose when they are be

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

klimek added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8333 +TEST_F(FormatTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) { + // This is a regression test for mis-parsing the & after decltype as a binary arichardson wrote: > aricha

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8333 +TEST_F(FormatTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) { + // This is a regression test for mis-parsing the & after decltype as a binary klimek wrote: > I'd pu

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

klimek added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8333 +TEST_F(FormatTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) { + // This is a regression test for mis-parsing the & after decltype as a binary I'd put this into a new tes

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson updated this revision to Diff 296640. arichardson added a comment. remove unneccessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88956/new/ https://reviews.llvm.org/D88956 Files: clang/lib/Format/TokenAnnotator.cpp clan

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, sammccall, klimek, JakeMerdichAMD, curdeius. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. arichardson requested review of this revision. After D86959 the