This revision was automatically updated to reflect the committed changes.
Closed by commit rG980618145bf0: [clang-tidy][docs] Update check options with
boolean values instead of non… (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
njames93 updated this revision to Diff 309661.
njames93 added a comment.
Update bugprone-not-null-terminated-result incorrect option name
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92652/new/
https://reviews.llvm.org/D92652
Files:
clang-tools
njames93 removed a subscriber: Charusso.
njames93 added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60
- If copy to the destination array can overflow [1] and
- ``AreSafeFunctionsAvailable`` is set to ``Yes``, `
Charusso added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60
- If copy to the destination array can overflow [1] and
- ``AreSafeFunctionsAvailable`` is set to ``Yes``, ``y`` or non-zero and it is
+ ``AreSafeFu
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, thank you for this cleanup!
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60
- If copy to the destination array can overflow [1] and
- ``AreSafeFunctions
njames93 updated this revision to Diff 309605.
njames93 added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92652/new/
https://reviews.llvm.org/D92652
Files:
clang-tools-extra/docs/clang-tidy/checks/bugprone-argument-
njames93 marked 3 inline comments as done.
njames93 added a subscriber: Charusso.
njames93 added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60
- If copy to the destination array can overflow [1] and
- ``AreSafe
aaron.ballman added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst:60
- If copy to the destination array can overflow [1] and
- ``AreSafeFunctionsAvailable`` is set to ``Yes``, ``y`` or non-zero and it is
+ ``AreS
sylvestre.ledru added a comment.
Thanks for doing that :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92652/new/
https://reviews.llvm.org/D92652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Eugene.Zelenko accepted this revision.
Eugene.Zelenko added a comment.
This revision is now accepted and ready to land.
Looks OK for me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92652/new/
https://reviews.llvm.org/D92652
_
njames93 updated this revision to Diff 309519.
njames93 added a comment.
Whoops missed one
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92652/new/
https://reviews.llvm.org/D92652
Files:
clang-tools-extra/docs/clang-tidy/checks/bugprone-argument
njames93 created this revision.
njames93 added reviewers: Eugene.Zelenko, aaron.ballman.
Herald added subscribers: kbarton, xazax.hun, nemanjai.
njames93 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Using bools instead of integers better
12 matches
Mail list logo