Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

2015-09-10 Thread Hans Wennborg via cfe-commits
+Tom for 3.7.1 On Fri, Aug 21, 2015 at 6:41 PM, Saleem Abdulrasool wrote: > On Fri, Aug 21, 2015 at 11:02 AM, Hans Wennborg wrote: >> >> On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool >> wrote: >> > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg >> > wrote: >> >> >> >> +Saleem and Renato;

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

2015-08-21 Thread Saleem Abdulrasool via cfe-commits
On Fri, Aug 21, 2015 at 11:02 AM, Hans Wennborg wrote: > On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool > wrote: > > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg > wrote: > >> > >> +Saleem and Renato; maybe you can take a look? > > > > > > Thanks for pointing this out! > > > > The patch

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

2015-08-21 Thread Hans Wennborg via cfe-commits
On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool wrote: > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg wrote: >> >> +Saleem and Renato; maybe you can take a look? > > > Thanks for pointing this out! > > The patch is correct and pretty safe to apply for 3.7 I think since its a > simple bug fi

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

2015-08-20 Thread Saleem Abdulrasool via cfe-commits
On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg wrote: > +Saleem and Renato; maybe you can take a look? Thanks for pointing this out! The patch is correct and pretty safe to apply for 3.7 I think since its a simple bug fix, and can result in VFP state corruption (the invalid memory access in th

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

2015-08-20 Thread Hans Wennborg via cfe-commits
+Saleem and Renato; maybe you can take a look? On Tue, Aug 18, 2015 at 11:24 AM, Leandro GraciĆ” Gil wrote: > Hi, > > Please find attached a patch fixing an out-of-bounds array access present in > the current libunwind top of tree code. > > The problem is caused by subtracting the wrong base regis

[PATCH] Fix out-of-bounds array access when setting arm float registers

2015-08-18 Thread Leandro GraciĆ” Gil via cfe-commits
Hi, Please find attached a patch fixing an out-of-bounds array access present in the current libunwind top of tree code. The problem is caused by subtracting the wrong base register in Registers_arm::SetFloatRegister and should become obvious after taking a quick look to the code. Could someone