https://github.com/danix800 closed
https://github.com/llvm/llvm-project/pull/76619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danix800 wrote:
> LGTM but please add a release note so users know about the bug fix.
Release note added.
https://github.com/llvm/llvm-project/pull/76619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/danix800 updated
https://github.com/llvm/llvm-project/pull/76619
>From 0ca1a2b2573d1f89a1b4d13cd43628a46c1e5c98 Mon Sep 17 00:00:00 2001
From: dingfei
Date: Sun, 31 Dec 2023 00:32:01 +0800
Subject: [PATCH] [ASTMatchers] fix captureVars assertion failure on
capturesVariables
https://github.com/AaronBallman approved this pull request.
LGTM but please add a release note so users know about the bug fix.
https://github.com/llvm/llvm-project/pull/76619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
danix800 wrote:
> Thank you for the fix, can you add more details to your summary. The summary
> is what usually goes into the git log. We would like those to be as
> descriptive as possible to avoid having to do extra digging to understand the
> change at a high level.
Thanks for reminding.
https://github.com/danix800 edited
https://github.com/llvm/llvm-project/pull/76619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/danix800 updated
https://github.com/llvm/llvm-project/pull/76619
>From 50c0ccd9a28896a1f8f673446054abd6f18703a9 Mon Sep 17 00:00:00 2001
From: dingfei
Date: Sun, 31 Dec 2023 00:32:01 +0800
Subject: [PATCH] [ASTMatchers] fix captureVars assertion failure on
capturesVariables
https://github.com/shafik commented:
Thank you for the fix, can you add more details to your summary. The summary is
what usually goes into the git log. We would like those to be as descriptive as
possible to avoid having to do extra digging to understand the change at a high
level.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ding Fei (danix800)
Changes
Fixes #76425
---
Full diff: https://github.com/llvm/llvm-project/pull/76619.diff
2 Files Affected:
- (modified) clang/include/clang/ASTMatchers/ASTMatchers.h (+2)
- (modified)
https://github.com/danix800 created
https://github.com/llvm/llvm-project/pull/76619
Fixes #76425
>From b26fa2acfd4974d1c09eef408b4d6c2dcbb16479 Mon Sep 17 00:00:00 2001
From: dingfei
Date: Sun, 31 Dec 2023 00:32:01 +0800
Subject: [PATCH] [ASTMatchers] fix captureVars assertion failure on
10 matches
Mail list logo