[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-03-06 Thread Balazs Benics via cfe-commits
=?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. Still looks good. https://github.com/llvm/llvm-project/pull/78442 ___ cfe-commits mailing list

[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-03-06 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: NagyDonat wrote: Thanks for the approval; I forgot about this issue a few weeks ago. Now that you reminded me, I tried to research its cause and dropped a FIXME onto the statement that is not sound logically.

[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-03-05 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-01-19 Thread via cfe-commits
NagyDonat wrote: I didn't check for potential solutions yet, I wanted to document and report this ASAP and then switch to other tasks. I think I'll leave this commit here without merging it for some time, and if I don't end up resolving this within a month, then I'll find a place for this TC

[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-01-19 Thread Balazs Benics via cfe-commits
steakhal wrote: I'd advise against introducing a separate file for this, but I'm okay with landing tests. Given this issue, I'd be interested to look at how difficult it is to actually fix it and commit the case along with the fix. Have you looked at potential solutions?

[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-01-17 Thread via cfe-commits
NagyDonat wrote: I don't know what's the usual policy for testcases like this that demonstrate a bug: we could merge it to have an in-repository reminder (which automatically alerts us when a change fixes this issue), or we could leave it as an open pull request to avoid cluttering the

[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (NagyDonat) Changes This commit adds a testcase which highlights the current incorrect behavior of the CSA diagnostic generation: it produces a note which says "Assuming 'arg' is = 0" in a situation where this is not a fresh

[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-01-17 Thread via cfe-commits
https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/78442 This commit adds a testcase which highlights the current incorrect behavior of the CSA diagnostic generation: it produces a note which says "Assuming 'arg' is >= 0" in a situation where this is not a fresh