@@ -402,7 +402,7 @@ def warn_unused_function : Warning<"unused function %0">,
InGroup, DefaultIgnore;
def warn_unused_template : Warning<"unused %select{function|variable}0
template %1">,
InGroup, DefaultIgnore;
-def warn_unused_member_function : Warning<"unused member fun
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -76,10 +76,33 @@ struct S {
struct SVS : public VS {
void vm() { }
};
+
+ struct CS {
AaronBallman wrote:
When switching the diagnostic approach, be sure to add test coverage for unused
copy/move constructors, copy/move assignment, and destructors
https://github.com/AaronBallman commented:
Thank you for the diagnostic improvement!
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
Ping.
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
guillem-bartina-sonarsource wrote:
Ping
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/guillem-bartina-sonarsource updated
https://github.com/llvm/llvm-project/pull/84515
>From 473e8bbeaa8bcb4fb313a5cc75cc7a5de5367879 Mon Sep 17 00:00:00 2001
From: guillem-bartina-sonarsource
Date: Fri, 8 Mar 2024 17:16:56 +0100
Subject: [PATCH 1/4] [clang][Sema] Refine unused-
https://github.com/guillem-bartina-sonarsource edited
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/guillem-bartina-sonarsource updated
https://github.com/llvm/llvm-project/pull/84515
>From 473e8bbeaa8bcb4fb313a5cc75cc7a5de5367879 Mon Sep 17 00:00:00 2001
From: guillem-bartina-sonarsource
Date: Fri, 8 Mar 2024 17:16:56 +0100
Subject: [PATCH 1/3] [clang][Sema] Refine unused-
hazohelet wrote:
Please add a release note line to `clang/docs/ReleaseNotes.rst` because this
patch changes the diagnostic behavior of clang
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/guillem-bartina-sonarsource edited
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -76,10 +76,33 @@ struct S {
struct SVS : public VS {
void vm() { }
};
+
+ struct CS {
+CS() {}
+CS(bool a) {}
+CS(int b) {} // expected-warning{{unused constructor 'CS'}}
+CS(float c);
+ };
+
+ struct DCS : public CS {
+DCS() = default; // expe
@@ -76,10 +76,33 @@ struct S {
struct SVS : public VS {
void vm() { }
};
+
+ struct CS {
+CS() {}
+CS(bool a) {}
+CS(int b) {} // expected-warning{{unused constructor 'CS'}}
+CS(float c);
+ };
+
+ struct DCS : public CS {
+DCS() = default; // expe
guillem-bartina-sonarsource wrote:
Ping
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/guillem-bartina-sonarsource updated
https://github.com/llvm/llvm-project/pull/84515
>From 473e8bbeaa8bcb4fb313a5cc75cc7a5de5367879 Mon Sep 17 00:00:00 2001
From: guillem-bartina-sonarsource
Date: Fri, 8 Mar 2024 17:16:56 +0100
Subject: [PATCH] [clang][Sema] Refine unused-memb
https://github.com/guillem-bartina-sonarsource edited
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1398,11 +1398,16 @@ void Sema::ActOnEndOfTranslationUnit() {
if (FD->getDescribedFunctionTemplate())
Diag(DiagD->getLocation(), diag::warn_unused_template)
<< /*function=*/0 << DiagD << DiagRange;
- else
-Diag(DiagD
@@ -1398,11 +1398,16 @@ void Sema::ActOnEndOfTranslationUnit() {
if (FD->getDescribedFunctionTemplate())
Diag(DiagD->getLocation(), diag::warn_unused_template)
<< /*function=*/0 << DiagD << DiagRange;
- else
-Diag(DiagD
shafik wrote:
Looks like the build failed b/c you did not run `git clang-format`
https://github.com/llvm/llvm-project/pull/84515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (guillem-bartina-sonarsource)
Changes
The current diagnostic message is `unused member function A` for every kind of
method, including constructors. The idea is to refine the message to `unused
constructor A` when the method is a con
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/guillem-bartina-sonarsource created
https://github.com/llvm/llvm-project/pull/84515
The current diagnostic message is `unused member function A` for every kind of
method, including constructors. The idea is to refine the message to `unused
constructor A` when the method is a
22 matches
Mail list logo