[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-09-05 Thread via cfe-commits
seranu wrote: @jgollenz feel free use those commits https://github.com/llvm/llvm-project/pull/78957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-09-05 Thread Jonas Gollenz via cfe-commits
jgollenz wrote: @seranu if I have a look at this issue may I continue working from your commit or do you want me to start from scratch? https://github.com/llvm/llvm-project/pull/78957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-09-05 Thread via cfe-commits
@@ -3220,6 +3220,25 @@ the configuration (without a prefix: ``Auto``). +.. _EmptyLinesAfterIncludes: + +**EmptyLinesAfterIncludes** (``Unsigned``) :versionbadge:`clang-format 18` :ref:`¶ ` mydeveloperday wrote: 18 is now wrong it should be 20 https://gith

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-09-05 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. https://github.com/llvm/llvm-project/pull/78957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-09-04 Thread via cfe-commits
seranu wrote: @jgollenz hey, I'm not currently working on this MR. https://github.com/llvm/llvm-project/pull/78957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-09-04 Thread Jonas Gollenz via cfe-commits
jgollenz wrote: @seranu gentle ping :slightly_smiling_face: are you still working on this MR? https://github.com/llvm/llvm-project/pull/78957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-30 Thread via cfe-commits
@@ -0,0 +1,159 @@ +//===--- IncludesSeparator.cpp ---*- C++ -*-===// mydeveloperday wrote: > Does this have to be done in a separate pass? Couldn't it be done in the > normal formatting? +1 to that, we shouldn't really need a seperate pa

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-30 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. 18 isn't correct here as you can see here https://clang.llvm.org/docs/ClangFormatStyleOptions.html the "git" version is 19 https://github.com/llvm/llvm-project/pull/78957 ___ c

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-30 Thread via cfe-commits
@@ -3220,6 +3220,25 @@ the configuration (without a prefix: ``Auto``). +.. _EmptyLinesAfterIncludes: + +**EmptyLinesAfterIncludes** (``Unsigned``) :versionbadge:`clang-format 18` :ref:`¶ ` mydeveloperday wrote: I've always looked at the "Upcoming Release"

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-23 Thread Björn Schäpers via cfe-commits
@@ -0,0 +1,159 @@ +//===--- IncludesSeparator.cpp ---*- C++ -*-===// HazardyKnusperkeks wrote: Maybe you could work something out with the line type? https://github.com/llvm/llvm-project/blob/4fcd7cf22deff4a63d2bac12c909be7266f8b353/clang/

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread via cfe-commits
https://github.com/seranu edited https://github.com/llvm/llvm-project/pull/78957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread Björn Schäpers via cfe-commits
@@ -0,0 +1,159 @@ +//===--- IncludesSeparator.cpp ---*- C++ -*-===// HazardyKnusperkeks wrote: Does this have to be done in a separate pass? Couldn't it be done in the normal formatting? https://github.com/llvm/llvm-project/pull/78957 __

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread Björn Schäpers via cfe-commits
@@ -4831,6 +4848,7 @@ struct FormatStyle { DerivePointerAlignment == R.DerivePointerAlignment && DisableFormat == R.DisableFormat && EmptyLineAfterAccessModifier == R.EmptyLineAfterAccessModifier && + EmptyLinesAfterIncludes == R.Empty

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread Björn Schäpers via cfe-commits
@@ -3220,6 +3220,25 @@ the configuration (without a prefix: ``Auto``). +.. _EmptyLinesAfterIncludes: + +**EmptyLinesAfterIncludes** (``Unsigned``) :versionbadge:`clang-format 18` :ref:`¶ ` HazardyKnusperkeks wrote: Where do I have to sign up for that knowl

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread via cfe-commits
@@ -3220,6 +3220,25 @@ the configuration (without a prefix: ``Auto``). +.. _EmptyLinesAfterIncludes: + +**EmptyLinesAfterIncludes** (``Unsigned``) :versionbadge:`clang-format 18` :ref:`¶ ` mydeveloperday wrote: 18 will be correct today, but it won't be tom

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread via cfe-commits
https://github.com/seranu updated https://github.com/llvm/llvm-project/pull/78957 >From 501cd2230cc878189e2dde912bd659faf711a2db Mon Sep 17 00:00:00 2001 From: Serban Ungureanu Date: Sat, 20 Jan 2024 17:02:04 +0200 Subject: [PATCH] [clang-format] Add options to set number of empty lines after

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cc38cff05cfafb92bf91aadc39692ec5e12710a0 351995614fb6155bcb621860f18d97f727ece101 --

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread via cfe-commits
https://github.com/seranu edited https://github.com/llvm/llvm-project/pull/78957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread via cfe-commits
https://github.com/seranu edited https://github.com/llvm/llvm-project/pull/78957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: serbanu (seranu) Changes Add option to set the number of empty lines after include areas. An include area is a list of consecutive include statements. Include areas may be composed of multiple include blocks(group of related inclu

[clang] [clang-format] Add options to set number of empty lines after includes (PR #78957)

2024-01-22 Thread via cfe-commits
https://github.com/seranu created https://github.com/llvm/llvm-project/pull/78957 Add option to set the number of empty lines after include areas. An include area is a list of consecutive include statements. Include areas may be composed of multiple include blocks(group of related include sta