[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

2022-06-15 Thread Michael Spencer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG169417531578: [Clang][Modules] Merge availability attributes on imported decls (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

2022-06-15 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127182/new/ https://reviews.llvm.org/D127182 ___ cfe-commits mailing list cfe-c

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

2022-06-14 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added a comment. In D127182#3582540 , @jansvoboda11 wrote: > Should we add a FIXME saying we need to handle other kinds of attributes? There already is one where we call `mergeInheritableAttributes`. Repository: rG LLVM Github Monorepo CH

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

2022-06-14 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. Should we add a FIXME saying we need to handle other kinds of attributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127182/new/ https://reviews.llvm.org/D127182 ___ cfe-

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

2022-06-14 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127182/new/ https://reviews.llvm.org/D127182 ___ c

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

2022-06-06 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese created this revision. Bigcheese added reviewers: vsapsai, bruno. Bigcheese added a project: clang-modules. Herald added a project: All. Bigcheese requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we do not in general merg