This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGad96f25b9365: [AMDGPU] Rename predefined macro
__AMDGCN_WAVEFRONT_SIZE (authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM
yaxunl updated this revision to Diff 536431.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
revised by comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154207/new/
https://reviews.llvm.org/D154207
Files:
clang/lib/Basic/Targets/AMDGPU.cpp
arsenm added a comment.
lgtm except for dropping test coverage
Comment at: clang/test/Driver/hip-macros.hip:20
// RUN: -mwavefrontsize64 %s 2>&1 | FileCheck --check-prefixes=WAVE64 %s
-// WAVE64-DAG: #define __AMDGCN_WAVEFRONT_SIZE 64
-// WAVE32-DAG: #define
jdoerfert added a comment.
I think this is a step in the right direction. @arsenm ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154207/new/
https://reviews.llvm.org/D154207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318
+ Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE__", Twine(WavefrontSize));
+ // ToDo: deprecate this macro for naming consistency.
arsenm
arsenm added inline comments.
Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318
+ Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE__", Twine(WavefrontSize));
+ // ToDo: deprecate this macro for naming consistency.
If you're renaming it anyway, might as well go
yaxunl created this revision.
yaxunl added reviewers: arsenm, b-sumner, jdoerfert.
Herald added subscribers: kerbowa, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a subscriber: wdng.
rename it to __AMDGCN_WAVEFRONT_SIZE__
