[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

rZhBoYao added a comment. OK, will do it by the end of this week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158372/new/ https://reviews.llvm.org/D158372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. Given Richard's comments, it seems that changes are needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158372/new/ https://reviews.llvm.org/D158372

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:97 ^ -- Implemented `CWG1473 `_ which allows spaces after ``operator""``. - Clang used to err on the lack of space when the literal suffix

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

rZhBoYao added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1994-2009 if (!isAsciiIdentifierStart(C)) { if (C == '\\' && tryConsumeIdentifierUCN(CurPtr, Size, Result)) Consumed = true; else if (!isASCII(C) && tryConsumeIdentifierUTF8Char(CurPtr))

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

rZhBoYao updated this revision to Diff 552060. rZhBoYao marked 5 inline comments as done. rZhBoYao edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158372/new/ https://reviews.llvm.org/D158372 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:283-284 +def ext_ms_reserved_user_defined_literal : ExtWarn< + "invalid suffix on literal; C++11 requires a space between literal and " + "a macro">, InGroup; def

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9322 def warn_user_literal_reserved : Warning< - "user-defined literal suffixes %select{|not starting with '_'|containing '__'}0 are reserved" - "%select{; no literal will invoke

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

rZhBoYao created this revision. rZhBoYao added reviewers: clang-language-wg, aaron.ballman, jyknight. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a language extension, if an invalid a UDL's