This revision was automatically updated to reflect the committed changes.
Closed by commit rL284770: [Driver] Parse Debian version as integer when
possible. NFC (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25696?vs=75269=75345#toc
Repository:
rL LLVM
mgorny added a comment.
Thanks for the review. I'll now look into updating the code for other distros
to follow suit.
https://reviews.llvm.org/D25696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny updated this revision to Diff 75269.
mgorny added a comment.
Restructured and reformatted as requested.
https://reviews.llvm.org/D25696
Files:
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChains.cpp
===
---
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3903
+if (!Data.split('.').first.getAsInteger(10, MajorVersion)) {
+ switch (MajorVersion) {
+case 5:
clang-format the `switch`: `case`'s should be aligned with it.
mgorny created this revision.
mgorny added reviewers: bkramer, bruno, rafael.
mgorny added a subscriber: cfe-commits.
Replace the string matching for /etc/debian_version with split
integer/string matching algorithm. When the file contains 'major.minor'
version number, parse the major version as
