AndersRonnholm abandoned this revision.
AndersRonnholm added a comment.
Fixed by https://reviews.llvm.org/rL319021. At least for c/c++ not sure if it
handles objective-c.
Repository:
rL LLVM
https://reviews.llvm.org/D36672
___
cfe-commits
malcolm.parsons added a comment.
Fixed by https://reviews.llvm.org/rL319021?
Repository:
rL LLVM
https://reviews.llvm.org/D36672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:147
+if (const auto *Parent = Par->getParentFunctionOrMethod()) {
+ if (const auto *F = dyn_cast(Parent)) {
+const auto ParDecl =
AndersRonnholm
AndersRonnholm marked 2 inline comments as done.
AndersRonnholm added inline comments.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:147
+if (const auto *Parent = Par->getParentFunctionOrMethod()) {
+ if (const auto *F = dyn_cast(Parent)) {
+
AndersRonnholm updated this revision to Diff 114346.
AndersRonnholm added a comment.
Herald added subscribers: xazax.hun, JDevlieghere.
Fixed comments
Repository:
rL LLVM
https://reviews.llvm.org/D36672
Files:
clang-tidy/readability/NonConstParameterCheck.cpp
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:146
+
+if (const auto *Parent = Par->getParentFunctionOrMethod()) {
+ if (const auto *F = dyn_cast(Parent)) {
Please do not use `auto` here, as the type
danielmarjamaki added a comment.
LGTM. But others should approve.
Repository:
rL LLVM
https://reviews.llvm.org/D36672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
