[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

2017-10-11 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM - thanks! https://reviews.llvm.org/D38757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

2017-10-13 Thread David L. Jones via Phabricator via cfe-commits
dlj requested changes to this revision. dlj added a comment. This revision now requires changes to proceed. Hmm, looking more at this change... while it does make the behaviour consistent for Forward and Input iterators, I think it's just making them both do the wrong thing. Specifically, based

[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

2017-10-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. In https://reviews.llvm.org/D38757#897536, @dlj wrote: > Hmm, looking more at this change... while it does make the behaviour > consistent for Forward and Input iterators, I think it's just making them > both do the wrong thing. > > Specifi

[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

2017-10-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 119301. EricWF added a comment. - Update whitespace. https://reviews.llvm.org/D38757 Files: include/deque include/list include/vector test/std/containers/sequences/deque/deque.cons/assign_iter_iter.pass.cpp test/std/containers/sequences/deque/deque

[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

2017-10-17 Thread Eric Fiselier via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315994: [libc++] Fix PR34898 - vector iterator constructors and assign method perform… (authored by EricWF). Changed prior to commit: https://reviews.llvm.org/D38757?vs=119301&id=119302#toc Repository: